From nobody Thu May 2 16:29:12 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+46219+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+46219+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1566495621; cv=none; d=zoho.com; s=zohoarc; b=m31cxbAcxZfaGhOP1z92VpTfsZIIfUku9ZW8sZrEl2tjaKXTtlSII6hmpvBAWCFvIfCtBfVby2Au8EnKVVI+UaGFnAAQAhb5zhFEIygIT98BR885T1QjTUUKZ+0LnxP7QG/gzqycK8gQEaUGknzygLnRWnoc4aNedSTjyG7AxEg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1566495621; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=plTCGJ14hUyx5bxhRxKnh8VhvpU2r5ppjva3rsCkGu4=; b=W42I7xV8JIiTim06tMTFNPrzCHtnjhdofC93C0mjhwF9gDW2FT/APdK9A5FykV/8NWP53j6SQJOLHW+yY8u8mJzBhcuSo7mJhIAde3TPILUSml3VpNlKJFpnvC86WdvuFe41SyKOk4pAoG5hFSfwpnQnEkp6z8x24gLk0Uh78Ys= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+46219+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1566495621672878.1045100754476; Thu, 22 Aug 2019 10:40:21 -0700 (PDT) Return-Path: X-Received: from mga14.intel.com (mga14.intel.com []) by groups.io with SMTP; Thu, 22 Aug 2019 10:40:20 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Aug 2019 10:40:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,417,1559545200"; d="scan'208";a="190664968" X-Received: from makuback-desk1.amr.corp.intel.com ([10.7.159.162]) by orsmga002.jf.intel.com with ESMTP; 22 Aug 2019 10:40:20 -0700 From: "Kubacki, Michael A" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone , Liming Gao Subject: [edk2-devel] [edk2-platforms][PATCH V1 1/2] KabylakeOpenBoardPkg: Fix GCC Build Failures Date: Thu, 22 Aug 2019 10:40:07 -0700 Message-Id: <20190822174008.20624-2-michael.a.kubacki@intel.com> In-Reply-To: <20190822174008.20624-1-michael.a.kubacki@intel.com> References: <20190822174008.20624-1-michael.a.kubacki@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.a.kubacki@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1566495621; bh=DCTy77UzXTbjHbsIGXaWLF6CEVF9Z3jvMc61BlXzNDY=; h=Cc:Date:From:Reply-To:Subject:To; b=UX1xHpdoLE+Rclv98nXoquZn+HzmP8DrGtjse8Nxk9TrXAhq4eZOhXm2R5ICZoYu5/t 3Vpd2zHvfheEN7tPR0Sxr3HjLC9alYK3tkkla8cxDG9QxgSaUNkxRJ7uXngQ+GpKU0inA J382GpljOuZlSy46o0iRRdo6OV/yF/gT6jk= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2109 Fixes build failures on GCC7.3.0. Tested on Ubunutu 18.04.1 LTS. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone < --- Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapperPlatfo= rmSecLib/FspWrapperPlatformSecLib.c | 2 +- Platform/Intel/KabylakeOpenBoardPkg/Library/BaseGpioExpanderLib/BaseGpioEx= panderLib.c | 6 ++---- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspW= rapperPlatformSecLib/FspWrapperPlatformSecLib.c b/Platform/Intel/KabylakeOp= enBoardPkg/FspWrapper/Library/SecFspWrapperPlatformSecLib/FspWrapperPlatfor= mSecLib.c index d73fc77f69..d40eecae95 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapperP= latformSecLib/FspWrapperPlatformSecLib.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapperP= latformSecLib/FspWrapperPlatformSecLib.c @@ -174,7 +174,7 @@ SecPlatformMain ( // CopyMem (CopyDestinationPointer, mPeiCoreFvLocationPpiList, sizeof (mP= eiCoreFvLocationPpiList)); TopOfTemporaryRamPpiIndex =3D 1; - (UINT8 *) CopyDestinationPointer +=3D sizeof(mPeiCoreFvLocationPpiList= ); + CopyDestinationPointer +=3D sizeof (mPeiCoreFvLocationPpiList); } CopyMem (CopyDestinationPointer, mPeiSecPlatformPpi, sizeof(mPeiSecPlatf= ormPpi)); // diff --git a/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseGpioExpanderLi= b/BaseGpioExpanderLib.c b/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseG= pioExpanderLib/BaseGpioExpanderLib.c index ead1e6df19..acab1326ff 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseGpioExpanderLib/BaseG= pioExpanderLib.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseGpioExpanderLib/BaseG= pioExpanderLib.c @@ -70,12 +70,11 @@ GpioExpGetRegister ( IN UINT8 Register ) { - EFI_STATUS Status; UINT8 WriBuf[1]; UINT8 ReBuf[1] =3D {0}; =20 WriBuf[0] =3D Register; - Status =3D I2cWriteRead( Bar0, TCA6424_I2C_ADDRESS+Address, 1, WriBuf, 1= , ReBuf, WAIT_1_SECOND); + I2cWriteRead (Bar0, TCA6424_I2C_ADDRESS + Address, 1, WriBuf, 1, ReBuf, = WAIT_1_SECOND); =20 return ReBuf[0]; } @@ -99,13 +98,12 @@ GpioExpSetRegister ( IN UINT8 Value ) { - EFI_STATUS Status; UINT8 WriBuf[2]; =20 WriBuf[0] =3D Register; WriBuf[1] =3D Value; - Status =3D I2cWriteRead( Bar0, TCA6424_I2C_ADDRESS+Address, 2, WriBuf, 0= , NULL, WAIT_1_SECOND); =20 + I2cWriteRead (Bar0, TCA6424_I2C_ADDRESS + Address, 2, WriBuf, 0, NULL, W= AIT_1_SECOND); } /** Set the input register to a give value mentioned in the function. --=20 2.16.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#46219): https://edk2.groups.io/g/devel/message/46219 Mute This Topic: https://groups.io/mt/32992321/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Thu May 2 16:29:12 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+46220+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+46220+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1566495622; cv=none; d=zoho.com; s=zohoarc; b=g5G6fMVvSpOSX+bCYnYERdWmJx6Y5J9t2qyV97kj8v8iOjWL88KHx/DUzUL5ChQvKgo5HJz3QwgK/maggpt8mqLx6wLP+/2Pb23m3PNSZkXKlEo3OtGxtzuXM6SOF9pqhuLOOh1tiuCPTbMOkCg1MHWV9FhQoBXPW5PzaJoKZ80= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1566495622; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=q31BlYIfd+buJQ3jE9gS5vFCbSUVSKHdOvDKbPQXuv8=; b=dYOuGeSGEhD6AabLcFh7vfiUNZzU+D+fkr+3ZYZ2yvz0WOq0wDr0nvmFXx01RHNrXcmRivVdGDFbSebNyyz3kCoLMxEVUhJzBz/G94ecTu7Zli3uDwQt4HQlac6ugcM7fygDFw5iqaB/uYsPz2htagY0s05JtjGVtaZcU+Don44= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+46220+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1566495622456532.8381343569682; Thu, 22 Aug 2019 10:40:22 -0700 (PDT) Return-Path: X-Received: from mga14.intel.com (mga14.intel.com []) by groups.io with SMTP; Thu, 22 Aug 2019 10:40:21 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Aug 2019 10:40:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,417,1559545200"; d="scan'208";a="190664982" X-Received: from makuback-desk1.amr.corp.intel.com ([10.7.159.162]) by orsmga002.jf.intel.com with ESMTP; 22 Aug 2019 10:40:21 -0700 From: "Kubacki, Michael A" To: devel@edk2.groups.io Cc: Nate DeSimone , Liming Gao , Ankit Sinha Subject: [edk2-devel] [edk2-platforms][PATCH V1 2/2] ClevoOpenBoardPkg: Fix GCC Build Failures Date: Thu, 22 Aug 2019 10:40:08 -0700 Message-Id: <20190822174008.20624-3-michael.a.kubacki@intel.com> In-Reply-To: <20190822174008.20624-1-michael.a.kubacki@intel.com> References: <20190822174008.20624-1-michael.a.kubacki@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.a.kubacki@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1566495622; bh=Xdsu/mwWrjipVWZ4IjEun0jx8v8tbE98WMykgBr2cXs=; h=Cc:Date:From:Reply-To:Subject:To; b=aaMaRWnHK94AFRW3fzvBOWY7TKdTWnYtSpM6oaww9OANLQfxmBz+vIpiphWN8pofaBT xTN03UHrDVr7I7hxpwkZLNdzUsMCm97+DBDdKfkojv4nv1RPAdyaNBggiXdciTnz3+JYD SnK3PIL8ZnUaFla0yHtcHOx2UhkKCaCAMUk= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Fixes build failures on GCC7.3.0. Tested on Ubunutu 18.04.1 LTS. Cc: Nate DeSimone Cc: Liming Gao Cc: Ankit Sinha Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone --- Platform/Intel/ClevoOpenBoardPkg/Library/BaseGpioExpanderLib/BaseGpioExpan= derLib.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/Platform/Intel/ClevoOpenBoardPkg/Library/BaseGpioExpanderLib/B= aseGpioExpanderLib.c b/Platform/Intel/ClevoOpenBoardPkg/Library/BaseGpioExp= anderLib/BaseGpioExpanderLib.c index 260c5bb6a2..cc70f15c24 100644 --- a/Platform/Intel/ClevoOpenBoardPkg/Library/BaseGpioExpanderLib/BaseGpio= ExpanderLib.c +++ b/Platform/Intel/ClevoOpenBoardPkg/Library/BaseGpioExpanderLib/BaseGpio= ExpanderLib.c @@ -70,12 +70,11 @@ GpioExpGetRegister ( IN UINT8 Register ) { - EFI_STATUS Status; UINT8 WriBuf[1]; UINT8 ReBuf[1] =3D {0}; =20 WriBuf[0] =3D Register; - Status =3D I2cWriteRead( Bar0, TCA6424_I2C_ADDRESS+Address, 1, WriBuf, 1= , ReBuf, WAIT_1_SECOND); + I2cWriteRead (Bar0, TCA6424_I2C_ADDRESS + Address, 1, WriBuf, 1, ReBuf, = WAIT_1_SECOND); =20 return ReBuf[0]; } @@ -99,13 +98,11 @@ GpioExpSetRegister ( IN UINT8 Value ) { - EFI_STATUS Status; UINT8 WriBuf[2]; =20 WriBuf[0] =3D Register; WriBuf[1] =3D Value; - Status =3D I2cWriteRead( Bar0, TCA6424_I2C_ADDRESS+Address, 2, WriBuf, 0= , NULL, WAIT_1_SECOND); - + I2cWriteRead (Bar0, TCA6424_I2C_ADDRESS + Address, 2, WriBuf, 0, NULL, W= AIT_1_SECOND); } /** Set the input register to a give value mentioned in the function. --=20 2.16.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#46220): https://edk2.groups.io/g/devel/message/46220 Mute This Topic: https://groups.io/mt/32992322/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-