From nobody Mon Feb 9 21:21:09 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+45814+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+45814+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1565949626; cv=none; d=zoho.com; s=zohoarc; b=BQk5t75+rnNUUaiusDR+oNwefPqH5IpL3WB6mglR7gUvgK2C9LLtRbvI55jdilwKr1rHstm3Bc0N08wDNMbiN2zEyAJEBr2ASFzAGPVjWy8iMNTb6I5NQRiyzpm+AelSaKAsLXuuejdpCCV2N3BXMQb0pGENou2BaMSww1WuR4c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1565949626; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=1o97U6tIY0amspJSv5PaRiZSXK6Eb6qamqfS/XR5yoQ=; b=UhV4RLR7ek+P/HDqWcglPnnePTHs7NGp88v2tjUjyE1n/QwYhiPZfJLHdQMMYPqDe1USljMqvsmBQRzlC2tZWOcsl8tTqFcPao1hn42jiHDNzIXRQiowRXzOSnsQGVuS5Y5WLI+Bhw/QLIUOlCGkvg3g5ELtjyqJnk/SrRVGXZ4= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+45814+1787277+3901457@groups.io Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1565949626016981.8340061276053; Fri, 16 Aug 2019 03:00:26 -0700 (PDT) Return-Path: X-Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by groups.io with SMTP; Fri, 16 Aug 2019 03:00:24 -0700 X-Received: by mail-wr1-f67.google.com with SMTP id b16so980411wrq.9 for ; Fri, 16 Aug 2019 03:00:24 -0700 (PDT) X-Gm-Message-State: APjAAAVxzEPU7VykfQT4KO6z0a36aAs6z7VIgpkNZ3nez07vvbmGg4qH Ebom2rvMiFdewhFJE9I1wodEEuBZMEk= X-Google-Smtp-Source: APXvYqx6Za5ioSrsIUhkbksCw0nv20hrAvL+7jRvITgjq+Fd4VqpepK5m1Y/adHK5UXEmeWnNOJvxA== X-Received: by 2002:adf:ff84:: with SMTP id j4mr9373853wrr.71.1565949622775; Fri, 16 Aug 2019 03:00:22 -0700 (PDT) X-Received: from localhost.localdomain ([84.203.61.230]) by smtp.gmail.com with ESMTPSA id j16sm4750851wrp.62.2019.08.16.03.00.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Aug 2019 03:00:22 -0700 (PDT) From: "Pete Batard" To: devel@edk2.groups.io Cc: ard.biesheuvel@linaro.org, leif.lindholm@linaro.org Subject: [edk2-devel] [edk2-platforms: PATCH v2 1/2] Platforms/RPi3: Improve debug output in FdtDxe Date: Fri, 16 Aug 2019 11:00:08 +0100 Message-Id: <20190816100009.3360-2-pete@akeo.ie> In-Reply-To: <20190816100009.3360-1-pete@akeo.ie> References: <20190816100009.3360-1-pete@akeo.ie> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pete@akeo.ie Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1565949625; bh=EjWuXU2ZDl4aqwcWPQBBtZ5abUoII3cxYUbKZkkc5dk=; h=Cc:Date:From:Reply-To:Subject:To; b=bd6WPQ1t7moi9D1ACz2hhSm/FhfC9gBjBisPY9I3yT2tJXv0QX1uNVzDx8EmRR86Kwy kzQ+twVK6ooxD9iXDWgpkkr7lplsjE5nu+QpGh1o62N8Oo11O/r3mwyMN/Fs98zBVbA2Q id1jl0ZtDZdgEPOFl6XCrwhHP9a1S6StCgs= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Harmonize messages, avoid acronyms and provide human readable status codes. Signed-off-by: Pete Batard --- Platform/RaspberryPi/RPi3/Drivers/FdtDxe/FdtDxe.c | 24 ++++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/Platform/RaspberryPi/RPi3/Drivers/FdtDxe/FdtDxe.c b/Platform/R= aspberryPi/RPi3/Drivers/FdtDxe/FdtDxe.c index c84e5b2767e2..da99ef9535c8 100644 --- a/Platform/RaspberryPi/RPi3/Drivers/FdtDxe/FdtDxe.c +++ b/Platform/RaspberryPi/RPi3/Drivers/FdtDxe/FdtDxe.c @@ -383,12 +383,12 @@ FdtDxeInitialize ( * Have FDT passed via config.txt. */ FdtSize =3D fdt_totalsize (FdtImage); - DEBUG ((DEBUG_INFO, "DTB passed via config.txt of 0x%lx bytes\n", FdtS= ize)); + DEBUG ((DEBUG_INFO, "Device Tree passed via config.txt (0x%lx bytes)\n= ", FdtSize)); Status =3D EFI_SUCCESS; } else { Internal =3D TRUE; - DEBUG ((DEBUG_INFO, "No/bad FDT at %p (%a), trying internal DTB...\n", - FdtImage, fdt_strerror (Retval))); + DEBUG ((DEBUG_INFO, "No/Bad Device Tree found at address 0x%p (%a), " + "trying internal one...\n", FdtImage, fdt_strerror (Retval))); Status =3D GetSectionFromAnyFv (&gRaspberryPiFdtFileGuid, EFI_SECTION_= RAW, 0, &FdtImage, &FdtSize); if (Status =3D=3D EFI_SUCCESS) { @@ -399,7 +399,7 @@ FdtDxeInitialize ( } =20 if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "Failed to locate device tree: %r\n", Status)); + DEBUG ((DEBUG_ERROR, "Failed to locate Device Tree: %r\n", Status)); return Status; } =20 @@ -410,7 +410,7 @@ FdtDxeInitialize ( Status =3D gBS->AllocatePages (AllocateAnyPages, EfiBootServicesData, EFI_SIZE_TO_PAGES (FdtSize), (EFI_PHYSICAL_ADDRESS*)&mFd= tImage); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "Failed to allocate new device tree: %r\n", Statu= s)); + DEBUG ((DEBUG_ERROR, "Failed to allocate Device Tree: %r\n", Status)); return Status; } =20 @@ -419,27 +419,27 @@ FdtDxeInitialize ( =20 Status =3D SanitizePSCI (); if (EFI_ERROR (Status)) { - Print (L"Failed to sanitize PSCI (error %d)\n", Status); + Print (L"Failed to sanitize PSCI: %r\n", Status); } =20 Status =3D CleanMemoryNodes (); if (EFI_ERROR (Status)) { - Print (L"Failed to clean memory nodes (error %d)\n", Status); + Print (L"Failed to clean memory nodes: %r\n", Status); } =20 Status =3D CleanSimpleFramebuffer (); if (EFI_ERROR (Status)) { - Print (L"Failed to clean frame buffer (error %d)\n", Status); + Print (L"Failed to clean frame buffer: %r\n", Status); } =20 Status =3D FixEthernetAliases (); if (EFI_ERROR (Status)) { - Print (L"Failed to fix ethernet aliases (error %d)\n", Status); + Print (L"Failed to fix ethernet aliases: %r\n", Status); } =20 Status =3D UpdateMacAddress (); if (EFI_ERROR (Status)) { - Print (L"Failed to update MAC address (error %d)\n", Status); + Print (L"Failed to update MAC address: %r\n", Status); } =20 if (Internal) { @@ -448,11 +448,11 @@ FdtDxeInitialize ( */ Status =3D UpdateBootArgs (); if (EFI_ERROR (Status)) { - Print (L"Failed to update boot arguments (error %d)\n", Status); + Print (L"Failed to update boot arguments: %r\n", Status); } } =20 - DEBUG ((DEBUG_INFO, "Installed FDT is at %p\n", mFdtImage)); + DEBUG ((DEBUG_INFO, "Installed Device Tree at address 0x%p\n", mFdtImage= )); Status =3D gBS->InstallConfigurationTable (&gFdtTableGuid, mFdtImage); ASSERT_EFI_ERROR (Status); =20 --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45814): https://edk2.groups.io/g/devel/message/45814 Mute This Topic: https://groups.io/mt/32896986/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-