From nobody Thu Nov 14 17:13:21 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+45559+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1565697511; cv=none; d=zoho.com; s=zohoarc; b=L4dDgcRfKDQuyKUBYtswWsG59yG1tIRHi32gsTTtmEh3kFL1pTf2Ry06XvTE+BaVNAWb185d9U86RDceP0g9tblhJ5V6w8W5Bxd3QRjOKDXgdQXHhl0cU1MLVScbAFwkp2l3JV3ANuYR+709JCtHrLVC5ZaRPmqnIa3AtgciQ/E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1565697511; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=Fw7Hht832n5AWPNBcVeup+JiRV5nM/Lco1VwYc0MsuQ=; b=lL3eE2hZIMkPtcwS9g2UX+iG227FaPba/XIzVEk8Qo67H/1nnavtsZ5i8OImvPtj32JIDzT1vkvEP053sTMWC/n2azBxyeRP8Rpg74V2RYpAWhxfY8woR8v2thvoSZ42ri4sw8nOXr66uClc3/oWJLVXyIRnq83qi8QlDFwTG+I= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+45559+1787277+3901457@groups.io Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1565697511060543.4951175734062; Tue, 13 Aug 2019 04:58:31 -0700 (PDT) Return-Path: X-Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by groups.io with SMTP; Tue, 13 Aug 2019 04:58:30 -0700 Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+45559+1787277+3901457@groups.io; helo=web01.groups.io; Received-SPF: None (esa1.hc3370-68.iphmx.com: no sender authenticity information available from domain of anthony.perard@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa1.hc3370-68.iphmx.com: domain of anthony.perard@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa1.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: keGfDCmOa8D92M74fhwRqEgvCzuMVfRT0xWYqnhV9WGp9g7eFMNchreSWvwZKJO6AOQAjH3XPG aiTIcWzw55cdmAOb3ju+nK3AY0PHBbMamqPG0uz883u0JETHOYCkM/RwwoXQkvhartsNLEMJbs rF66WepkwKBdcnh5JexObm2X2XkyZWr+Q98yjsrFRL+VuhUBLd0h4nvYaVxGExv9uqlde3ht5P JHgCt3gdxWXqGRFIhmPdyv0HiojCZ6CPloVw2OEi5tmnjr2NUorvONtA1IXME8G2fNaltNbE4m a+k= X-SBRS: 2.7 X-MesageID: 4242263 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.64,381,1559534400"; d="scan'208";a="4242263" From: "Anthony PERARD" To: CC: Laszlo Ersek , Jordan Justen , Julien Grall , , Ard Biesheuvel , Anthony PERARD Subject: [edk2-devel] [PATCH v5 28/35] OvmfPkg/PlatformBootManagerLib: Handle the absence of PCI bus on Xen PVH Date: Tue, 13 Aug 2019 12:31:12 +0100 Message-ID: <20190813113119.14804-29-anthony.perard@citrix.com> In-Reply-To: <20190813113119.14804-1-anthony.perard@citrix.com> References: <20190813113119.14804-1-anthony.perard@citrix.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,anthony.perard@citrix.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1565697510; bh=Fw7Hht832n5AWPNBcVeup+JiRV5nM/Lco1VwYc0MsuQ=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=FFoIgp2KU+2CFPQimuPE5gcnL5o1mtKGI8woNGDoKVg+vOoZ+C9YpQlkVOp8UHFCUP2 +D4VWcuxnJTtMqOwCXUT5sQCWbJ+1euXXBxmvSDc1Xu2moUMkjW/BZiqocwLLeFLQOwLx Tsa4MEd16jFi/vNDr2abyitQnY5ZZR8rTaQ= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" When running in a Xen PVH guest, there's nothing to do in PciAcpiInitialization() because there isn't any PCI bus. When the Host Bridge DID isn't recognised, simply continue. (The value of PcdOvmfHostBridgePciDevId would be 0 because it isn't set.) Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1689 Signed-off-by: Anthony PERARD Reviewed-by: Laszlo Ersek --- Notes: v3: - Instead of checking for a false value, XEN_PVH_PCI_HOST_BRIDGE_DEVICE_ID, simply check if we are running xen when the HostBridge device ID isn't recognised. OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c b/OvmfPkg= /Library/PlatformBootManagerLib/BdsPlatform.c index d5d5d20fd8..1eba304f09 100644 --- a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c +++ b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c @@ -1208,6 +1208,12 @@ PciAcpiInitialization ( PciWrite8 (PCI_LIB_ADDRESS (0, 0x1f, 0, 0x6b), 0x0b); // H break; default: + if (XenDetected ()) { + // + // There is no PCI bus in this case. + // + return; + } DEBUG ((EFI_D_ERROR, "%a: Unknown Host Bridge Device ID: 0x%04x\n", __FUNCTION__, mHostBridgeDevId)); ASSERT (FALSE); --=20 Anthony PERARD -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45559): https://edk2.groups.io/g/devel/message/45559 Mute This Topic: https://groups.io/mt/32851707/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-