From nobody Fri Apr 19 23:53:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+45524+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+45524+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1565693635; cv=none; d=zoho.com; s=zohoarc; b=j5rP0toFy032yjth2uo0hmXzIt2f/Ki9c7fMgetuJgvB7yqOb9kmBWJHEXw4h6r3BKaKshpei9StpXKJ4PIzr4UdaLUEMlpb+4hEV4mhQixCjHil8Rtjdw8lZe8I3sbo2Iwd64NNT42LBh78isdhM2lbALvjZI1UNnI55hvJz9A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1565693635; h=Cc:Date:From:List-Id:List-Unsubscribe:Message-ID:Reply-To:Sender:Subject:To:ARC-Authentication-Results; bh=IukiZIFcXBfuJjxXcN/PnfuthxwBWbGpRwqDpj0omxo=; b=AVjOfxWjN2HC8ioMWnOd9RlYA868G6KZIH77W+Re3VksUE+LkQu3DuFwqIuVHVeTI0NDCT41ov/sHyg7WLkfq+efzOh6KhfB6peCwLO4bR0pQ4C/VZr7fe1KtAZKypnnmVl7S5S0EdYr2xnsdUnz6M1/BtK/DhNfKg+IuRZHC5I= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+45524+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1565693635943994.1570383517656; Tue, 13 Aug 2019 03:53:55 -0700 (PDT) Return-Path: X-Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by groups.io with SMTP; Tue, 13 Aug 2019 03:53:55 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Aug 2019 03:53:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,381,1559545200"; d="scan'208";a="351501839" X-Received: from shwdeopenpsi174.ccr.corp.intel.com ([10.239.157.39]) by orsmga005.jf.intel.com with ESMTP; 13 Aug 2019 03:53:53 -0700 From: "Xu, Wei6" To: devel@edk2.groups.io Cc: Hao A Wu , Liming Gao Subject: [edk2-devel][Patch] MdeModulePkg/DxeCapsuleLibFmp: Improve comparisons in CapsuleOnDisk.c Date: Tue, 13 Aug 2019 18:53:49 +0800 Message-Id: <20190813105349.7312-1-wei6.xu@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,wei6.xu@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1565693635; bh=QnOmWith4XlGw2LL+ZNNWbnM1qNssV8sQwglBhn24VA=; h=Cc:Date:From:Reply-To:Subject:To; b=rmL245MgE38exJFkw9+RCfvF1Oo4u1q5tQZKIP90caRfIP5U6+8vXaSI15MW/o/TiRm kmNgIhV4ZCtq7MCopW+iKqgITcKFG8d86PmqU4j+DLIHqvnfmb1HlPhVkQvKofuLpcen4 oR2nfo91XFKcCVwMRxm94NHYtjVYS3xTvfo= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2028 Non-Boolean comparisons should use a compare operator (=3D=3D, !=3D, >, < >=3D, <=3D). Cc: Hao A Wu Cc: Liming Gao Signed-off-by: Wei6 Xu Reviewed-by: Hao A Wu Reviewed-by: Liming Gao --- MdeModulePkg/Library/DxeCapsuleLibFmp/CapsuleOnDisk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Library/DxeCapsuleLibFmp/CapsuleOnDisk.c b/MdeMod= ulePkg/Library/DxeCapsuleLibFmp/CapsuleOnDisk.c index 3193ca8f4d..4c32c6cdcf 100644 --- a/MdeModulePkg/Library/DxeCapsuleLibFmp/CapsuleOnDisk.c +++ b/MdeModulePkg/Library/DxeCapsuleLibFmp/CapsuleOnDisk.c @@ -125,11 +125,11 @@ UpperCaseString ( IN CHAR16 *Str ) { CHAR16 *Cptr; =20 - for (Cptr =3D Str; *Cptr; Cptr++) { + for (Cptr =3D Str; *Cptr !=3D L'\0'; Cptr++) { if (L'a' <=3D *Cptr && *Cptr <=3D L'z') { *Cptr =3D *Cptr - L'a' + L'A'; } } =20 --=20 2.16.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45524): https://edk2.groups.io/g/devel/message/45524 Mute This Topic: https://groups.io/mt/32851277/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-