From nobody Sun Feb 8 16:28:54 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+45523+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+45523+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1565693610; cv=none; d=zoho.com; s=zohoarc; b=kFMcOkOuoF5aD7+9TNqygkxMuYchvGO6caa+kxDqYK5lCsNoqRY58jrwfjynN8FvIA1m/T/GeOy3DigreAfKOO8EG16vsPqgEyJcSZagI8mLyBGQxSMAOKe+cVuAnxWXuhkV93sKiziHgve+m6+6zuY8bByUPvm2ZXfhU53TPd4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1565693610; h=Cc:Date:From:List-Id:List-Unsubscribe:Message-ID:Reply-To:Sender:Subject:To:ARC-Authentication-Results; bh=FS2zfsdBCArME2zwmbw2ovmq+LlLRK/rb41aneK0ZoQ=; b=ol9NWgz7UE0NR4uCuS4PaQ4h+pKcMiEzS0KIZDkT2pluWHb55QSqnvJ/lva9Rfm0gAonpuoMQnFU1Klo3fWqeS5RCVz/lIvMcRs+5RxjxbMmsdJqDaylPaWcEhop5gvJpwIiIRMzPKn/2gYkzc8Q9QjQBIcX2BDZHSCYtLmISX0= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+45523+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1565693610915636.0065076447939; Tue, 13 Aug 2019 03:53:30 -0700 (PDT) Return-Path: X-Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by groups.io with SMTP; Tue, 13 Aug 2019 03:53:30 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Aug 2019 03:53:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,381,1559545200"; d="scan'208";a="351501769" X-Received: from shwdeopenpsi174.ccr.corp.intel.com ([10.239.157.39]) by orsmga005.jf.intel.com with ESMTP; 13 Aug 2019 03:53:28 -0700 From: "Xu, Wei6" To: devel@edk2.groups.io Cc: Hao A Wu , Liming Gao Subject: [edk2-devel][Patch] MdeModulePkg/CapsuleApp: Improve comparisons in CapsuleOnDisk.c Date: Tue, 13 Aug 2019 18:53:17 +0800 Message-Id: <20190813105317.2820-1-wei6.xu@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,wei6.xu@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1565693610; bh=OpPL7vkrQhuFwM3jy9XtkXYeI8SR9/Eh3lsi/2mgxYQ=; h=Cc:Date:From:Reply-To:Subject:To; b=tGCHuNBQ8OFxkQ4GQ3ffBTlwsFm1EpGLwnRwm1CF8FfSGi39EkXCWgdO5tCScUSX6FW ecKYDpBps7flGPYIq0QqMzxwFvGN2jBNg0zacUDfpSF0IcDkqWS2zrCDtfntI0IxKMnu6 KY36UEBdv5nMaLzvOAdcICHYUxOzkbRHPus= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2028 Non-Boolean comparisons should use a compare operator (=3D=3D, !=3D, >, < >=3D, <=3D). Cc: Hao A Wu Cc: Liming Gao Signed-off-by: Wei6 Xu Reviewed-by: Hao A Wu Reviewed-by: Liming Gao --- MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c b/MdeModul= ePkg/Application/CapsuleApp/CapsuleOnDisk.c index 382efa9aa0..b161d1a981 100644 --- a/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c +++ b/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c @@ -742,11 +742,11 @@ IsCapsuleOnDiskSupported ( ); if (EFI_ERROR (Status)) { return FALSE; } =20 - if (OsIndicationsSupported & EFI_OS_INDICATIONS_FILE_CAPSULE_DELIVERY_SU= PPORTED) { + if ((OsIndicationsSupported & EFI_OS_INDICATIONS_FILE_CAPSULE_DELIVERY_S= UPPORTED) !=3D 0) { return TRUE; } =20 return FALSE; } --=20 2.16.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45523): https://edk2.groups.io/g/devel/message/45523 Mute This Topic: https://groups.io/mt/32851273/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-