[edk2-devel] [Patch V3 0/4] EmulatorPkg: Fix VS20xx IA32 boot and simplify build config

Michael D Kinney posted 4 patches 1 week ago
Failed in applying to current master (apply log)
EmulatorPkg/EmuBusDriverDxe/EmuBusDriverDxe.c |   9 +-
EmulatorPkg/EmulatorPkg.dec                   |   4 +-
EmulatorPkg/EmulatorPkg.dsc                   |  34 ++---
EmulatorPkg/FlashMapPei/FlashMapPei.c         |   8 +-
EmulatorPkg/Library/SmbiosLib/SmbiosLib.c     |   4 +-
.../ThunkProtocolList/ThunkProtocolList.c     |  11 +-
EmulatorPkg/Readme.md                         |   8 +-
EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c  |  10 +-
EmulatorPkg/Unix/Host/PosixFileSystem.c       |  80 ++++++++----
EmulatorPkg/Unix/Host/X11GraphicsWindow.c     |   4 +-
EmulatorPkg/Win/Host/WinFileSystem.c          | 116 ++++++++++++------
EmulatorPkg/Win/VS2017/BuildVS.bat            |   2 +-
EmulatorPkg/build.sh                          |   8 +-
13 files changed, 197 insertions(+), 101 deletions(-)

[edk2-devel] [Patch V3 0/4] EmulatorPkg: Fix VS20xx IA32 boot and simplify build config

Posted by Michael D Kinney 1 week ago
New in V3
==========
* Fix size value used in call to AsciiStrCpyS() in PosixFileSystem.c
* Fix XCODE5 safe string function build failure in BerkleyPacketFilter.c
* Add NOOPT build target to DSC file.

New in V2
=========
* Fix size values in safe string function calls.
* Update POSIX sources to use AsciiStrCpyS() and AsciiStrCatS().
* Verify that no exceptions occur if EMU_MAGIC_PAGE() can not be mapped.  An
  error message is generated and the host app exits normally.
* Update EmulatorPkg DEC file with a new PcdPeiServicesTablePage default value
  that works for Windows/POSIX hosts for both IA32 and X64.

https://bugzilla.tianocore.org/show_bug.cgi?id=162
https://bugzilla.tianocore.org/show_bug.cgi?id=2055
https://bugzilla.tianocore.org/show_bug.cgi?id=2056

* Fix VS20xx IA32 boot failure
* Remove UNIX_SEC_BUILD/WIN_SEC_BUILD
* Add -D DISABLE_NEW_DEPRECATED_INTERFACES

Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>

Michael D Kinney (4):
  EmulatorPkg: Fix VS20xx IA32 boot failure
  EmulatorPkg: Remove UNIX_SEC_BUILD/WIN_SEC_BUILD
  EmulatorPkg: Add -D DISABLE_NEW_DEPRECATED_INTERFACES
  EmulatorPkg: Add support for NOOPT target

 EmulatorPkg/EmuBusDriverDxe/EmuBusDriverDxe.c |   9 +-
 EmulatorPkg/EmulatorPkg.dec                   |   4 +-
 EmulatorPkg/EmulatorPkg.dsc                   |  34 ++---
 EmulatorPkg/FlashMapPei/FlashMapPei.c         |   8 +-
 EmulatorPkg/Library/SmbiosLib/SmbiosLib.c     |   4 +-
 .../ThunkProtocolList/ThunkProtocolList.c     |  11 +-
 EmulatorPkg/Readme.md                         |   8 +-
 EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c  |  10 +-
 EmulatorPkg/Unix/Host/PosixFileSystem.c       |  80 ++++++++----
 EmulatorPkg/Unix/Host/X11GraphicsWindow.c     |   4 +-
 EmulatorPkg/Win/Host/WinFileSystem.c          | 116 ++++++++++++------
 EmulatorPkg/Win/VS2017/BuildVS.bat            |   2 +-
 EmulatorPkg/build.sh                          |   8 +-
 13 files changed, 197 insertions(+), 101 deletions(-)

-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#45297): https://edk2.groups.io/g/devel/message/45297
Mute This Topic: https://groups.io/mt/32816073/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch V3 0/4] EmulatorPkg: Fix VS20xx IA32 boot and simplify build config

Posted by Jordan Justen 1 week ago
On 2019-08-09 15:44:01, Michael D Kinney wrote:
> New in V3
> ==========
> * Fix size value used in call to AsciiStrCpyS() in PosixFileSystem.c
> * Fix XCODE5 safe string function build failure in BerkleyPacketFilter.c
> * Add NOOPT build target to DSC file.
> 
> New in V2
> =========
> * Fix size values in safe string function calls.
> * Update POSIX sources to use AsciiStrCpyS() and AsciiStrCatS().
> * Verify that no exceptions occur if EMU_MAGIC_PAGE() can not be mapped.  An
>   error message is generated and the host app exits normally.
> * Update EmulatorPkg DEC file with a new PcdPeiServicesTablePage default value
>   that works for Windows/POSIX hosts for both IA32 and X64.
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=162
> https://bugzilla.tianocore.org/show_bug.cgi?id=2055
> https://bugzilla.tianocore.org/show_bug.cgi?id=2056
> 
> * Fix VS20xx IA32 boot failure
> * Remove UNIX_SEC_BUILD/WIN_SEC_BUILD
> * Add -D DISABLE_NEW_DEPRECATED_INTERFACES
> 
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> 
> Michael D Kinney (4):
>   EmulatorPkg: Fix VS20xx IA32 boot failure

Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>

>   EmulatorPkg: Remove UNIX_SEC_BUILD/WIN_SEC_BUILD

Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>

>   EmulatorPkg: Add -D DISABLE_NEW_DEPRECATED_INTERFACES

Acked-by: Jordan Justen <jordan.l.justen@intel.com>

>   EmulatorPkg: Add support for NOOPT target

Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>

Were you able to test this still boots on Linux?

-Jordan

> 
>  EmulatorPkg/EmuBusDriverDxe/EmuBusDriverDxe.c |   9 +-
>  EmulatorPkg/EmulatorPkg.dec                   |   4 +-
>  EmulatorPkg/EmulatorPkg.dsc                   |  34 ++---
>  EmulatorPkg/FlashMapPei/FlashMapPei.c         |   8 +-
>  EmulatorPkg/Library/SmbiosLib/SmbiosLib.c     |   4 +-
>  .../ThunkProtocolList/ThunkProtocolList.c     |  11 +-
>  EmulatorPkg/Readme.md                         |   8 +-
>  EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c  |  10 +-
>  EmulatorPkg/Unix/Host/PosixFileSystem.c       |  80 ++++++++----
>  EmulatorPkg/Unix/Host/X11GraphicsWindow.c     |   4 +-
>  EmulatorPkg/Win/Host/WinFileSystem.c          | 116 ++++++++++++------
>  EmulatorPkg/Win/VS2017/BuildVS.bat            |   2 +-
>  EmulatorPkg/build.sh                          |   8 +-
>  13 files changed, 197 insertions(+), 101 deletions(-)
> 
> -- 
> 2.21.0.windows.1
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#45310): https://edk2.groups.io/g/devel/message/45310
Mute This Topic: https://groups.io/mt/32816073/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch V3 0/4] EmulatorPkg: Fix VS20xx IA32 boot and simplify build config

Posted by Michael D Kinney 1 week ago
Yes.  I was able to test Linux boots.  I32 and X64.

Mike

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io]
> On Behalf Of Jordan Justen
> Sent: Friday, August 9, 2019 4:08 PM
> To: Kinney, Michael D <michael.d.kinney@intel.com>;
> devel@edk2.groups.io
> Cc: Andrew Fish <afish@apple.com>; Ni, Ray
> <ray.ni@intel.com>
> Subject: Re: [edk2-devel] [Patch V3 0/4] EmulatorPkg:
> Fix VS20xx IA32 boot and simplify build config
> 
> On 2019-08-09 15:44:01, Michael D Kinney wrote:
> > New in V3
> > ==========
> > * Fix size value used in call to AsciiStrCpyS() in
> PosixFileSystem.c
> > * Fix XCODE5 safe string function build failure in
> BerkleyPacketFilter.c
> > * Add NOOPT build target to DSC file.
> >
> > New in V2
> > =========
> > * Fix size values in safe string function calls.
> > * Update POSIX sources to use AsciiStrCpyS() and
> AsciiStrCatS().
> > * Verify that no exceptions occur if EMU_MAGIC_PAGE()
> can not be mapped.  An
> >   error message is generated and the host app exits
> normally.
> > * Update EmulatorPkg DEC file with a new
> PcdPeiServicesTablePage default value
> >   that works for Windows/POSIX hosts for both IA32 and
> X64.
> >
> > https://bugzilla.tianocore.org/show_bug.cgi?id=162
> > https://bugzilla.tianocore.org/show_bug.cgi?id=2055
> > https://bugzilla.tianocore.org/show_bug.cgi?id=2056
> >
> > * Fix VS20xx IA32 boot failure
> > * Remove UNIX_SEC_BUILD/WIN_SEC_BUILD
> > * Add -D DISABLE_NEW_DEPRECATED_INTERFACES
> >
> > Cc: Jordan Justen <jordan.l.justen@intel.com>
> > Cc: Andrew Fish <afish@apple.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Signed-off-by: Michael D Kinney
> <michael.d.kinney@intel.com>
> >
> > Michael D Kinney (4):
> >   EmulatorPkg: Fix VS20xx IA32 boot failure
> 
> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
> 
> >   EmulatorPkg: Remove UNIX_SEC_BUILD/WIN_SEC_BUILD
> 
> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
> 
> >   EmulatorPkg: Add -D
> DISABLE_NEW_DEPRECATED_INTERFACES
> 
> Acked-by: Jordan Justen <jordan.l.justen@intel.com>
> 
> >   EmulatorPkg: Add support for NOOPT target
> 
> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
> 
> Were you able to test this still boots on Linux?
> 
> -Jordan
> 
> >
> >  EmulatorPkg/EmuBusDriverDxe/EmuBusDriverDxe.c |   9
> +-
> >  EmulatorPkg/EmulatorPkg.dec                   |   4
> +-
> >  EmulatorPkg/EmulatorPkg.dsc                   |  34
> ++---
> >  EmulatorPkg/FlashMapPei/FlashMapPei.c         |   8
> +-
> >  EmulatorPkg/Library/SmbiosLib/SmbiosLib.c     |   4
> +-
> >  .../ThunkProtocolList/ThunkProtocolList.c     |  11
> +-
> >  EmulatorPkg/Readme.md                         |   8
> +-
> >  EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c  |  10
> +-
> >  EmulatorPkg/Unix/Host/PosixFileSystem.c       |  80
> ++++++++----
> >  EmulatorPkg/Unix/Host/X11GraphicsWindow.c     |   4
> +-
> >  EmulatorPkg/Win/Host/WinFileSystem.c          | 116
> ++++++++++++------
> >  EmulatorPkg/Win/VS2017/BuildVS.bat            |   2
> +-
> >  EmulatorPkg/build.sh                          |   8
> +-
> >  13 files changed, 197 insertions(+), 101 deletions(-)
> >
> > --
> > 2.21.0.windows.1
> >
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#45316): https://edk2.groups.io/g/devel/message/45316
Mute This Topic: https://groups.io/mt/32816073/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-