From nobody Sun May 5 13:52:40 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+45180+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+45180+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1565270686; cv=none; d=zoho.com; s=zohoarc; b=Spz3pZJd66S/3qGxMl9lh/XyC0pF2fyTBrHZWyq9ZgZ01QeJf7wedjr1hGHfe/SgYbYbsPqSpB7fxpkBVl/c1QkuiH/CdDbmucol+rV+iFxhPplgF/inicS2dSHMpeoocSKChVQqr5yh7d9GAu6yOcgxi8+HxSU7yGlubR3FFfQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1565270686; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=YPP8zSf+VrzK2nd7sLy1E8b7Qub8xxGK65TVR928SSc=; b=YekScfFpZ8O/HR1/afEr22n+RZmA7khVFMxO+DQkTJno2d/nuXBKb7qU6RHX0LmiYFYm3FHyjDnrvz3UxS2lOFQjqRmvCXEqELnJOgEw6l7S/dloPu5X8kgBvWMQyC5KdWfkvBByDtPfrZ1Rm3Y1ahHSQqjxGrow48meHkkee80= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+45180+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1565270686799945.224667290829; Thu, 8 Aug 2019 06:24:46 -0700 (PDT) Return-Path: X-Received: from mga18.intel.com (mga18.intel.com []) by groups.io with SMTP; Thu, 08 Aug 2019 06:24:45 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Aug 2019 06:24:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,361,1559545200"; d="scan'208";a="174845839" X-Received: from ydong10-win10.ccr.corp.intel.com ([10.239.158.133]) by fmsmga008.fm.intel.com with ESMTP; 08 Aug 2019 06:24:44 -0700 From: "Dong, Eric" To: devel@edk2.groups.io Cc: Ray Ni , Laszlo Ersek Subject: [edk2-devel] [Patch 1/2] UefiCpuPkg/RegisterCpuFeaturesLib: Clean up useless parameter. Date: Thu, 8 Aug 2019 21:24:41 +0800 Message-Id: <20190808132442.33936-2-eric.dong@intel.com> In-Reply-To: <20190808132442.33936-1-eric.dong@intel.com> References: <20190808132442.33936-1-eric.dong@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,eric.dong@intel.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1565270686; bh=RILybXDUjZvcMsjymhTJu9D51wkXwxvskaW1+i9ExpA=; h=Cc:Date:From:Reply-To:Subject:To; b=D27SVGD1nNvZ0twOap12MuoQXuqOHunDe5QzntPagmZ6jaESWedd42MhctbDvYXKb+I 47Lo81wexPQlBspNqN3xoPZkpWp7FzT9PdT/mwmFlHMV/neyORe+VPHBBfPo/4q8/GD8T JOwGn1lIEJkE3HCbSw+xpK0M+luPjO64EnU= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2060 Remove the useless parameter. Signed-off-by: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Reviewed-by: Laszlo Ersek --- UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h | 1 - .../Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c | 1 - 2 files changed, 2 deletions(-) diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.= h b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h index a25dd69292..7c48b0a645 100644 --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h @@ -58,7 +58,6 @@ typedef struct { // Flags used when program the register. // typedef struct { - volatile UINTN ConsoleLogLock; // Spinlock used to co= ntrol console. volatile UINTN MemoryMappedLock; // Spinlock used to pr= ogram mmio volatile UINT32 *CoreSemaphoreCount; // Semaphore container= s used to program Core semaphore. volatile UINT32 *PackageSemaphoreCount; // Semaphore container= s used to program Package semaphore. diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesL= ib.c b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c index 493566de5d..67885bf69b 100644 --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c @@ -839,7 +839,6 @@ RegisterCpuFeature ( if (CpuFeaturesData->FeaturesCount =3D=3D 0) { InitializeListHead (&CpuFeaturesData->FeatureList); InitializeSpinLock (&CpuFeaturesData->CpuFlags.MemoryMappedLock); - InitializeSpinLock (&CpuFeaturesData->CpuFlags.ConsoleLogLock); // // Code assumes below three PCDs have PCD same buffer size. // --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45180): https://edk2.groups.io/g/devel/message/45180 Mute This Topic: https://groups.io/mt/32798207/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 5 13:52:40 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+45181+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+45181+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1565270686; cv=none; d=zoho.com; s=zohoarc; b=S7MKvjFE5mS+9Va4iUb/4y+I00SBxT/cKQWu24YtlkLEt96V3aVdnV2hqUESf1DWTddthpfIQSbapL6UQpUY5+hg9acZyJRe7gPbmhi4eLK6CMNAn0vafE7aUPQHgRb+VoWUOj6Ej4yCMvHp6cCffx3PBe/Gz9COdvo7/La8taA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1565270686; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=2WqBYkZPxbdWpD237iGqnoQqMI9s7Ea2+3mt5UHYUfY=; b=LaYxmIroBoLskP5dImbEMRH6zwURkUu/riOy2Gw9bn/4+I8LPs7wSKLArrgGtt71n7eHybjMXx5l6Sg0eitZrlI/YLGfYFNNzlEu0gg0PqrD8Egaltd3m5fKniRpmpi2wnq4FyxrK6uNTze/Hb6V+z6cmormnmOhvk2b1NC7kpU= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+45181+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1565270686898164.16804135632947; Thu, 8 Aug 2019 06:24:46 -0700 (PDT) Return-Path: X-Received: from mga18.intel.com (mga18.intel.com []) by groups.io with SMTP; Thu, 08 Aug 2019 06:24:46 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Aug 2019 06:24:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,361,1559545200"; d="scan'208";a="174845843" X-Received: from ydong10-win10.ccr.corp.intel.com ([10.239.158.133]) by fmsmga008.fm.intel.com with ESMTP; 08 Aug 2019 06:24:45 -0700 From: "Dong, Eric" To: devel@edk2.groups.io Cc: Ray Ni , Laszlo Ersek Subject: [edk2-devel] [Patch 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Clean up useless parameter. Date: Thu, 8 Aug 2019 21:24:42 +0800 Message-Id: <20190808132442.33936-3-eric.dong@intel.com> In-Reply-To: <20190808132442.33936-1-eric.dong@intel.com> References: <20190808132442.33936-1-eric.dong@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,eric.dong@intel.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1565270686; bh=JRQhk8tY9wVwI1S+EZPDpVDXB82m2Tpl+syE3sTLBmw=; h=Cc:Date:From:Reply-To:Subject:To; b=O9ajssEGlkSVTI0loCo/HP2YVpamc6V72xCWhYkVTGc+REV3v0T/Dh39uIfBFDoomHN pfdMhiJ0To1h2M0GneB9wUWZir4BAmk06cP1qjWG9aTBoU6B+Vdpdu4/3/gjNWzzpImBw /u8X5BmoffYrwA3uYH5Uhd6zxx7Vg6sKkls= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2060 Remove the useless parameter. Signed-off-by: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Reviewed-by: Laszlo Ersek --- UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c b/UefiCpuPkg/PiSmmCpuDxeSmm/= CpuS3.c index d20bc4aae6..d8c6b19ead 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c @@ -35,7 +35,6 @@ typedef struct { // Flags used when program the register. // typedef struct { - volatile UINTN ConsoleLogLock; // Spinlock used to co= ntrol console. volatile UINTN MemoryMappedLock; // Spinlock used to pr= ogram mmio volatile UINT32 *CoreSemaphoreCount; // Semaphore container= used to program // core level semaphor= e. @@ -1028,7 +1027,6 @@ GetAcpiCpuData ( ASSERT (mCpuFlags.PackageSemaphoreCount !=3D NULL); } InitializeSpinLock((SPIN_LOCK*) &mCpuFlags.MemoryMappedLock); - InitializeSpinLock((SPIN_LOCK*) &mCpuFlags.ConsoleLogLock); } =20 /** --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45181): https://edk2.groups.io/g/devel/message/45181 Mute This Topic: https://groups.io/mt/32798208/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-