From nobody Fri May 3 14:25:08 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+45148+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+45148+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1565250893; cv=none; d=zoho.com; s=zohoarc; b=InXfLfU57LjORD5lvokjPUCweexXcq3VQrw4xQVh5ZTrLhKAmasFYu6RtPmsmb9Pyw5LARhf010LXi3OzzuljENFFnLIMjxU7StrNgSdOm0ZrGj/MaJgnwl3Q01iauMnr4U1WAxaEHjP7pKuzA9fMf3H9Uc/1Gor9drX+ZyETsk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1565250893; h=Cc:Date:From:List-Id:List-Unsubscribe:Message-ID:Reply-To:Sender:Subject:To:ARC-Authentication-Results; bh=VGXMFFnm8ZNkWZcbHFQ5kuF8FbsDf5ax0Nn37Bk0Tko=; b=FduLQqWAlfRYBDmE46nZ5GX9/633RM3VFa/Gd1VYMqN8tt4WQgTt4K9TNwJzN7rPrB58qoI3xSribfxMog2jMgHc06NmOQcQjdypv12I7BGsT5Uog7rrhQORfksbyAQTBIvxfYMzfxQQtQGzX4JnntSBLjr+7oEKqHWCBJ/Y1yw= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+45148+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1565250893100468.1230612544474; Thu, 8 Aug 2019 00:54:53 -0700 (PDT) Return-Path: X-Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by groups.io with SMTP; Thu, 08 Aug 2019 00:54:52 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Aug 2019 00:54:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,360,1559545200"; d="scan'208";a="186271471" X-Received: from shenglei-dev.ccr.corp.intel.com ([10.239.158.52]) by orsmga002.jf.intel.com with ESMTP; 08 Aug 2019 00:54:50 -0700 From: "Zhang, Shenglei" To: devel@edk2.groups.io Cc: Eric Dong , Ray Ni , Laszlo Ersek Subject: [edk2-devel] [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm: Fix coding style Date: Thu, 8 Aug 2019 15:54:48 +0800 Message-Id: <20190808075448.6760-1-shenglei.zhang@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,shenglei.zhang@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1565250892; bh=IL2udUAhnHZXTR0dBzq+pEpJdoAJJuWdCKuePh8hPLg=; h=Cc:Date:From:Reply-To:Subject:To; b=SgTbhuwGiQ36ukiNPNJLV4l4xpTOaDIJXlTj4fdk+IFMjA1a9oB+wvtFPXPWRYOQrqW ScCmxOUPkwNs+o7zFhuak1N2Yl+z1nSNW31i8hIsP4SYCxm0lg37Z8IjW2d84N0d4K3LB v+mlrrsfcQvJ7BTUw7pgKn3huMo4iEhf6Iw= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" 1. Update CPUStatus to CpuStatus in comments to align comments with code. 2. Add "OUT" attribute for "ProcedureArguments" parameter in function header. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Shenglei Zhang Reviewed-by: Eric Dong --- v2: Add "OUT" attribute for "ProcedureArguments" parameter in both function header and comments,in MpService.c. UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 6 +++--- UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c b/UefiCpuPkg/PiSmmCpuDxe= Smm/MpService.c index 328d7ae53a49..d8d2b6f44461 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c @@ -1967,7 +1967,7 @@ RegisterSmmEntry ( EFI_MP_SERVICES_PROTOCOL.StartupAll= APs. If caller may pass a value of NULL = to deregister any existing startup procedure. - @param[in] ProcedureArguments Allows the caller to pass a list of= parameters to the code that is + @param[in,out] ProcedureArguments Allows the caller to pass a list of= parameters to the code that is run by the AP. It is an optional co= mmon mailbox between APs and the caller to share information =20 @@ -1977,8 +1977,8 @@ RegisterSmmEntry ( **/ EFI_STATUS RegisterStartupProcedure ( - IN EFI_AP_PROCEDURE Procedure, - IN VOID *ProcedureArguments OPTIONAL + IN EFI_AP_PROCEDURE Procedure, + IN OUT VOID *ProcedureArguments OPTIONAL ) { if (Procedure =3D=3D NULL && ProcedureArguments !=3D NULL) { diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h b/UefiCpuPkg/PiSmmC= puDxeSmm/PiSmmCpuDxeSmm.h index a0e59f20886b..7b3fbc8b55ec 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h @@ -1311,7 +1311,7 @@ RestoreCr2 ( Note that timeout support is o= ptional. Whether an implementation supports this feature can be d= etermined via the Attributes data member. - @param[in,out] CPUStatus This optional pointer may be u= sed to get the status code returned + @param[in,out] CpuStatus This optional pointer may be u= sed to get the status code returned by Procedure when it completes= execution on the target AP, or with EFI_TIMEOUT if the Procedure f= ails to complete within the optional timeout. The implementation wi= ll update this variable with @@ -1437,8 +1437,8 @@ InternalSmmStartupAllAPs ( **/ EFI_STATUS RegisterStartupProcedure ( - IN EFI_AP_PROCEDURE Procedure, - IN VOID *ProcedureArguments OPTIONAL + IN EFI_AP_PROCEDURE Procedure, + IN OUT VOID *ProcedureArguments OPTIONAL ); =20 /** --=20 2.18.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#45148): https://edk2.groups.io/g/devel/message/45148 Mute This Topic: https://groups.io/mt/32796387/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-