From nobody Mon May 6 10:07:00 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+44896+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+44896+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1564987442; cv=none; d=zoho.com; s=zohoarc; b=CQKcEZM4oAxPYZCvr5bvHpApm2dolE7s/drR3lA/QRzn+imFsrnxdhm2LGZfrf6bm6FY+wi6xCmaxOuy7Qv/H7/4k4jZ5A8ZzMQVIdAXKr/0GUADL/bcfO2WyNm1KcaH2+1cnjNm/XSOO7wPz5aattisowzvuF+31F+Sih0UDJg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1564987442; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=/Q0QSZr1DRATuXLs67DzbX3sakCB+kZBP0vdO0noAYI=; b=mbV0nEi1vhhOJakTDODuQ0pXPYH+eNAJSVW9eBCPDKFslwi1esWx986K0JjGuSvF7wREXLLWiU5O0cTIUD9T7A2cQjah+fSwJtFlE3P0FvnprL4qF24yrNS+1iejQ+DFbfQM7JKzmCmyn8OYFt5U60c2i0Hdzj8n7mb8tSrQHuw= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+44896+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1564987442861755.2640505062914; Sun, 4 Aug 2019 23:44:02 -0700 (PDT) Return-Path: X-Received: from mga17.intel.com (mga17.intel.com []) by groups.io with SMTP; Sun, 04 Aug 2019 23:44:02 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Aug 2019 23:44:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,348,1559545200"; d="scan'208";a="175501281" X-Received: from ydong10-win10.ccr.corp.intel.com ([10.239.158.133]) by fmsmga007.fm.intel.com with ESMTP; 04 Aug 2019 23:44:01 -0700 From: "Dong, Eric" To: devel@edk2.groups.io Cc: Ray Ni , Laszlo Ersek Subject: [edk2-devel] [Patch v2 1/2] UefiCpuPkg/RegisterCpuFeaturesLib: Remove debug message. Date: Mon, 5 Aug 2019 14:43:57 +0800 Message-Id: <20190805064359.29332-2-eric.dong@intel.com> In-Reply-To: <20190805064359.29332-1-eric.dong@intel.com> References: <20190805064359.29332-1-eric.dong@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,eric.dong@intel.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1564987442; bh=e3MP7+RgHiF9xOrv03xMVwc8wtr5g29lp4obBp0wvE8=; h=Cc:Date:From:Reply-To:Subject:To; b=oYbuK/J6g58rPpZb2hrCt2R8a+HyvBBKrXThTVjxjTCZMG8RoOiMKD8zpfMmKK2jJmT lJMQg14Q3oEVTQ/FcqYqW6FnvYTdr2fblzJknijH9k/NHd6RDA2je1TKJd6vUwIzwqG/M eUhY3Tx/Gm93bLtK826UBnD7t3QeQQEkZOA= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" This debug message may be called by BSP and APs. It may caused ASSERT when APs call this debug code. In order to avoid system boot assert, Remove this debug message. Signed-off-by: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Reviewed-by: Ray Ni --- .../CpuFeaturesInitialize.c | 22 ------------------- 1 file changed, 22 deletions(-) diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitializ= e.c b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c index 4e97e863c7..fb0535edd6 100644 --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c @@ -9,7 +9,6 @@ #include "RegisterCpuFeatures.h" =20 CHAR16 *mDependTypeStr[] =3D {L"None", L"Thread", L"Core", L"Package", L= "Invalid" }; -CHAR16 *mRegisterTypeStr[] =3D {L"MSR", L"CR", L"MMIO", L"CACHE", L"SEMAP"= , L"INVALID" }; =20 /** Worker function to save PcdCpuFeaturesCapability. @@ -772,7 +771,6 @@ ProgramProcessorRegister ( UINT32 PackageThreadsCount; UINT32 CurrentThread; UINTN ProcessorIndex; - UINTN ThreadIndex; UINTN ValidThreadCount; UINT32 *ValidCoreCountPerPackage; =20 @@ -785,26 +783,6 @@ ProgramProcessorRegister ( =20 RegisterTableEntry =3D &RegisterTableEntryHead[Index]; =20 - DEBUG_CODE_BEGIN (); - // - // Wait for the AP to release the MSR spin lock. - // - while (!AcquireSpinLockOrFail (&CpuFlags->ConsoleLogLock)) { - CpuPause (); - } - ThreadIndex =3D ApLocation->Package * CpuStatus->MaxCoreCount * CpuS= tatus->MaxThreadCount + - ApLocation->Core * CpuStatus->MaxThreadCount + - ApLocation->Thread; - DEBUG (( - DEBUG_INFO, - "Processor =3D %08lu, Index %08lu, Type =3D %s!\n", - (UINT64)ThreadIndex, - (UINT64)Index, - mRegisterTypeStr[MIN ((REGISTER_TYPE)RegisterTableEntry->RegisterT= ype, InvalidReg)] - )); - ReleaseSpinLock (&CpuFlags->ConsoleLogLock); - DEBUG_CODE_END (); - // // Check the type of specified register // --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44896): https://edk2.groups.io/g/devel/message/44896 Mute This Topic: https://groups.io/mt/32723169/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 6 10:07:00 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+44897+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+44897+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1564987443; cv=none; d=zoho.com; s=zohoarc; b=WcdbSNujz5jUsabPsyOddSfHst+7U0FuG86mevgQjRhJLv6gHpWZ39tO3chrUcQoidgDZsVCXsFhBKAV/wwrit6CR/6uMyGDepRWeUXR+hk3c+4g+6yMraI7aCrloU13PfIfDl53zGr2RSVc1prqQ47tlOuV1ujwFQS5nJhNGOI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1564987443; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=m0mZXOw95N8LOETswVm4KO/E/uocEeVHooCCNQijeJU=; b=Ia0JxEiUijLHxwR7qDvJb07q+yyo+BJWc6ZUBJ5328yqSjdFb8tFuvVe9kHKCgMA27yVB3aCITgcI+vsAQwbH68bSHgfvO/uywCsEt4HPD+sliQzEp1z5ggawhXrD9vaoMWYtqRfwZl8wor61PKxA0fptWM0FPrLxK2bnesA2H4= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+44897+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1564987443575869.4701558145202; Sun, 4 Aug 2019 23:44:03 -0700 (PDT) Return-Path: X-Received: from mga17.intel.com (mga17.intel.com []) by groups.io with SMTP; Sun, 04 Aug 2019 23:44:03 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Aug 2019 23:44:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,348,1559545200"; d="scan'208";a="175501299" X-Received: from ydong10-win10.ccr.corp.intel.com ([10.239.158.133]) by fmsmga007.fm.intel.com with ESMTP; 04 Aug 2019 23:44:02 -0700 From: "Dong, Eric" To: devel@edk2.groups.io Cc: Ray Ni , Laszlo Ersek Subject: [edk2-devel] [Patch v2 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Remove debug message. Date: Mon, 5 Aug 2019 14:43:58 +0800 Message-Id: <20190805064359.29332-3-eric.dong@intel.com> In-Reply-To: <20190805064359.29332-1-eric.dong@intel.com> References: <20190805064359.29332-1-eric.dong@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,eric.dong@intel.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1564987443; bh=xg7V5E9aNDSYLu2BXAGPiLDr/apTMbCDWVwemDmFbGU=; h=Cc:Date:From:Reply-To:Subject:To; b=bbG7WCTA16uRiD33cw5//lmO3zTLVO3gaqvcMwLJRfa5cypBnB9WzlA+TgL0ch+gSgq 4Mev+cJQ5Ulv3oilYyJFc3h0HjT4739ZozZ5BBc3PZevfWwF86CeMx7j/YUKf2KjsVwHv JsGlZ4rE6PLvZqKr/9UW5be3WxPU4IpuOqI= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" This debug message may be called by BSP and APs. It may caused ASSERT when APs call this debug code. In order to avoid system boot assert, Remove this debug message. Signed-off-by: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Reviewed-by: Ray Ni --- UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 22 +--------------------- 1 file changed, 1 insertion(+), 21 deletions(-) diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c b/UefiCpuPkg/PiSmmCpuDxeSmm/= CpuS3.c index 2cfc61b2c6..d20bc4aae6 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c @@ -1,7 +1,7 @@ /** @file Code for Processor S3 restoration =20 -Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.
+Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ @@ -90,8 +90,6 @@ UINT8 mApHltLoopCodeTemplate[] =3D= { 0xEB, 0xFC // jmp $-2 }; =20 -CHAR16 *mRegisterTypeStr[] =3D {L"MSR", L"CR", L"MMIO", L"CACHE", L"SEMAP"= , L"INVALID" }; - /** Sync up the MTRR values for all processors. =20 @@ -189,7 +187,6 @@ ProgramProcessorRegister ( UINT32 PackageThreadsCount; UINT32 CurrentThread; UINTN ProcessorIndex; - UINTN ThreadIndex; UINTN ValidThreadCount; UINT32 *ValidCoreCountPerPackage; =20 @@ -202,23 +199,6 @@ ProgramProcessorRegister ( =20 RegisterTableEntry =3D &RegisterTableEntryHead[Index]; =20 - DEBUG_CODE_BEGIN (); - if (ApLocation !=3D NULL) { - AcquireSpinLock (&CpuFlags->ConsoleLogLock); - ThreadIndex =3D ApLocation->Package * CpuStatus->MaxCoreCount * Cp= uStatus->MaxThreadCount + - ApLocation->Core * CpuStatus->MaxThreadCount + - ApLocation->Thread; - DEBUG (( - DEBUG_INFO, - "Processor =3D %lu, Entry Index %lu, Type =3D %s!\n", - (UINT64)ThreadIndex, - (UINT64)Index, - mRegisterTypeStr[MIN ((REGISTER_TYPE)RegisterTableEntry->Registe= rType, InvalidReg)] - )); - ReleaseSpinLock (&CpuFlags->ConsoleLogLock); - } - DEBUG_CODE_END (); - // // Check the type of specified register // --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44897): https://edk2.groups.io/g/devel/message/44897 Mute This Topic: https://groups.io/mt/32723170/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-