From nobody Sun Feb 8 19:38:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+44818+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+44818+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1564704798; cv=none; d=zoho.com; s=zohoarc; b=TaXIwhLHDspXQQWIUz4a2MvlcI7pxVFn1VeojpOH152VJ/SBbmBXx74cyNkxjQ127Cd9UXUdm9XwNLZfDkqCgYi/L5p3iBTCFQVFKvEYHt/LHvKx7FN+0xSKy3737aO5karmh9zobyHc36tt1TkRUQ+q5zunQIMLnuLcTdcRPGc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1564704798; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=vkeFblUw5B1n91AJhpd4KyJhwlSJ8Q0iBD88to1Q7+c=; b=LyPWe/i/UfDdbvIhwwY/Fekele5ttBR2CTw7g83SH+fv32MId3l7YNJy058rWbmzERTL95aMLnRrCmlZTQZIA3k2mC0oLCNs/I/rr0f0rlhLCS5zhklZiFsq8FI5jhTPjYeE7vvoWRj6UXbmcxnS/wanHLSC96yRIngCad5hdsE= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+44818+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1564704798633912.9122700966834; Thu, 1 Aug 2019 17:13:18 -0700 (PDT) Return-Path: X-Received: from mga01.intel.com (mga01.intel.com []) by groups.io with SMTP; Thu, 01 Aug 2019 17:13:17 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Aug 2019 17:13:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,336,1559545200"; d="scan'208";a="372796688" X-Received: from mdkinney-mobl2.amr.corp.intel.com ([10.251.130.221]) by fmsmga006.fm.intel.com with ESMTP; 01 Aug 2019 17:13:17 -0700 From: "Michael D Kinney" To: devel@edk2.groups.io Cc: Bob Feng , Liming Gao , Jordan Justen Subject: [edk2-devel] [Patch 1/3] BaseTools/PatchCheck: Ignore blank lines in diff Date: Thu, 1 Aug 2019 17:13:12 -0700 Message-Id: <20190802001314.25980-2-michael.d.kinney@intel.com> In-Reply-To: <20190802001314.25980-1-michael.d.kinney@intel.com> References: <20190802001314.25980-1-michael.d.kinney@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1564704798; bh=1fZheblcjM4MwaJBzARcp54br+/FkJIAtBFnqjBks2I=; h=Cc:Date:From:Reply-To:Subject:To; b=re5OKGw/vvx6rfsOzqBOg2d39Eamhio68C8qSjfBSNsmIK5UiggqrvRQVi6rCuQrNqc nzvtv+NzzJayxSP8Qf8UPU1okhusAvzkY4P5lgOGbLGy4eFX8Lt/65AGI36eTCL8dLlz+ PWok8U9Go0zFMVIFG/6i/HjG2IIwmQbc6A4= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" https://bugzilla.tianocore.org/show_bug.cgi?id=3D2044 When fixes are made for incorrect line endings, there are cases where the diff contains blank lines. Ignore these blank lines. Cc: Bob Feng Cc: Liming Gao Cc: Jordan Justen Signed-off-by: Michael D Kinney --- BaseTools/Scripts/PatchCheck.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck= .py index 6aec15d0f0..4f2ef81ae7 100755 --- a/BaseTools/Scripts/PatchCheck.py +++ b/BaseTools/Scripts/PatchCheck.py @@ -270,6 +270,7 @@ class GitDiffCheck: if line.startswith('@@ '): self.state =3D PRE_PATCH elif len(line) >=3D 1 and line[0] not in ' -+' and \ + not line.startswith('\r\n') and \ not line.startswith(r'\ No newline ') and not self.binary: for line in self.lines[self.line_num + 1:]: if line.startswith('diff --git'): @@ -313,6 +314,8 @@ class GitDiffCheck: pass elif line.startswith('+'): self.check_added_line(line[1:]) + elif line.startswith('\r\n'): + pass elif line.startswith(r'\ No newline '): pass elif not line.startswith(' '): --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44818): https://edk2.groups.io/g/devel/message/44818 Mute This Topic: https://groups.io/mt/32685492/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-