From nobody Thu May 9 01:39:14 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+44808+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+44808+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1564692951; cv=none; d=zoho.com; s=zohoarc; b=D3D7voYMbH99CpJaFPl2zArjiExJ0DlmfYExgLe7XqKjS4oIrgfYB725Gqnak40rCv4kp+ouQHZvUSVfjNFbOg0MZt8oTiTA4jXaTd7aLhYvalmb5IaePCNVNW2igJL+V6LGEKPoevL0vlB8aAz9Nl2tR/J+n5OM07TzoZgth7E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1564692951; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=rghGzB050ULUDFca0cqDO7d0yUvWSZQQ/KQRAXOVGMo=; b=R4BBZqCgRdTzZRbCkBGGp3ypOg6lkjbCFUrzPfBm8OlIcIRc9FHdh5pk1+SITfeufRWUaA8cVvdfcNJckFm3OynZhdosmQDsefNrb3+TBpyz63Llj5o4knLmbETiN6Pbc0IL+kyYmmUjSO7CSOitSP354JeU7iRNXDcem3NazZ4= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+44808+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1564692951558959.8254630234384; Thu, 1 Aug 2019 13:55:51 -0700 (PDT) Return-Path: X-Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by groups.io with SMTP; Thu, 01 Aug 2019 13:55:50 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Aug 2019 13:55:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,335,1559545200"; d="scan'208";a="191705261" X-Received: from mdkinney-mobl2.amr.corp.intel.com ([10.251.130.221]) by fmsmga001.fm.intel.com with ESMTP; 01 Aug 2019 13:55:42 -0700 From: "Michael D Kinney" To: devel@edk2.groups.io Cc: Jaben Carsey , Ray Ni , Zhichao Gao , Sami Mujawar Subject: [edk2-devel] [Patch v2 1/2] ShellPkg/AcpiView: Fix IA32 link error Date: Thu, 1 Aug 2019 13:55:40 -0700 Message-Id: <20190801205541.24792-2-michael.d.kinney@intel.com> In-Reply-To: <20190801205541.24792-1-michael.d.kinney@intel.com> References: <20190801205541.24792-1-michael.d.kinney@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1564692951; bh=HhObc8+eQIeF6mttyonKjqeKAXjplBbi26mlLfGYWlY=; h=Cc:Date:From:Reply-To:Subject:To; b=WgKGR0qV5X/nLvqYoflb6bVqLVyo5fpl7mHWpkhZ9uZRYZDSBl1dLuRGQRxFTITvAOL 28e7LeLLrqde4Ucs+kryYs4A/DX8IaSCzfAKxyuzGdClPdzXhx6BIDKC0J645HC4CPYZb KXcGTS1Amw8RFDfT8ZNd2LMluCJ/i/MFoOs= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" https://bugzilla.tianocore.org/show_bug.cgi?id=3D1970 Update local variable in ParseAcpiSlot() to be UINT32 instead of UINT64 to avoid 64-bit multiply operation in the SLIT_ELEMENT() macro. If LocalityCount is >=3D MAX_UINT32 and then skip the validation check and print an INFO message instead. Cc: Jaben Carsey Cc: Ray Ni Cc: Zhichao Gao Cc: Sami Mujawar Signed-off-by: Michael D Kinney Reviewed-by: Jaben Carsey --- .../Parsers/Slit/SlitParser.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Slit/Slit= Parser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Slit/SlitPa= rser.c index 1f9dac66ee..6913ad8b31 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Slit/SlitParser.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Slit/SlitParser.c @@ -57,8 +57,8 @@ ParseAcpiSlit ( ) { UINT32 Offset; - UINT64 Count; - UINT64 Index; + UINT32 Count; + UINT32 Index; UINT64 LocalityCount; UINT8* LocalityPtr; CHAR16 Buffer[80]; // Used for AsciiName param of ParseAcpi @@ -105,6 +105,11 @@ ParseAcpiSlit ( } } =20 + if (LocalityCount >=3D MAX_UINT32) { + Print (L"INFO: Skipping validation of System Localities as locality co= unt is >=3D MAX_UINT32\n"); + return; + } + // Validate for (Count =3D 0; Count < LocalityCount; Count++) { for (Index =3D 0; Index < LocalityCount; Index++) { --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44808): https://edk2.groups.io/g/devel/message/44808 Mute This Topic: https://groups.io/mt/32683877/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Thu May 9 01:39:14 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+44810+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+44810+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1564692952; cv=none; d=zoho.com; s=zohoarc; b=LOLTpapx0sKmI7RBn3jKjmQRDJLgxPXuk7w9nqdwpXdfc4ZczTHaxXh+P8mR69zBKjrDDl+E8KNum6E8NqJtmHj+mIL+PYpvsF4pKQmVKDO/15yljyZQHmhsNHqK9rrMI77RmxB79RcCiEDGGc1VpOJ0RZiRnbgC/zgKZWcL52Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1564692952; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=CV5MajejeV+ZJ2HUnFxfIr6vViDv89eK38Dzza+DHvg=; b=gi73VqRF96aFN5pjxhnd143CuyRBQYYJ10WlTyotFlSqTFV6yvAROt9wXHIeel1ChuYigb4+paUAyDmewcY/6tMzg7jlk5WEmp0Oy7z7wQVMW/9qM3cq7vTjgSwva7X1zJzJyrS/NGReic3yMN6Bvx2R01ZfsjBQEIi4Ppl2Jr8= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+44810+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1564692952548849.4865876409768; Thu, 1 Aug 2019 13:55:52 -0700 (PDT) Return-Path: X-Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by groups.io with SMTP; Thu, 01 Aug 2019 13:55:51 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Aug 2019 13:55:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,335,1559545200"; d="scan'208";a="191705264" X-Received: from mdkinney-mobl2.amr.corp.intel.com ([10.251.130.221]) by fmsmga001.fm.intel.com with ESMTP; 01 Aug 2019 13:55:43 -0700 From: "Michael D Kinney" To: devel@edk2.groups.io Cc: Jaben Carsey , Ray Ni , Zhichao Gao , Sami Mujawar Subject: [edk2-devel] [Patch v2 2/2] ShellPkg: Add shell with all commands integrated Date: Thu, 1 Aug 2019 13:55:41 -0700 Message-Id: <20190801205541.24792-3-michael.d.kinney@intel.com> In-Reply-To: <20190801205541.24792-1-michael.d.kinney@intel.com> References: <20190801205541.24792-1-michael.d.kinney@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1564692952; bh=Gbt6OFHi8Y7YgULEKtrijN6rh/0HMaJERRr4npaSVQw=; h=Cc:Date:From:Reply-To:Subject:To; b=YTtUt4BPpwUQpF1qVZUIJP5gRHxl/8dLKyf1EUV4gyaX6jyxlrzuXtNPmT0n9oK85oo s7pkLEoI7CipQG6U7oZg+mP2OFjHcEuOhBY41TaNYi4sZaD9RsUDMsk1vGfd5/q8M3MMy ofto7KzF8a/8geMu5FhLMHuiYHvkQ7yDI2A= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" https://bugzilla.tianocore.org/show_bug.cgi?id=3D1970 Update ShellPkg DSC file to build an extra version of the Shell with all commands integrated. This verifies that the shell can build in this max configuration. Cc: Jaben Carsey Cc: Ray Ni Cc: Zhichao Gao Cc: Sami Mujawar Signed-off-by: Michael D Kinney Reviewed-by: Jaben Carsey --- ShellPkg/ShellPkg.dsc | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/ShellPkg/ShellPkg.dsc b/ShellPkg/ShellPkg.dsc index 6a139b3b91..b2065dc028 100644 --- a/ShellPkg/ShellPkg.dsc +++ b/ShellPkg/ShellPkg.dsc @@ -1,7 +1,7 @@ ## @file # Shell Package # -# Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.
+# Copyright (c) 2007 - 2019, Intel Corporation. All rights reserved.
# Copyright (c) 2018, Arm Limited. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent @@ -115,6 +115,26 @@ [Components] !endif #$(NO_SHELL_PROFILES) } =20 + # + # Build a second version of the shell with all commands integrated + # + ShellPkg/Application/Shell/Shell.inf { + + FILE_GUID =3D EA4BB293-2D7F-4456-A681-1F22F42CD0BC + + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE + + NULL|ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2Comm= andsLib.inf + NULL|ShellPkg/Library/UefiShellLevel1CommandsLib/UefiShellLevel1Comm= andsLib.inf + NULL|ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3Comm= andsLib.inf + NULL|ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1Co= mmandsLib.inf + NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1= CommandsLib.inf + NULL|ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comm= andsLib.inf + NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1= CommandsLib.inf + NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2= CommandsLib.inf + NULL|ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewC= ommandLib.inf + } + ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf { gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44810): https://edk2.groups.io/g/devel/message/44810 Mute This Topic: https://groups.io/mt/32683879/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-