From nobody Sat May 4 23:19:06 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+44570+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+44570+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1564423410; cv=none; d=zoho.com; s=zohoarc; b=Y4xwqPgDI+JzYTqXFilJLJq+SZJQKJ5zj3ZZHbhzLMu8cO9iYtAm+2OhDu/nal3ruh7FTxHmkEk0Lv2zkDf7IiCq7atu0pPdLrdPd6s0QDubedfn5jEy4Do5J4EP0x1hBDCPok8C0pXQQBvtt8EnruqjFEdTNpZXCTWSAwEgPmU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1564423410; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=r9iNAFm9HJIovW6MYE9beoAwZIECSfEzBFoapclFLOg=; b=B5DpUr3eV1DaJt0lW3T6eojcSvvPiZ1SsXKdhcnzlEY3//nYDswm/0Fh44iYtcFEmCn1o2VPbw3kXdlWOQ95+0ZRstaDwi2NmMWwHhUsp+9lTInMfpq/BGCAOLDpY/wJXi6oFYqqrE+L+36QTXkJP9UnAAY+Mp/nsuwaB4dd+KU= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+44570+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1564423410586494.97912241646907; Mon, 29 Jul 2019 11:03:30 -0700 (PDT) Return-Path: X-Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Mon, 29 Jul 2019 11:03:29 -0700 X-Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6B825316290C; Mon, 29 Jul 2019 18:03:29 +0000 (UTC) X-Received: from x1w.redhat.com (unknown [10.40.205.107]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B254F5C205; Mon, 29 Jul 2019 18:03:27 +0000 (UTC) From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= To: devel@edk2.groups.io Cc: Leif Lindholm , Laszlo Ersek , Ard Biesheuvel , Philippe Mathieu-Daude , Andrew Jones Subject: [edk2-devel] [PATCH 1/2] ArmPkg: DebugPeCoffExtraActionLib: debugger commands are not errors Date: Mon, 29 Jul 2019 20:03:20 +0200 Message-Id: <20190729180321.1715-2-philmd@redhat.com> In-Reply-To: <20190729180321.1715-1-philmd@redhat.com> References: <20190729180321.1715-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Mon, 29 Jul 2019 18:03:29 +0000 (UTC) Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,philmd@redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1564423410; bh=DusygjRo9QAi3q3N3J8JNGGiRgLsDZfnyoNAPWy1rWM=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=KhfX5FKzuQ2a5xurNndobkR6IEWg0utLgRBLpFqaBdpajrE+g7KrwEI28vFhy1QI587 j6Dhd8Im/I8BuLUsMVgksS4TtBAFr5N2zq4I7jPTElexNmmKh4IRy8TYKrWcrN7xfIPuo mdTRjPSEzWYyY62Mh20OQEtPsosDVN3SGV4= X-ZohoMail-DKIM: pass (identity @groups.io) In commit 1fce963d89f3e we reduced the level of information printed by PeCoffLoaderRelocateImageExtraAction() but we did not update the similar PeCoffLoaderUnloadImageExtraAction() function. PeCoffLoaderUnloadImageExtraAction() prints helpful debugger commands for source level debugging. These messages should not be printed on the EFI_D_ERROR level; they don't report errors. Change the debug level (bitmask, actually) to DEBUG_LOAD | DEBUG_INFO, because the messages are printed in relation to image loading, and they are informative. Cc: Leif Lindholm Cc: Ard Biesheuvel Reported-by: Andrew Jones Suggested-by: Laszlo Ersek Signed-off-by: Philippe Mathieu-Daude Reviewed-by: Laszlo Ersek Reviewed-by: Leif Lindholm --- .../DebugPeCoffExtraActionLib/DebugPeCoffExtraActionLib.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ArmPkg/Library/DebugPeCoffExtraActionLib/DebugPeCoffExtraActio= nLib.c b/ArmPkg/Library/DebugPeCoffExtraActionLib/DebugPeCoffExtraActionLib= .c index a1cb99677fe6..3379744aa185 100644 --- a/ArmPkg/Library/DebugPeCoffExtraActionLib/DebugPeCoffExtraActionLib.c +++ b/ArmPkg/Library/DebugPeCoffExtraActionLib/DebugPeCoffExtraActionLib.c @@ -122,14 +122,14 @@ PeCoffLoaderUnloadImageExtraAction ( if (ImageContext->PdbPointer) { #ifdef __CC_ARM // Print out the command for the RVD debugger to load symbols for this= image - DEBUG ((EFI_D_ERROR, "unload symbols_only %a\n", DeCygwinPathIfNeeded = (ImageContext->PdbPointer, Temp, sizeof (Temp)))); + DEBUG ((DEBUG_LOAD | DEBUG_INFO, "unload symbols_only %a\n", DeCygwinP= athIfNeeded (ImageContext->PdbPointer, Temp, sizeof (Temp)))); #elif __GNUC__ // This may not work correctly if you generate PE/COFF directlyas then= the Offset would not be required - DEBUG ((EFI_D_ERROR, "remove-symbol-file %a 0x%08x\n", DeCygwinPathIfN= eeded (ImageContext->PdbPointer, Temp, sizeof (Temp)), (UINTN)(ImageContext= ->ImageAddress + ImageContext->SizeOfHeaders))); + DEBUG ((DEBUG_LOAD | DEBUG_INFO, "remove-symbol-file %a 0x%08x\n", DeC= ygwinPathIfNeeded (ImageContext->PdbPointer, Temp, sizeof (Temp)), (UINTN)(= ImageContext->ImageAddress + ImageContext->SizeOfHeaders))); #else - DEBUG ((EFI_D_ERROR, "Unloading %a\n", ImageContext->PdbPointer)); + DEBUG ((DEBUG_LOAD | DEBUG_INFO, "Unloading %a\n", ImageContext->PdbPo= inter)); #endif } else { - DEBUG ((EFI_D_ERROR, "Unloading driver at 0x%11p\n", (VOID *)(UINTN) I= mageContext->ImageAddress)); + DEBUG ((DEBUG_LOAD | DEBUG_INFO, "Unloading driver at 0x%11p\n", (VOID= *)(UINTN) ImageContext->ImageAddress)); } } --=20 2.20.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44570): https://edk2.groups.io/g/devel/message/44570 Mute This Topic: https://groups.io/mt/32645507/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 4 23:19:06 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+44571+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+44571+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1564423412; cv=none; d=zoho.com; s=zohoarc; b=Au4eWpM706nf/CgPTrfYbDCsX38vWPFhiUrd0qmC/uIjaMW4aAA+JesqGgK07ptRC5VSpSQDiKKk0uqP63NtAsxoCv64q71G7oUVdTtrVCh3JOhFTd/Av1IinccPw8deClzb8TvrwkQnqwQ9KN6JRRgY0Nox8wgQOJqjagw8j5I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1564423412; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=LqsUuhhfpUCZC0XfQv0007qYFKdqYBtSxaXqM1sDwfA=; b=Axxk37Joymtr9Yn9mZedhvXt9WFHcZwPrIMHuelouhzFneFcUhj71MvUEebMG6M+UBD1GbfhyeikiPSq/B8e1nyQOM/2Qzit9pZbInYm3reTV+NinQihpigL4wmdJgeStDSZLJSphyEWKqk+Hlrty5euO4PHjp6oNoiNaNsjeD4= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+44571+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 156442341244959.88052546492304; Mon, 29 Jul 2019 11:03:32 -0700 (PDT) Return-Path: X-Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Mon, 29 Jul 2019 11:03:31 -0700 X-Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4D240300BC74; Mon, 29 Jul 2019 18:03:31 +0000 (UTC) X-Received: from x1w.redhat.com (unknown [10.40.205.107]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C7D7A5C1B5; Mon, 29 Jul 2019 18:03:29 +0000 (UTC) From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= To: devel@edk2.groups.io Cc: Leif Lindholm , Laszlo Ersek , Ard Biesheuvel , Philippe Mathieu-Daude Subject: [edk2-devel] [PATCH 2/2] ArmPkg: DebugPeCoffExtraActionLib: fix trivial typos Date: Mon, 29 Jul 2019 20:03:21 +0200 Message-Id: <20190729180321.1715-3-philmd@redhat.com> In-Reply-To: <20190729180321.1715-1-philmd@redhat.com> References: <20190729180321.1715-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Mon, 29 Jul 2019 18:03:31 +0000 (UTC) Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,philmd@redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1564423412; bh=VAnfAQ5xY1GB90zZkz/aragZvWaUxp0CmwHcwXvvIks=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=bMDX0aCgQXdMp85FXAF3BdCEa9kccL9A8/WIVTl/mxuuW+ptMytOy3yYEK44kwh2qqq ppUYGaCLo5S/aGYSwiIeArp7pQs6v4IY8qbkI1+xcu+f37rMBNBLClnM6t2KYsXvJGQn6 We8n0W8yx+wotgaNwTldr+SdMK+iQZzQFc8= X-ZohoMail-DKIM: pass (identity @groups.io) Fix a pair of trivial typos by inserting a space. Cc: Leif Lindholm Cc: Ard Biesheuvel Signed-off-by: Philippe Mathieu-Daude Reviewed-by: Laszlo Ersek Reviewed-by: Leif Lindholm --- .../DebugPeCoffExtraActionLib/DebugPeCoffExtraActionLib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ArmPkg/Library/DebugPeCoffExtraActionLib/DebugPeCoffExtraActio= nLib.c b/ArmPkg/Library/DebugPeCoffExtraActionLib/DebugPeCoffExtraActionLib= .c index 3379744aa185..3f88e84372ee 100644 --- a/ArmPkg/Library/DebugPeCoffExtraActionLib/DebugPeCoffExtraActionLib.c +++ b/ArmPkg/Library/DebugPeCoffExtraActionLib/DebugPeCoffExtraActionLib.c @@ -87,7 +87,7 @@ PeCoffLoaderRelocateImageExtraAction ( DEBUG ((EFI_D_LOAD | EFI_D_INFO, "add-symbol-file %a 0x%p\n", DeCygwin= PathIfNeeded (ImageContext->PdbPointer, Temp, sizeof (Temp)), (UINTN)(Image= Context->ImageAddress + ImageContext->SizeOfHeaders))); #endif #elif __GNUC__ - // This may not work correctly if you generate PE/COFF directlyas then= the Offset would not be required + // This may not work correctly if you generate PE/COFF directly as the= n the Offset would not be required DEBUG ((EFI_D_LOAD | EFI_D_INFO, "add-symbol-file %a 0x%p\n", DeCygwin= PathIfNeeded (ImageContext->PdbPointer, Temp, sizeof (Temp)), (UINTN)(Image= Context->ImageAddress + ImageContext->SizeOfHeaders))); #else DEBUG ((EFI_D_LOAD | EFI_D_INFO, "Loading driver at 0x%11p EntryPoint= =3D0x%11p\n", (VOID *)(UINTN) ImageContext->ImageAddress, FUNCTION_ENTRY_PO= INT (ImageContext->EntryPoint))); @@ -124,7 +124,7 @@ PeCoffLoaderUnloadImageExtraAction ( // Print out the command for the RVD debugger to load symbols for this= image DEBUG ((DEBUG_LOAD | DEBUG_INFO, "unload symbols_only %a\n", DeCygwinP= athIfNeeded (ImageContext->PdbPointer, Temp, sizeof (Temp)))); #elif __GNUC__ - // This may not work correctly if you generate PE/COFF directlyas then= the Offset would not be required + // This may not work correctly if you generate PE/COFF directly as the= n the Offset would not be required DEBUG ((DEBUG_LOAD | DEBUG_INFO, "remove-symbol-file %a 0x%08x\n", DeC= ygwinPathIfNeeded (ImageContext->PdbPointer, Temp, sizeof (Temp)), (UINTN)(= ImageContext->ImageAddress + ImageContext->SizeOfHeaders))); #else DEBUG ((DEBUG_LOAD | DEBUG_INFO, "Unloading %a\n", ImageContext->PdbPo= inter)); --=20 2.20.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44571): https://edk2.groups.io/g/devel/message/44571 Mute This Topic: https://groups.io/mt/32645508/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-