From nobody Mon Feb 9 01:16:28 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+44443+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1564124974881248.81505490194718; Fri, 26 Jul 2019 00:09:34 -0700 (PDT) Return-Path: X-Received: from m9a0002g.houston.softwaregrp.com (m9a0002g.houston.softwaregrp.com [15.124.64.67]) by groups.io with SMTP; Fri, 26 Jul 2019 00:09:33 -0700 X-Received: FROM m9a0002g.houston.softwaregrp.com (15.121.0.190) BY m9a0002g.houston.softwaregrp.com WITH ESMTP; Fri, 26 Jul 2019 07:09:30 +0000 X-Received: from M4W0334.microfocus.com (2002:f78:1192::f78:1192) by M9W0067.microfocus.com (2002:f79:be::f79:be) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Fri, 26 Jul 2019 07:06:42 +0000 X-Received: from NAM05-DM3-obe.outbound.protection.outlook.com (15.124.8.10) by M4W0334.microfocus.com (15.120.17.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10 via Frontend Transport; Fri, 26 Jul 2019 07:06:42 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OPLqRs1jyeIY1Kk4KYBbHe4zE2/8/JuV82owyfqHf7xJj+dGdlHO1QqYKqmksZiZAvoHsI5ogP1GRLWrfqJne1ajutUdBHdOPXL7YMZbRt6v0pLjwlr8s1hfaVBNApjXFLvFfNc6nwIJS1TLYDcqfXQaGyg6x0krpO5fw6VNnPxRxYDFWmK0lhALYxiESKLyDL3cQdFPf37tYXQTr8tM1m66mLXAYRtooEMA2UDHo9rgfnOCAlWT2xrP5Z+80BIsYrTjxKxI0L0O24srfWR7ytJJPrsyMmwmH6w4492rIhzt8pFwSWhRu3/k0xOjA+IAOeDzU+9GP+GCU1ea7rZvaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/JfrRkJb0KD58ROdc7tQ/tbnLvqvdPvfg7fOO81QCH8=; b=DQECoOVWO04lPAOjB200yik9migNUL0lUu7O/ABgqWwTP0tatFcIfyWqM6I61J3v1n6TLU3OgQ4yYyH7Ajiash9BAGoVVTEJs7sONv5EAAGJ1trHLB1ikQLlplMj1K55jHYtXQ+u0LMDLoRk/sB1zwik+1Lx73SeaoB23GsRO4HrPAFtT/H/LmZ+rdYnxRGFkB9CpfyVLvgoPx4VmJUS6nEqbojnswJjNi4Ft9D1jvFHvnACQ2kxKDCT3DfmJTpmAVqghSikDEonuXeKlnlQ4YzKG1AoJLsd8ny3VnMzUSLwX710AblKG6WRD1nNQtM9AIrYld6nqGQRRef0Yflj9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none X-Received: from DM6PR18MB2489.namprd18.prod.outlook.com (20.179.105.16) by DM6PR18MB2923.namprd18.prod.outlook.com (20.179.51.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2115.14; Fri, 26 Jul 2019 07:06:41 +0000 X-Received: from DM6PR18MB2489.namprd18.prod.outlook.com ([fe80::ac83:47c9:cebd:9f0]) by DM6PR18MB2489.namprd18.prod.outlook.com ([fe80::ac83:47c9:cebd:9f0%7]) with mapi id 15.20.2115.005; Fri, 26 Jul 2019 07:06:41 +0000 From: "Gary Lin" To: "devel@edk2.groups.io" CC: Zailiang Sun , Yi Qian , Michael D Kinney Subject: [edk2-devel] [PATCH edk2-platforms 3/4] Vlv2TbltDevicePkg: Only sort boot options when necessary Thread-Topic: [PATCH edk2-platforms 3/4] Vlv2TbltDevicePkg: Only sort boot options when necessary Thread-Index: AQHVQ4CtYxt1N50pdEi1Q0sxOU5qYw== Date: Fri, 26 Jul 2019 07:06:41 +0000 Message-ID: <20190726070612.3649-4-glin@suse.com> References: <20190726070612.3649-1-glin@suse.com> In-Reply-To: <20190726070612.3649-1-glin@suse.com> Accept-Language: zh-TW, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HK0PR01CA0004.apcprd01.prod.exchangelabs.com (2603:1096:203:92::16) To DM6PR18MB2489.namprd18.prod.outlook.com (2603:10b6:5:184::16) x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [202.47.205.198] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 180cb9b8-26bc-4ee0-c8e2-08d71197cf77 x-ms-traffictypediagnostic: DM6PR18MB2923: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+44443+1787277+3901457@groups.io; helo=web01.groups.io; received-spf: None (protection.outlook.com: suse.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: aakWsV84iwcw4tKpbsn+TXMSlJdWnmxRmk5AKqOOBRa/rTicAIP296kq69mhiyk84qXDu/yy9lNNrBPlU4Frbh63WJkG1Tb5jrsRInDaskcqA72q1aQb90w55UnPIL4kH8Koc2xJPtGZmFzIQZKZ194X7lNEVv5HKcPR9CSuRe/d8RP2ol+MqhCXlJ+HHitiZNANb23f0VvnUe/ve+jIfAYiPcGQFp56Pf3Y23bMRhPGNPf+v3NP0lwl6d1JO5SeTs6/Os5bABMrzlMkCg/lB+Jx2+wsSs5g1X9MFmZAQEZopI1k/FEIPV3SPcyXm/Bzx30qRIAZ3LsxG5BEmrpHjsUUUNgawp4EHJ81CzW3hlMEBrjlzWfLOk9DRkAl7I7F8J0jm0jG/36DUnN2QzoD0+p4vciFEV68ABvWhemIyq8= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 180cb9b8-26bc-4ee0-c8e2-08d71197cf77 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jul 2019 07:06:41.6101 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 856b813c-16e5-49a5-85ec-6f081e13b527 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GLin@suse.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB2923 X-OriginatorOrg: suse.com Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,glin@suse.com Content-Language: en-US Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1564124974; bh=1NfAXiMlEamNfEwq2Ypvwfg6ejxlmrDQ1BFzTZyjfyw=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=pscIc5Fqpa0Qkru9GkahdSn4hBEfDunYg2cLADwjeID5lFq7DPsBfyvHjrW/TdmRlkz ZYSSpkA5wa1RbNF16k5hzHpF9E90Un3z6+QgYxVl9IDpWUQKOIHxP3/RU1svGydkemnSK YWGFD5ixXGRHaTprrp5te4Vg2isEKEHNY9I= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" * PlatformBootManagerAfterConsole() always sorted the boot options at the end, and this would invalidate the BootOrder created by the user. Besides, the current implementation would sort the boot options twice, and this is not efficient. We should just sort the boot options once at the end of the function only for the very first boot. * Update the string in IsNeedSortBootOption() to match the descriptions of BootManagerMenuApp. Cc: Zailiang Sun Cc: Yi Qian Cc: Michael D Kinney Signed-off-by: Gary Lin --- Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBootManagerLib/BdsPlat= form.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBootManage= rLib/BdsPlatform.c b/Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBo= otManagerLib/BdsPlatform.c index 7fbbf281c6..a5423013a5 100644 --- a/Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBootManagerLib/Bd= sPlatform.c +++ b/Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBootManagerLib/Bd= sPlatform.c @@ -1299,7 +1299,7 @@ IsNeedSortBootOption ( // if ((BootOptionCount > 1) && (((StrnCmp (BootOptions->Description, L"Enter Setup", StrLen (L"Ente= r Setup"))) =3D=3D 0) || - ((StrnCmp (BootOptions->Description, L"BootManagerMenuApp", StrLen = (L"BootManagerMenuApp"))) =3D=3D 0))) { + ((StrnCmp (BootOptions->Description, L"Boot Device List", StrLen (L= "Boot Device List"))) =3D=3D 0))) { return TRUE; } =20 @@ -1374,9 +1374,6 @@ PlatformBootManagerAfterConsole ( // EfiBootManagerRefreshAllBootOption (); =20 - if (IsNeedSortBootOption()) { - EfiBootManagerSortLoadOptionVariable (LoadOptionTypeBoot, CompareBoo= tOption); - } // // PXE boot option may appear after boot option enumeration // @@ -1400,7 +1397,9 @@ PlatformBootManagerAfterConsole ( Print (L"Press F7 for BootMenu!\n"); =20 EfiBootManagerRefreshAllBootOption (); - EfiBootManagerSortLoadOptionVariable (LoadOptionTypeBoot, CompareBootOpt= ion); + if (IsNeedSortBootOption()) { + EfiBootManagerSortLoadOptionVariable (LoadOptionTypeBoot, CompareBootO= ption); + } } =20 /** --=20 2.22.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44443): https://edk2.groups.io/g/devel/message/44443 Mute This Topic: https://groups.io/mt/32606868/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-