From nobody Thu May 2 02:48:43 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+44273+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+44273+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1563929411; cv=none; d=zoho.com; s=zohoarc; b=A04ekCjva6cvhxDmg/pe1U4x5nj+w7jX7xQF3tJRUJJsVuyVDpanTimG+WTynmQngHBfogL2xhN9iENLpXKGq9jvzLqoJ583b4oiTzfqNqSYHjHjfD67aufpwjPo6xRDpgN/7jECQZSjmqzh3jFzOwijO4E0zHOOmBe8m+7UsN0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1563929411; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To:ARC-Authentication-Results; bh=55jtdBmmEG3M8DAXofMEZLSbNNPuCu4BlGS5kXizxHs=; b=dqMsi8+l301GnAjBllr5NWLPFw/0/dtalu96l9PNjiTyvXnBrJ1wBXXTHskjbvYildfqh+3RRvOOAzEZb3Cu07ayUIx5qb5LlhhSjnI2ucOzglag6ZGmp8DU8vIiIJmVQ3HlrfeFKzgAkV+9TZ3JyBQw9L1pY/EWJdnSN6P/zOE= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+44273+1787277+3901457@groups.io Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1563929411556739.1807976775632; Tue, 23 Jul 2019 17:50:11 -0700 (PDT) Return-Path: X-Received: from muon.bsdio.com (muon.bsdio.com [65.103.231.193]) by groups.io with SMTP; Tue, 23 Jul 2019 17:50:10 -0700 X-Received: from muon.bsdio.com (localhost [127.0.0.1]) by muon.bsdio.com (Postfix) with ESMTP id 44ED98985C; Tue, 23 Jul 2019 18:50:31 -0600 (MDT) X-Received: from muon.bsdio.com ([127.0.0.1]) by muon.bsdio.com (muon.bsdio.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 82zOvHUgCd2m; Tue, 23 Jul 2019 18:50:29 -0600 (MDT) X-Received: from photon.int.bluestop.org (unknown [10.0.10.120]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by muon.bsdio.com (Postfix) with ESMTPSA; Tue, 23 Jul 2019 18:50:29 -0600 (MDT) From: rebecca@bsdio.com To: devel@edk2.groups.io, jordan.l.justen@intel.com, lersek@redhat.com, ard.biesheuvel@linaro.org Cc: Rebecca Cran Subject: [edk2-devel] [PATCH] OvmfPkg/build.sh: use POSIX 'command -v' instead of 'which'. Date: Tue, 23 Jul 2019 18:49:47 -0600 Message-Id: <20190724004947.55202-1-rebecca@bsdio.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,rebecca@bsdio.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1563929411; bh=/RGOLhoc8QFmwK8I0uiL0kDXxCWIP3D+nZdyRBKW8C4=; h=Cc:Date:From:Reply-To:Subject:To; b=ACxEkjNajSg0fbvmFnaAwAQDCRT4IRStXTQtGr0EVK2o1Tjy/K7ldIANk9pPVTBK5wu 9F4s3g3cPekIIG+fAr00LfDJAUavwRRYeNBfiAamHZNepIZAzP06XfBDE3R+oXX1ELUzS HmTmcpc1G5ITI7JMpm+J4Ner38nBoYFBmog= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Signed-off-by: Rebecca Cran --- OvmfPkg/build.sh | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh index e94aa2a37e..1c28e65404 100755 --- a/OvmfPkg/build.sh +++ b/OvmfPkg/build.sh @@ -174,11 +174,11 @@ case $PROCESSOR in # The user set the QEMU_COMMAND variable. We'll use it to run QEMU. # : - elif [ -x `which qemu-system-i386` ]; then + elif command -v qemu-system-i386; then QEMU_COMMAND=3Dqemu-system-i386 - elif [ -x `which qemu-system-x86_64` ]; then + elif command -v qemu-system-x86_64; then QEMU_COMMAND=3Dqemu-system-x86_64 - elif [ -x `which qemu` ]; then + elif command -v qemu; then QEMU_COMMAND=3Dqemu else echo Unable to find QEMU for IA32 architecture! @@ -242,12 +242,12 @@ FV_DIR=3D$BUILD_ROOT/FV BUILD_ROOT_ARCH=3D$BUILD_ROOT/$BUILD_ROOT_ARCH QEMU_FIRMWARE_DIR=3D$BUILD_ROOT/QEMU =20 -if [[ ! -f `which build` || ! -f `which GenFv` ]]; +if ! command -v build || ! command -v GenFv; then # build the tools if they don't yet exist. Bin scheme echo Building tools as they are not in the path make -C $WORKSPACE/BaseTools -elif [[ ( -f `which build` || -f `which GenFv` ) && ! -d $EDK_TOOLS_PAT= H/Source/C/bin ]]; +elif [[ ( $(command -v build) || $(command -v GenFv) ) && ! -d $EDK_TOOLS_= PATH/Source/C/bin ]]; then # build the tools if they don't yet exist. BinWrapper scheme echo Building tools no $EDK_TOOLS_PATH/Source/C/bin directory --=20 2.22.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44273): https://edk2.groups.io/g/devel/message/44273 Mute This Topic: https://groups.io/mt/32579615/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-