From nobody Mon Feb 9 04:46:29 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+44170+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+44170+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1563836348; cv=none; d=zoho.com; s=zohoarc; b=KiaRz08gdC5SkX7aTV+30D1+CEqc5sEli2avbPOKxBylgi3exxjWUBPlgOHe6SbMfZ5IrnBb1Vtl+1aoUvyLi4AVy33yCM054FkfX6+IitHBun42YBUUaCTQoSsbGaIzrHHL6a8qqcZK+D0+150/dMaCCjo0gTa9YNstUD5m4yA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1563836348; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=rB4umKJTGZsM09VA2SJVU71F1XOOtJTj8YMwI2s8Mbw=; b=UwVFkZvhE3ZMIQFCrlxktKKlDlxcJMnsKSo7ONgVVNCZoAmP2vy547sb1GOV212D0nM8+xZyyN+J5d0jPcpe6HyPw/ZkgUK9/01PMZ7R9nnor8Wbrb60GajhMvaBpf1+js+KHlTLJyxO/LJqkhg1ykxuhZeVb4s4WXT+wfrGO8U= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+44170+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1563836348612313.0423637683076; Mon, 22 Jul 2019 15:59:08 -0700 (PDT) Return-Path: X-Received: from mga04.intel.com (mga04.intel.com []) by groups.io with SMTP; Mon, 22 Jul 2019 15:59:07 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Jul 2019 15:59:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,296,1559545200"; d="scan'208";a="169386511" X-Received: from mdkinney-mobl2.amr.corp.intel.com ([10.254.83.213]) by fmsmga008.fm.intel.com with ESMTP; 22 Jul 2019 15:59:07 -0700 From: "Michael D Kinney" To: devel@edk2.groups.io Cc: Zailiang Sun , Yi Qian , Gary Lin Subject: [edk2-devel] [edk2-platforms Patch V3 11/12] Vlv2TbltDevicePkg: Remove __GNUC__ specific #ifdefs Date: Mon, 22 Jul 2019 15:58:58 -0700 Message-Id: <20190722225859.24724-12-michael.d.kinney@intel.com> In-Reply-To: <20190722225859.24724-1-michael.d.kinney@intel.com> References: <20190722225859.24724-1-michael.d.kinney@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1563836348; bh=SWoo/yFH3dP2DWFjZ6PgEFTCGt6hPcToPoIFF4wLMAU=; h=Cc:Date:From:Reply-To:Subject:To; b=F6CZ8evX7Nl6kAEo2AGgJwT0lnDAFNWwVfD2y4Oxm/aD2VX5J2xLLg37aqnfanNHbgQ TZEEMdyFLqcaz4o4WA3M3/Oq2ts76a65QNjrT3KYShZbefNag+/xGg/vIFxP1o2Ax/DML GTvjt+ZQnK/sGzpWytghzSOQEikG7SEmJlA= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Remove #ifdefs for __GNUC__, so the builds are the same for GCC, VS20xx, and XCODE5. This resolves an XCODE5 build break for an unsupported pragma. Cc: Zailiang Sun Cc: Yi Qian Cc: Gary Lin Signed-off-by: Michael D Kinney --- .../AcpiPlatform/AcpiPlatform.c | 3 -- .../BoardClkGens/BoardClkGens.c | 8 ---- .../PlatformInitPei/CpuInitPeim.c | 12 ----- .../PlatformInitPei/PlatformEarlyInit.c | 46 ------------------- .../PlatformInitPei/PlatformEarlyInit.h | 6 --- 5 files changed, 75 deletions(-) diff --git a/Platform/Intel/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.c b= /Platform/Intel/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.c index 3e0b978120..37f899d7f5 100644 --- a/Platform/Intel/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.c +++ b/Platform/Intel/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.c @@ -51,9 +51,6 @@ CHAR16 gACPIOSFRRefDataBlockVariableName[] =3D ACPI_OS= FR_REF_DATA_BLOCK_VARIABL CHAR16 gACPIOSFRMfgStringVariableName[] =3D ACPI_OSFR_MFG_STRING_VARIAB= LE_NAME; =20 EFI_GLOBAL_NVS_AREA_PROTOCOL mGlobalNvsArea; -#ifndef __GNUC__ -#pragma optimize("", off) -#endif BOOLEAN mFirstNotify; EFI_PLATFORM_INFO_HOB *mPlatformInfo; EFI_GUID mSystemConfigurationGuid =3D SYSTEM_CONFIGURATIO= N_GUID; diff --git a/Platform/Intel/Vlv2TbltDevicePkg/Library/MultiPlatformLib/Boar= dClkGens/BoardClkGens.c b/Platform/Intel/Vlv2TbltDevicePkg/Library/MultiPla= tformLib/BoardClkGens/BoardClkGens.c index 4356f7b366..f00f10cfcc 100644 --- a/Platform/Intel/Vlv2TbltDevicePkg/Library/MultiPlatformLib/BoardClkGen= s/BoardClkGens.c +++ b/Platform/Intel/Vlv2TbltDevicePkg/Library/MultiPlatformLib/BoardClkGen= s/BoardClkGens.c @@ -12,10 +12,6 @@ #include #include =20 -#ifndef __GNUC__ -#pragma optimize( "", off ) -#endif - #define CLKGEN_EN 1 #define EFI_DEBUG 1 =20 @@ -415,7 +411,3 @@ InstallPlatformClocksNotify ( return EFI_SUCCESS; =20 } - -#ifndef __GNUC__ -#pragma optimize( "", on ) -#endif diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformInitPei/CpuInitPeim.c= b/Platform/Intel/Vlv2TbltDevicePkg/PlatformInitPei/CpuInitPeim.c index a3a3d5cbc9..d52c449318 100644 --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformInitPei/CpuInitPeim.c +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformInitPei/CpuInitPeim.c @@ -28,17 +28,5 @@ PlatformCpuInit ( IN EFI_PLATFORM_CPU_INFO *PlatformCpuInfo ) { - BOOLEAN ResetRequired; - - // - // Variable initialization - // - ResetRequired =3D FALSE; - - - if (ResetRequired) { - CpuOnlyReset(PeiServices); - } - return EFI_SUCCESS; } diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformInitPei/PlatformEarly= Init.c b/Platform/Intel/Vlv2TbltDevicePkg/PlatformInitPei/PlatformEarlyInit= .c index d3e62e3bd0..59845a69c4 100644 --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformInitPei/PlatformEarlyInit.c +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformInitPei/PlatformEarlyInit.c @@ -17,15 +17,6 @@ Abstract: =20 #include "PlatformEarlyInit.h" =20 -#ifdef __GNUC__ -#pragma GCC push_options -#pragma GCC optimize ("O0") -#else -#pragma optimize ("", off) -#endif - - - static EFI_PEI_STALL_PPI mStallPpi =3D { PEI_STALL_RESOLUTION, Stall @@ -963,40 +954,3 @@ PlatformEarlyInitEntry ( =20 return Status; } - -EFI_STATUS -EFIAPI -CpuOnlyReset ( - IN CONST EFI_PEI_SERVICES **PeiServices - ) -{ -// MsgBus32Write(CDV_UNIT_PUNIT, PUNIT_CPU_RST, 0x01) -#ifdef __GNUC__ - __asm__ - ( - "xorl %ecx, %ecx\n" - "1:hlt; hlt; hlt\n" - "jmp 1b\n" - ); -#else - _asm { - xor ecx, ecx - HltLoop: - hlt - hlt - hlt - loop HltLoop - } -#endif - // - // If we get here we need to mark it as a failure. - // - return EFI_UNSUPPORTED; -} - - -#ifdef __GNUC__ -#pragma GCC pop_options -#else -#pragma optimize ("", on) -#endif diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformInitPei/PlatformEarly= Init.h b/Platform/Intel/Vlv2TbltDevicePkg/PlatformInitPei/PlatformEarlyInit= .h index 8c02adba64..4c6b0795ec 100644 --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformInitPei/PlatformEarlyInit.h +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformInitPei/PlatformEarlyInit.h @@ -1375,12 +1375,6 @@ BOOLEAN IsA16Inverted ( ); =20 -EFI_STATUS -EFIAPI -CpuOnlyReset ( - IN CONST EFI_PEI_SERVICES **PeiServices - ); - EFI_STATUS EFIAPI InitLan ( --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44170): https://edk2.groups.io/g/devel/message/44170 Mute This Topic: https://groups.io/mt/32564737/1787277 Mute #ifdefs: https://groups.io/mk?hashtag=3Difdefs&subid=3D3901457 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-