From nobody Tue Feb 10 09:10:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+44110+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1563781854257651.5549567303235; Mon, 22 Jul 2019 00:50:54 -0700 (PDT) Return-Path: X-Received: from EUR04-VI1-obe.outbound.protection.outlook.com (EUR04-VI1-obe.outbound.protection.outlook.com [40.107.8.70]) by groups.io with SMTP; Mon, 22 Jul 2019 00:50:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JW5R18XY2m3QHnS6Gk08wKMItG3PVRguVZn+IkJm7K1sl6c8Hf2lFRVC1vd0s/4ZK3chmEaZnvZeqq+HEIUqd8OFqr4NcRUy85UvVotwQgKh+i74dxyEm8x+SHgbO8ZKj8XqKcP2caWhOOXZOcqS4cJSBtEKJzOn/jFxmxSkC+I9m+uRA7PwhwPnPX5+gJwGeSa4wzzOgER1wxCqi/zZJ1a8Rn2eA6qTQzEqqUb6FIQFpCVFQQr1SNhwoqBTHK4uQsluYI9tIIekckxTtEAkVBJoj9IJDoMXLk4agkDIafpoEWYZ7aeUALHbdknfkA4fCpBQs1zQcsSRAunM4uBE6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pqeUI6lEWWVY2bcb1WfAb/g/G1uqxCpRn+LGqqszclA=; b=A5elTsqDYW2l5YYQBgGAnMjmHdA05Vxrrp8OlGnRfivVf9Y0xBfHELjtHH4RpnF8U0LXBrA7f3/9mPiVTwrfECmwEhAUxuLIt3+4Zn777eN+XyRVDEDE96jpe0Y/jMKHLogMyko/+54N2yI+BGvF++Ra9B/Xbu5AKyMhV8Ktbndf8j7ZU7OJl5aJDri77r2Hvt/D/BNwV/ftg5ico68sgZForMBtTru1zuGjIPtLUPvQNsNS+GzXTMM7QjCij20cRxZCgfPCJb9YOyzJ4SHs0yGNj2wBRlyh6/F7SS9vv8AYWzqbQ6vpaaGSArWFyVN2x8GqidfxuXocUJ7wiygqeg== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=temperror (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com;dmarc=temperror action=none header.from=arm.com;dkim=none (message not signed);arc=none X-Received: from HE1PR0802CA0021.eurprd08.prod.outlook.com (2603:10a6:3:bd::31) by AM6PR08MB4951.eurprd08.prod.outlook.com (2603:10a6:20b:e1::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.16; Mon, 22 Jul 2019 07:50:49 +0000 X-Received: from DB5EUR03FT021.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e0a::205) by HE1PR0802CA0021.outlook.office365.com (2603:10a6:3:bd::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2094.14 via Frontend Transport; Mon, 22 Jul 2019 07:50:49 +0000 Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+44110+1787277+3901457@groups.io; helo=web01.groups.io; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) X-Received: from nebula.arm.com (40.67.248.234) by DB5EUR03FT021.mail.protection.outlook.com (10.152.20.238) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.2052.18 via Frontend Transport; Mon, 22 Jul 2019 07:50:47 +0000 X-Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1415.2; Mon, 22 Jul 2019 07:50:36 +0000 X-Received: from E119924.Arm.com (10.1.199.124) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.1415.2 via Frontend Transport; Mon, 22 Jul 2019 07:50:36 +0000 From: "Krzysztof Koch" To: CC: , , , , , Subject: [edk2-devel] [PATCH v2 3/6] ShellPkg: acpiview: RSDP: Make code consistent with other parsers Date: Mon, 22 Jul 2019 08:50:23 +0100 Message-ID: <20190722075026.20244-4-krzysztof.koch@arm.com> In-Reply-To: <20190722075026.20244-1-krzysztof.koch@arm.com> References: <20190722075026.20244-1-krzysztof.koch@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fc6348d5-dbd0-4cb1-821c-08d70e794f1d X-MS-TrafficTypeDiagnostic: AM6PR08MB4951: X-Microsoft-Antispam-PRVS: NoDisclaimer: True X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: 0lA6H6mfU7luXWXIwXlwvm3tTOGloDj1EI9Ie+LYhXPbn6g78UL2D3Uh3Mzt6f6ivi6TjR8L4z6uT0Y0QuLChg5Dr4Wib/GIcgCwlez47iFsI4OBv0Eqx2RjuX9IFCgxOWXRzk94yxo8F68iDjaqAPtRM3/Hpeo4EmvWkfYbJZGCNLe6VundEQAIwjAqmzEXR94/fluzktjGIrarZKyJLc5vmk21NHJJN90fyN53UfAmwi9werx73rLFez+rDu4q8EOnxdEzppYWl+TfROATVrHol0gY3H9jxBzfT+HLZOlHdumous7jmTO/XkXVPdhSwBleaNSgr0L2geZeEQeSVep9fuBwvsCiBu151XIu/haPjhjQc6V2cssSBM7fcGHBu35ZMgj9mqYzFOlVzdjLPfuXXTDj92lyv3L7DMR9nLU= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2019 07:50:47.7250 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fc6348d5-dbd0-4cb1-821c-08d70e794f1d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[40.67.248.234];Helo=[nebula.arm.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4951 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,krzysztof.koch@arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1563781853; bh=nWW8CQU8nhIN6pKmutbPRujCqeVyxnxN15wb6kAB4Rc=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=aN9DWbdGmvqI2OuRV1UU2rRuTmjI2H6dLg7iHcI9LvmR54s9yRPf3pOO8iSs2ishlmH AJOQBRB54+PJvuAq7u0eb763KAKmo1jdZdhAAnW+sfhvqX3ARIXyLFw9U3NwgL2b83pP2 sL9FZXwM9ueHdPa2Da+bUyxAkzsT44x2EgA= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" List ParseAcpi() function arguments one per line in order to make this function call consistent with ParseAcpi() calls in other ACPI table parsers. Also, notify the user that XsdtAddress value of 0 results in RSDP parsing being terminated and that the XSDT table will not be processed. This effectively means that no more ACPI tables will be parsed because of this RSDP table content error. Signed-off-by: Krzysztof Koch --- Notes: v1: - minor code style enhancements [Krzysztof] ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rsdp/RsdpParser.c | 1= 1 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rsdp/Rsdp= Parser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rsdp/RsdpPa= rser.c index 4bf928139a507d0b8f203ed0cbf0863cc2ec5de5..5a5c4b50c12e6eb0aa0efb1765d= f7e123f614da3 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rsdp/RsdpParser.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rsdp/RsdpParser.c @@ -129,7 +129,14 @@ ParseAcpiRsdp ( VerifyChecksum (TRUE, Ptr, AcpiTableLength); } =20 - ParseAcpi (Trace, 0, "RSDP", Ptr, AcpiTableLength, PARSER_PARAMS (RsdpPa= rser)); + ParseAcpi ( + Trace, + 0, + "RSDP", + Ptr, + AcpiTableLength, + PARSER_PARAMS (RsdpParser) + ); =20 // This code currently supports parsing of XSDT table only // and does not parse the RSDT table. Platforms provide the @@ -137,7 +144,7 @@ ParseAcpiRsdp ( // Therefore the RSDT should not be used on ARM platforms. if ((*XsdtAddress) =3D=3D 0) { IncrementErrorCount (); - Print (L"ERROR: XSDT Pointer is not set.\n"); + Print (L"ERROR: XSDT Pointer is not set. RSDP parsing aborted.\n"); return; } =20 -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#44110): https://edk2.groups.io/g/devel/message/44110 Mute This Topic: https://groups.io/mt/32556319/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-