From nobody Mon Apr 29 01:32:18 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+43853+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+43853+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1563350175; cv=none; d=zoho.com; s=zohoarc; b=hAjpJIpoIhf6UjuV7GmTeRi70WE6Tk9zZIFKZCHXg5IAfWbk4eZ+Nd7GQQEwCLHTWDry6/QAqMqgTjZuEXHI13kTw5amglNoB5wJqSyhb6xpxcpBff028SstY2BcKijwNSrba7ffWFgeyA324U8F4axXenFPkPJYTCAW+ILZo7s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1563350175; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=4/WZyFSrtwOAeInhzqFjzohH46DZbafhBqqt5fMSENs=; b=SXxhM3L0kRLHRLL6viYqE1nbHr4bvXJnPlK2bkw3WIumQqZG1xPcGO779b5FdTtOJOLOFimSAXjVKWbIAw2M+XHXLuZxzlvLcxAnwWfQDo5CgccWGwY8/gNUwzykpXL7x3q4s8qpmKI9zcSyVC1yYpJJWAat08sP1fRFlaQoRZU= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+43853+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1563350175566398.2218645475406; Wed, 17 Jul 2019 00:56:15 -0700 (PDT) Return-Path: X-Received: from mga02.intel.com (mga02.intel.com []) by groups.io with SMTP; Wed, 17 Jul 2019 00:56:14 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jul 2019 00:56:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,273,1559545200"; d="scan'208";a="187509075" X-Received: from fieedk001.ccr.corp.intel.com ([10.239.33.119]) by fmsmga001.fm.intel.com with ESMTP; 17 Jul 2019 00:56:12 -0700 From: "Gao, Zhichao" To: devel@edk2.groups.io Cc: Bret Barkelew , Jian J Wang , Hao A Wu , Ray Ni , Star Zeng , Liming gao , Sean Brogan , Michael Turner Subject: [edk2-devel] [PATCH 1/4] MdeModulePkg: Add PcdBootManagerInBootOrder to dec file Date: Wed, 17 Jul 2019 15:50:05 +0800 Message-Id: <20190717075008.22716-2-zhichao.gao@intel.com> In-Reply-To: <20190717075008.22716-1-zhichao.gao@intel.com> References: <20190717075008.22716-1-zhichao.gao@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhichao.gao@intel.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1563350175; bh=4Dr1m1K3YV/6T0bfxyyOUlXab+kPQEj+dcU60EafGNw=; h=Cc:Date:From:Reply-To:Subject:To; b=aUVsXoRwIC4WgXWTnJkXKURhSRwKuEL2PajtI97E6MIu6NuJkAJUGPGpgPek1biqbAL BDxR3hYx1Tphd8L42JwDsSFlyNmEeIGCBZE704ZMx3nq+dkVMJlf6mtprEujbiiuHQj8N KcZzsM1+Qq3rbRmkM0rGvJ8Z7e3DbfSeiW4= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1979 Add defination of PcdBootManagerInBootOrder to MdeModulePkg.dec. This pcd indicates if the Boot Manager should be in the Boot Order list. Cc: Jian J Wang Cc: Hao A Wu Cc: Ray Ni Cc: Star Zeng Cc: Liming gao Cc: Sean Brogan Cc: Michael Turner Cc: Bret Barkelew Signed-off-by: Zhichao Gao --- MdeModulePkg/MdeModulePkg.dec | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec index 12e0bbf579..839569aafd 100644 --- a/MdeModulePkg/MdeModulePkg.dec +++ b/MdeModulePkg/MdeModulePkg.dec @@ -1666,6 +1666,12 @@ # @Prompt Reset on memory type information change. gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|TRU= E|BOOLEAN|0x00010056 =20 + ## Indicates if the Boot Manager should be in the Boot Order list.
+ # TRUE - Add Boot Manager to boot order.
+ # FALSE - Does not add Boot Manager to boot order.
+ # @Prompt Store Boot Manager in BootOrder. + gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerInBootOrder|TRUE|BOOLEAN|0x= 00010077 + ## Indicates if the BDS supports Platform Recovery.

# TRUE - BDS supports Platform Recovery.
# FALSE - BDS does not support Platform Recovery.
--=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43853): https://edk2.groups.io/g/devel/message/43853 Mute This Topic: https://groups.io/mt/32501045/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 01:32:18 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+43854+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+43854+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1563350177; cv=none; d=zoho.com; s=zohoarc; b=L3v9paJ/O52MHj9VauYAT6xIUVD+uas+NTpsKipselCY8bjXWj0+K75S+wHaEP6Q+yOlLfbn/OXPNmCkz1awcG9DU4u3gJuvTYr7yne9wYtuvfkPM2quErMmEySZ8KjlwaZ1DnjUQwjkd/knRlHmJlrhjS01dQEonydRJpJiKuc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1563350177; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=G3O4sQzvGCttYCTXgJVyi6khHm3uCQMVwvDt1MQf0Gk=; b=CPJHoRTDsuJ7Pan+n3Vrbhus7iWA7dq2wnmXJjSBQNvokAsqU4tV6i4GF2PTGhO0uBGNj2gUm2Fqb+5ciFyW9vfyfCctCMRcdU0EsDBM3d/C1oHnnCEAcbySxYZNchvHDeK0FdctqLUjbJA1wG4gW3juHu+WS/PVS6SfzeeqLkc= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+43854+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 156335017765034.15217645565883; Wed, 17 Jul 2019 00:56:17 -0700 (PDT) Return-Path: X-Received: from mga02.intel.com (mga02.intel.com []) by groups.io with SMTP; Wed, 17 Jul 2019 00:56:16 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jul 2019 00:56:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,273,1559545200"; d="scan'208";a="187509080" X-Received: from fieedk001.ccr.corp.intel.com ([10.239.33.119]) by fmsmga001.fm.intel.com with ESMTP; 17 Jul 2019 00:56:14 -0700 From: "Gao, Zhichao" To: devel@edk2.groups.io Cc: Jian J Wang , Hao A Wu , Ray Ni , Star Zeng , Liming gao , Sean Brogan , Michael Turner , Bret Barkelew Subject: [edk2-devel] [PATCH 2/4] MdeModulePkg: Add prompt and help string for PcdBootManagerInBootOrder Date: Wed, 17 Jul 2019 15:50:06 +0800 Message-Id: <20190717075008.22716-3-zhichao.gao@intel.com> In-Reply-To: <20190717075008.22716-1-zhichao.gao@intel.com> References: <20190717075008.22716-1-zhichao.gao@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhichao.gao@intel.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1563350177; bh=sPeJRmU+8VBaUpIHzawEZnQWy5Hrdo7ScnbSMZ0wwBg=; h=Cc:Date:From:Reply-To:Subject:To; b=fsdFbduhl/gOj2+AO8GnSdlkzlUYbPSsqpUUFtb63j8koVn5k68bck2MXKE66aHM7VK fnbv6khiVlLwy773Z7XCQblwUiXU4tl5vdq2Clbm5cKsDGRZyQi77QC/JHkQCfPJqQyDR WHBvtlYA8E9VETPmLRbrJRI6LvCZ6Hpy5g0= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1979 Add prompt and help string for PcdBootManagerInBootOrder. Cc: Jian J Wang Cc: Hao A Wu Cc: Ray Ni Cc: Star Zeng Cc: Liming gao Cc: Sean Brogan Cc: Michael Turner Cc: Bret Barkelew Signed-off-by: Zhichao Gao --- MdeModulePkg/MdeModulePkg.uni | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/MdeModulePkg/MdeModulePkg.uni b/MdeModulePkg/MdeModulePkg.uni index 2bd1ad29f2..aa38ba1df3 100644 --- a/MdeModulePkg/MdeModulePkg.uni +++ b/MdeModulePkg/MdeModulePkg.uni @@ -445,6 +445,12 @@ = "TRUE - Resets system when memory type inform= ation changes.
\n" = "FALSE - Does not reset system when memory typ= e information changes.
" =20 +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdBootManagerInBootOrder_PROMP= T #language en-US "Store Boot Manager in BootOrder" + +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdBootManagerInBootOrder_HELP = #language en-US "Indicates if the Boot Manager should be in the Boot Order= list.

\n" + = "TRUE - Add Boot Manager to boot order.
" + = "FALSE - Does not add Boot Manager to boot order.
" + #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdPlatformRecoverySupport_PROM= PT #language en-US "Support Platform Recovery" =20 #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdPlatformRecoverySupport_HELP= #language en-US "Indicates if the BDS supports Platform Recovery.

= \n" --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43854): https://edk2.groups.io/g/devel/message/43854 Mute This Topic: https://groups.io/mt/32501046/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 01:32:18 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+43855+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+43855+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1563350187; cv=none; d=zoho.com; s=zohoarc; b=I6mOVg0TaPSUDab+H9N8JqFkDCL3vAhaKJiMoRtavBs/g7MdVokTwa9tGGUmP+0y/Msr+ll/BaXuvuuEKG9jpF0jl3AQ6ZjmzK2IIPq59cZ+rh1lyXlv0RYZDBuc0OYYIIwMtVU+J43bq6S4Awt8uPlOYjdjKFlMzOYg+h7SRHY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1563350187; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=oOX+D2+DsIUyhizBbPTzEcPy7X3duGInReUzUW7r/iI=; b=grnlSO3lpmBL0rb83uR4CQxJWUXEgPOWV899VU/5ISv5t/CLQlOHllr6Aux5+KXA7SH4VE5/UTwfZIJvXiWI85riiNN9srHsyqJGXCbJRLCQKHn6rxARKS7jDfx1KxIYTbp+doE6MifwroTy7ku5A0Q37uiQG0Dunb5AsyqFjtQ= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+43855+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1563350187895424.4105887443644; Wed, 17 Jul 2019 00:56:27 -0700 (PDT) Return-Path: X-Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by groups.io with SMTP; Wed, 17 Jul 2019 00:56:27 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jul 2019 00:56:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,273,1559545200"; d="scan'208";a="187509110" X-Received: from fieedk001.ccr.corp.intel.com ([10.239.33.119]) by fmsmga001.fm.intel.com with ESMTP; 17 Jul 2019 00:56:16 -0700 From: "Gao, Zhichao" To: devel@edk2.groups.io Cc: Bret Barkelew , Jian J Wang , Hao A Wu , Ray Ni , Star Zeng , Liming gao , Sean Brogan , Michael Turner Subject: [edk2-devel] [PATCH 3/4] MdeModulePkg: Use pcd to control if BootManager in BootOrder Date: Wed, 17 Jul 2019 15:50:07 +0800 Message-Id: <20190717075008.22716-4-zhichao.gao@intel.com> In-Reply-To: <20190717075008.22716-1-zhichao.gao@intel.com> References: <20190717075008.22716-1-zhichao.gao@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhichao.gao@intel.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1563350187; bh=W+iUFwxhzsVDnOzSwbrAXmFX3suApZMlDd8BqeDJe8I=; h=Cc:Date:From:Reply-To:Subject:To; b=HXI8tZoz9XOBPgJ2qjysXSt52OcsWJn4vFJf8H4rRuIBP1zF+DcucV/l+PU1ma+B040 CcKsI7Z+PICZqPg9w7HO/5I2r6S2CCoX1qCXWOaY+wMFfjLnZlpCeycFmWt0DeHnNY5eH f++ztzV+B73/SPeAGvXyseWoQzKXW7dHZOY= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1979 Use pcd PcdBootManagerInBootOrder to control whether BootManager is in BootOrder. Also add EFI_UNSUPPORTED to indicate the BootManager is not in the BootOrder. Cc: Jian J Wang Cc: Hao A Wu Cc: Ray Ni Cc: Star Zeng Cc: Liming gao Cc: Sean Brogan Cc: Michael Turner Cc: Bret Barkelew Signed-off-by: Zhichao Gao --- .../Library/UefiBootManagerLib/BmBoot.c | 20 +++++++++++++------ .../UefiBootManagerLib/UefiBootManagerLib.inf | 1 + 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c b/MdeModulePk= g/Library/UefiBootManagerLib/BmBoot.c index 952033fc82..611acb91e2 100644 --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c @@ -2320,11 +2320,13 @@ EfiBootManagerRefreshAllBootOption ( =20 @param BootOption Return the boot option of the Boot Manager Menu =20 - @retval EFI_SUCCESS Successfully register the Boot Manager Menu. - @retval EFI_NOT_FOUND The Boot Manager Menu cannot be found. - @retval others Return status of gRT->SetVariable (). BootOption s= till points - to the Boot Manager Menu even the Status is not EF= I_SUCCESS - and EFI_NOT_FOUND. + @retval EFI_SUCCESS Successfully register the Boot Manager Menu. + @retval EFI_NOT_FOUND The Boot Manager Menu cannot be found. + @retval EFI_UNSUPPORTED The Boot Manager Menu isn't register to Boot O= rder because of + PcdBootManagerInBootOrder. + @retval others Return status of gRT->SetVariable (). BootOpti= on still points + to the Boot Manager Menu even the Status is no= t EFI_SUCCESS + and EFI_NOT_FOUND. **/ EFI_STATUS BmRegisterBootManagerMenu ( @@ -2436,7 +2438,13 @@ BmRegisterBootManagerMenu ( EfiBootManagerFreeLoadOptions (BootOptions, BootOptionCount); ); =20 - return EfiBootManagerAddLoadOptionVariable (BootOption, 0); + if (PcdGetBool (PcdBootManagerInBootOrder)) { + Status =3D EfiBootManagerAddLoadOptionVariable (BootOption, 0); + } else { + Status =3D EFI_UNSUPPORTED; + } + + return Status; } =20 /** diff --git a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf= b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf index ed6b4679eb..cfc01f57c6 100644 --- a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf +++ b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf @@ -116,3 +116,4 @@ gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile = ## CONSUMES gEfiMdeModulePkgTokenSpaceGuid.PcdDriverHealthConfigureForm = ## SOMETIMES_CONSUMES gEfiMdeModulePkgTokenSpaceGuid.PcdMaxRepairCount = ## CONSUMES + gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerInBootOrder = ## CONSUMES --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43855): https://edk2.groups.io/g/devel/message/43855 Mute This Topic: https://groups.io/mt/32501047/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 01:32:18 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+43856+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+43856+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1563350193; cv=none; d=zoho.com; s=zohoarc; b=cUqinVK3lT5bstvV0PEk1igKWie2Tkk58SF8WIttZWSEeqxtHApwA4Ektrs5WAMtHBj38L3uaQDYZ/NKiuXN9k+ordWwOc/zrqJF4VOvelr22TLd3ui3m5YdLl1tLlE3mqJNoDaRp1z01uvh3zptXKIIHewGZqRw/lKrT9CFK2k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1563350193; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=E4o39dIoXlwVrjWKDsB5kO3jtzwIA+57eYXjrtRDpxo=; b=Xh35z6DQU3uJI2F7wNltWXNI649ZXiGSMvAEynmqPmWjBnVw5HDQ8qC+/S8c03x70qbqA8sDdeNjvv5Nl4rxSaPpK9lnbTcRDLy8tG9PMnNjd8EPgbZNwJecWZJ4L/+SAlFW8TJJ/Zk8MTgP4WqzH9gAxeJW5KUIhG85uyeS0sw= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+43856+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1563350193116868.3150421436458; Wed, 17 Jul 2019 00:56:33 -0700 (PDT) Return-Path: X-Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by groups.io with SMTP; Wed, 17 Jul 2019 00:56:32 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jul 2019 00:56:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,273,1559545200"; d="scan'208";a="187509130" X-Received: from fieedk001.ccr.corp.intel.com ([10.239.33.119]) by fmsmga001.fm.intel.com with ESMTP; 17 Jul 2019 00:56:27 -0700 From: "Gao, Zhichao" To: devel@edk2.groups.io Cc: Jian J Wang , Hao A Wu , Ray Ni , Star Zeng , Liming gao , Sean Brogan , Michael Turner , Bret Barkelew Subject: [edk2-devel] [PATCH 4/4] MdeModulePkg: PcdBootManagerInBootOrder should only affect BootOrder Date: Wed, 17 Jul 2019 15:50:08 +0800 Message-Id: <20190717075008.22716-5-zhichao.gao@intel.com> In-Reply-To: <20190717075008.22716-1-zhichao.gao@intel.com> References: <20190717075008.22716-1-zhichao.gao@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhichao.gao@intel.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1563350192; bh=Odi/6Wk6ExsplCNv1Ky23qFO3PfxO4H5w0DolO5NdTA=; h=Cc:Date:From:Reply-To:Subject:To; b=FrPXUMMIuqJVKx4xIWUjMsB3pt4/W1FyPFVnn6LFZ/p3N6NSW3zuik8a9x0Z4QHnMwZ 8g3wlwMEnZ+hvi7VX8xB9a/7j6MqA+/h1ajbI0UD8ybHevJCf7vQnXO3kCN8uJ9J+VkZ5 2J5y7GmNB69akeMhrE2btVX7Q0Ras+gnHNE= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1979 The PcdBootManagerInBootOrder should only control whether BootManager is in BootOrder. It shouldn't affect the Hotkey service with BootManager. Acctually, setting this pcd hides the boot option from BootOrder. But it didn't disable the boot option. Cc: Jian J Wang Cc: Hao A Wu Cc: Ray Ni Cc: Star Zeng Cc: Liming gao Cc: Sean Brogan Cc: Michael Turner Cc: Bret Barkelew Signed-off-by: Zhichao Gao --- MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c b/MdeModulePk= g/Library/UefiBootManagerLib/BmBoot.c index 611acb91e2..8bdac924b4 100644 --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c @@ -2322,8 +2322,6 @@ EfiBootManagerRefreshAllBootOption ( =20 @retval EFI_SUCCESS Successfully register the Boot Manager Menu. @retval EFI_NOT_FOUND The Boot Manager Menu cannot be found. - @retval EFI_UNSUPPORTED The Boot Manager Menu isn't register to Boot O= rder because of - PcdBootManagerInBootOrder. @retval others Return status of gRT->SetVariable (). BootOpti= on still points to the Boot Manager Menu even the Status is no= t EFI_SUCCESS and EFI_NOT_FOUND. @@ -2344,6 +2342,7 @@ BmRegisterBootManagerMenu ( UINTN Index; VOID *Data; UINTN DataSize; + UINT16 OptionNumber; =20 DevicePath =3D NULL; Description =3D NULL; @@ -2441,7 +2440,17 @@ BmRegisterBootManagerMenu ( if (PcdGetBool (PcdBootManagerInBootOrder)) { Status =3D EfiBootManagerAddLoadOptionVariable (BootOption, 0); } else { - Status =3D EFI_UNSUPPORTED; + // + // Get the free option number if the option number is unassigned + // + if (BootOption->OptionNumber =3D=3D LoadOptionNumberUnassigned) { + Status =3D BmGetFreeOptionNumber (BootOption->OptionType, &OptionNum= ber); + if (EFI_ERROR (Status)) { + return Status; + } + BootOption->OptionNumber =3D OptionNumber; + } + Status =3D EfiBootManagerLoadOptionToVariable (BootOption); } =20 return Status; --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43856): https://edk2.groups.io/g/devel/message/43856 Mute This Topic: https://groups.io/mt/32501048/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-