From nobody Sat Feb 7 09:46:38 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+43539+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+43539+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1562809492; cv=none; d=zoho.com; s=zohoarc; b=YdrFwtwVvDdbS45R4QjnpyEIl1NW7O8bDhiXjmXD9hCVlxtdh5YoAZYNjivNUifFBZMNBP8jZwuc/ZV+A/JmYZb7rkZUbOWOhh467oXeLUOktK6qn5oeDWKK/BeSvfDy5QASYSlGzdB3v8R8Hft25CZ95/q/xKROBjZASx/xMBQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562809492; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=RaLV8EHBszONn0GSQOe1Z/BhreV7/qOLkHv1LgTY8jM=; b=gYxapHh6qGD5ot9R0frWk7ZvVpZlLdbIysy4ACBmELgLr+VLzR7hLgProbuzAVnLO1H3RqxCnwPkzr1JK3C5EfkybKGCYPbT8/qrDxAgcxyYgC091oCq9XV1jG7AoD5HXpLAqMw8O2aH3OYVuvjs4HT1yhRazyUoijzaqds+qHE= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+43539+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1562809492783463.1332931580256; Wed, 10 Jul 2019 18:44:52 -0700 (PDT) Return-Path: X-Received: from mga17.intel.com (mga17.intel.com []) by groups.io with SMTP; Wed, 10 Jul 2019 18:44:51 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jul 2019 18:44:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,476,1557212400"; d="scan'208";a="177020041" X-Received: from unknown (HELO lgao4-MOBL1.ccr.corp.intel.com) ([10.239.197.238]) by orsmga002.jf.intel.com with ESMTP; 10 Jul 2019 18:44:50 -0700 From: "Liming Gao" To: devel@edk2.groups.io Cc: Leif Lindholm , Feng Bob C Subject: [edk2-devel] [Patch 3/7] Revert "BaseTools/FMMT: Change FMMT script type in PosixLike" Date: Thu, 11 Jul 2019 09:44:36 +0800 Message-Id: <20190711014440.19812-4-liming.gao@intel.com> In-Reply-To: <20190711014440.19812-1-liming.gao@intel.com> References: <20190711014440.19812-1-liming.gao@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,liming.gao@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1562809492; bh=neftUa4/qAaA6FzhAwzhrKASy/ocaR46CyGacGs5QJA=; h=Cc:Date:From:Reply-To:Subject:To; b=d1n7HxJw+C6V/W2UpREJ+zeXpvV387Wv6Bsey87bvhIIbKui96rosOZzWUEe/bjltRN 6eh0cIWpvCgWXVz4p3KIr2wrkgmfkylRWYfOwbpxMak+pgVOUlUwb9yHRMRfTJba5BasV 7e+OfufZknwRER6Vj0+o90Ty9KnlSGdaBI0= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This reverts commit 2112fc71b1112554bcfb75a454002d2bbeed552f. There are the concerns on code design and code quality, and request to rewrite FCE, BfmLib and FMMT for the review. Cc: Leif Lindholm Cc: Feng Bob C Signed-off-by: Liming Gao --- BaseTools/BinWrappers/PosixLike/FMMT | 58 ++++++++++++++++++--------------= ---- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/BaseTools/BinWrappers/PosixLike/FMMT b/BaseTools/BinWrappers/P= osixLike/FMMT index 0945d86d92..a244ecc095 100755 --- a/BaseTools/BinWrappers/PosixLike/FMMT +++ b/BaseTools/BinWrappers/PosixLike/FMMT @@ -1,29 +1,29 @@ -#!/usr/bin/env bash - -full_cmd=3D${BASH_SOURCE:-$0} # see http://mywiki.wooledge.org/BashFAQ/028= for a discussion of why $0 is not a good choice here -dir=3D$(dirname "$full_cmd") -cmd=3D${full_cmd##*/} - -if [ -n "$WORKSPACE" ] && [ -e "$WORKSPACE/Conf/BaseToolsCBinaries" ] -then - exec "$WORKSPACE/Conf/BaseToolsCBinaries/$cmd" -elif [ -n "$WORKSPACE" ] && [ -e "$EDK_TOOLS_PATH/Source/C" ] -then - if [ ! -e "$EDK_TOOLS_PATH/Source/C/bin/$cmd" ] - then - echo "BaseTools C Tool binary was not found ($cmd)" - echo "You may need to run:" - echo " make -C $EDK_TOOLS_PATH/Source/C" - else - exec "$EDK_TOOLS_PATH/Source/C/bin/$cmd" "$@" - fi -elif [ -e "$dir/../../Source/C/bin/$cmd" ] -then - exec "$dir/../../Source/C/bin/$cmd" "$@" -else - echo "Unable to find the real '$cmd' to run" - echo "This message was printed by" - echo " $0" - exit 127 -fi - +#!/usr/bin/env bash + +full_cmd=3D${BASH_SOURCE:-$0} # see http://mywiki.wooledge.org/BashFAQ/028= for a discussion of why $0 is not a good choice here +dir=3D$(dirname "$full_cmd") +cmd=3D${full_cmd##*/} + +if [ -n "$WORKSPACE" ] && [ -e "$WORKSPACE/Conf/BaseToolsCBinaries" ] +then + exec "$WORKSPACE/Conf/BaseToolsCBinaries/$cmd" +elif [ -n "$WORKSPACE" ] && [ -e "$EDK_TOOLS_PATH/Source/C" ] +then + if [ ! -e "$EDK_TOOLS_PATH/Source/C/bin/$cmd" ] + then + echo "BaseTools C Tool binary was not found ($cmd)" + echo "You may need to run:" + echo " make -C $EDK_TOOLS_PATH/Source/C" + else + exec "$EDK_TOOLS_PATH/Source/C/bin/$cmd" "$@" + fi +elif [ -e "$dir/../../Source/C/bin/$cmd" ] +then + exec "$dir/../../Source/C/bin/$cmd" "$@" +else + echo "Unable to find the real '$cmd' to run" + echo "This message was printed by" + echo " $0" + exit 127 +fi + --=20 2.13.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43539): https://edk2.groups.io/g/devel/message/43539 Mute This Topic: https://groups.io/mt/32423090/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-