From nobody Wed Apr 24 17:22:38 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+43521+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+43521+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1562785525; cv=none; d=zoho.com; s=zohoarc; b=mFY+g6+fpPsl/u9O3gbhqSP2RlMDzTWFYEThs8QWVKoTgpngP+JFizVx7PJkKqm/JAj+V9eA1ZejF9soVCPR/mULkuQ67KdXb4HxyrQnxOqlfnHyY3BSioS+KaHU4K2ssdZMHW1mW9VcKrxhDGmwdarnYqZAES728SJcj14LB2o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562785525; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=44nBq7d0MNSgjZG8FeruXDGaxS8mMMni6YhumpWiyCI=; b=jPjuT++MhRa/kR6etOfLNs6pwkvWwM+V68nV/D/I5r3fL8f5Rlf2nroe12BnvpPrGILK1r1EiD/2rLwns01Po6kN3gDKfsxt63cxRS43APpIw059DHkTg8OaR6QrZtPzI3QpLmqyJE29xR9EZ/qN4mOR2JiB0cnVo4fmK3LpYO8= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+43521+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1562785525023487.4359031470417; Wed, 10 Jul 2019 12:05:25 -0700 (PDT) Return-Path: X-Received: from mga02.intel.com (mga02.intel.com []) by groups.io with SMTP; Wed, 10 Jul 2019 12:05:23 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jul 2019 12:05:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,475,1557212400"; d="scan'208";a="171008229" X-Received: from mdkinney-mobl2.amr.corp.intel.com ([10.241.98.74]) by orsmga006.jf.intel.com with ESMTP; 10 Jul 2019 12:05:21 -0700 From: "Michael D Kinney" To: devel@edk2.groups.io Cc: Zailiang Sun , Yi Qian , Gary Lin Subject: [edk2-devel] [edk2-platforms Patch 25/28] Vlv2DeviceRefCodePlg/AcpiTablesPCAT: Fix ASL error Date: Wed, 10 Jul 2019 12:05:13 -0700 Message-Id: <20190710190516.6012-26-michael.d.kinney@intel.com> In-Reply-To: <20190710190516.6012-1-michael.d.kinney@intel.com> References: <20190710190516.6012-1-michael.d.kinney@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1562785524; bh=DC2htE/in+SHMFlTINDsWgB/JsSIiQVhhJ6q4wB9XJI=; h=Cc:Date:From:Reply-To:Subject:To; b=Mdom7OQjofpDEb+NKrUPyZzcBpD4NttwXPiFyg9svH9zNEM8MNp37aLSHlkmv6qoInp kNenS4oyFT5I0fWiVGKDh9bGDDQ0UOCZTaUREFiAyWUOu3oxAOsr9U6eGzIoKHvl8tu+6 zfXOFaiWHPAiIf0iZ6w8VSxY/tOkMEAAkl4= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Remove use of a method to read a register from a BAR and instead access the register directly. Resolves the following error from the latest iasl compiler. Or(ShiftLeft(Derefof(Index(CDCT, \_SB.PCI0.GFX0.MCHK.DCFE)), 21),PARM, PA= RM) Error 6163 - Object is created temporarily in another method and cannot be accessed ^ (\_SB.PCI0.GFX0.MCHK.DCFE) Cc: Zailiang Sun Cc: Yi Qian Cc: Gary Lin Signed-off-by: Michael D Kinney Reviewed-By: Zailiang Sun --- .../AcpiTablesPCAT/IgdOGBDA.ASL | 14 ++++++++++++-- .../AcpiTablesPCAT/IgdOpRn.ASL | 18 +----------------- 2 files changed, 13 insertions(+), 19 deletions(-) diff --git a/Silicon/Intel/Vlv2DeviceRefCodePkg/AcpiTablesPCAT/IgdOGBDA.ASL= b/Silicon/Intel/Vlv2DeviceRefCodePkg/AcpiTablesPCAT/IgdOGBDA.ASL index 4482db6906..379fca7379 100644 --- a/Silicon/Intel/Vlv2DeviceRefCodePkg/AcpiTablesPCAT/IgdOGBDA.ASL +++ b/Silicon/Intel/Vlv2DeviceRefCodePkg/AcpiTablesPCAT/IgdOGBDA.ASL @@ -1,6 +1,6 @@ /*++ =20 -Copyright (c) 1999 - 2014, Intel Corporation. All rights reserved +Copyright (c) 1999 - 2019, Intel Corporation. All rights reserved =20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -125,7 +125,17 @@ Method (GBDA, 0, Serialized) =20 // Report the graphics frequency based on DISPLAY_CLOCK_FREQUENCY_ENCO= DING [MMADR+0x20C8] =20 - Or(ShiftLeft(Derefof(Index(CDCT, \_SB.PCI0.GFX0.MCHK.DCFE)), 21),PARM,= PARM) + If (LNotEqual (MADR, 0xFFFFFFFF)) + { + OperationRegion(IGMM,SystemMemory,MADR,0x3000) + Field(IGMM,AnyAcc, NoLock, Preserve) + { + Offset(0X20C8), + , 4, + DCFE, 4, // DISPLAY_CLOCK_FREQUENCY_ENCOD= ING + } + Or(ShiftLeft(Derefof(Index(CDCT, DCFE)), 21),PARM, PARM) + } =20 Store(1, GESF) // Set the modified settings flag Return(SUCC) diff --git a/Silicon/Intel/Vlv2DeviceRefCodePkg/AcpiTablesPCAT/IgdOpRn.ASL = b/Silicon/Intel/Vlv2DeviceRefCodePkg/AcpiTablesPCAT/IgdOpRn.ASL index 8575fbfe6c..386ad3e65e 100644 --- a/Silicon/Intel/Vlv2DeviceRefCodePkg/AcpiTablesPCAT/IgdOpRn.ASL +++ b/Silicon/Intel/Vlv2DeviceRefCodePkg/AcpiTablesPCAT/IgdOpRn.ASL @@ -1,6 +1,6 @@ /*++ =20 -Copyright (c) 1999 - 2014, Intel Corporation. All rights reserved +Copyright (c) 1999 - 2019, Intel Corporation. All rights reserved =20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -70,22 +70,6 @@ Field(IGDP, AnyAcc, NoLock, Preserve) ASLS, 32, // Reg 0xFC, Address of the IGD OpRegion } =20 -Method (MCHK, 0, Serialized) -{ - - If (LNotEqual (MADR, 0xFFFFFFFF)) - { - OperationRegion(IGMM,SystemMemory,MADR,0x3000) - Field(IGMM,AnyAcc, NoLock, Preserve) - { - Offset(0X20C8), - , 4, - DCFE, 4, // DISPLAY_CLOCK_FREQUENCY_ENCODING - } - } -} - - // Define an OperationRegion to cover the IGD OpRegion layout. =20 OperationRegion(IGDM, SystemMemory, ASLB, 0x2000) --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43521): https://edk2.groups.io/g/devel/message/43521 Mute This Topic: https://groups.io/mt/32419754/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-