From nobody Mon Feb 9 10:28:52 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+43508+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+43508+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1562785523; cv=none; d=zoho.com; s=zohoarc; b=YeoWt9uF03Y1SxMxtEUiWLHjShtF5X+1kW45ojL2BumpQ2N7pyQx/KOZPkZ/cnatgRFko5Sju1lmCDyVUtgTumU5Ha8ftzi6SaKQ7SnDKJQXjQncjeS7pfm2HUWnbVdFJjp18cDwe0TRDCzXC9BdCHZWcHV9wZ0fyaE5VYWESHw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562785523; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=53Z9JRahAbvVlTQSMb1+YcAEXSEIJdsd/Gxwj/XlxOE=; b=FwY1IsoDoKTCMIz1eIn+z46GxfDW96BtoshgmJysIvpJD5GylRJg40DRd4g8aamyh/vBxIMuX3du6RGhAOLvDgnG0ffGKH9H/E4fGhctne/XILdMkuCD+A9nezYlq+EactOD3JXW4NoBfUILz4cuj6p9YN2aeGcPC5gPfT4Vta8= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+43508+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1562785523175544.4305123061301; Wed, 10 Jul 2019 12:05:23 -0700 (PDT) Return-Path: X-Received: from mga17.intel.com (mga17.intel.com []) by groups.io with SMTP; Wed, 10 Jul 2019 12:05:21 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jul 2019 12:05:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,475,1557212400"; d="scan'208";a="171008199" X-Received: from mdkinney-mobl2.amr.corp.intel.com ([10.241.98.74]) by orsmga006.jf.intel.com with ESMTP; 10 Jul 2019 12:05:20 -0700 From: "Michael D Kinney" To: devel@edk2.groups.io Cc: Zailiang Sun , Yi Qian , Gary Lin Subject: [edk2-devel] [edk2-platforms Patch 17/28] Vlvt2TbltDevicePkg: Fix NULL pointer access in SmbiosMiscDxe Date: Wed, 10 Jul 2019 12:05:05 -0700 Message-Id: <20190710190516.6012-18-michael.d.kinney@intel.com> In-Reply-To: <20190710190516.6012-1-michael.d.kinney@intel.com> References: <20190710190516.6012-1-michael.d.kinney@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1562785522; bh=oq2azuM6b+9GA8Vrnc6oGasYCkoZ1EaMQhlZwttAPT4=; h=Cc:Date:From:Reply-To:Subject:To; b=RiiYpnggUhDAj0ev8Tj7KPkCLi5/yKyuACk57g39toQ8mRgwS++y2MD2p0sf9g2sUE2 qWfeWto8XimdulCxzavStUQnCAec/NtpPIHm0TCZ3dkz6b6Yref49Mb5+RzU80UkXxGc1 Yerz8QsNGSNv4P4MP213zceMXFGMJJ/d/6w= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Handle case where no Simple Network Protocols are found. Cc: Zailiang Sun Cc: Yi Qian Cc: Gary Lin Signed-off-by: Michael D Kinney Reviewed-By: Zailiang Sun --- .../MiscBaseBoardManufacturerFunction.c | 14 +++++++++----- .../SmBiosMiscDxe/MiscSystemManufacturerFunction.c | 14 +++++++++----- 2 files changed, 18 insertions(+), 10 deletions(-) diff --git a/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscBaseBoardMa= nufacturerFunction.c b/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscB= aseBoardManufacturerFunction.c index 4e02486853..8eddc5c2a6 100644 --- a/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscBaseBoardManufactu= rerFunction.c +++ b/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscBaseBoardManufactu= rerFunction.c @@ -130,11 +130,15 @@ MISC_SMBIOS_TABLE_FUNCTION(MiscBaseBoardManufacturer) // //Get the MAC string // - Status =3D NetLibGetMacString ( - *Handles, - NULL, - &MacStr - ); + if (Handles =3D=3D NULL) { + Status =3D EFI_NOT_FOUND; + } else { + Status =3D NetLibGetMacString ( + *Handles, + NULL, + &MacStr + ); + } if (EFI_ERROR (Status)) {=09 MacStr =3D L"000000000000"; } diff --git a/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscSystemManuf= acturerFunction.c b/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscSyst= emManufacturerFunction.c index da660cb3a8..b18dbd6ae2 100644 --- a/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscSystemManufacturer= Function.c +++ b/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscSystemManufacturer= Function.c @@ -212,11 +212,15 @@ AddSmbiosManuCallback ( // //Get the MAC string // - Status =3D NetLibGetMacString ( - *Handles, - NULL, - &MacStr - ); + if (Handles =3D=3D NULL) { + Status =3D EFI_NOT_FOUND; + } else { + Status =3D NetLibGetMacString ( + *Handles, + NULL, + &MacStr + ); + } if (EFI_ERROR (Status)) { MacStr =3D L"000000000000"; } --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43508): https://edk2.groups.io/g/devel/message/43508 Mute This Topic: https://groups.io/mt/32419741/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-