From nobody Tue Apr 16 06:31:40 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+43502+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+43502+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1562785522; cv=none; d=zoho.com; s=zohoarc; b=bzm3zWOwA7stJey+09tQtm7YZQGPVsLmylkoTKIdzvdfUYxN9cNtLqZCg9QRZEK8REiD+fXCjqFM6t8WdOQsPZ7eXoH8uahE5j+8sJ16IKajrYbtc4nKckh93npCR2IWWpMfk4W/bBWo2i/NCRbO8/uvVg48Zm8Ky561s/yR1RE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562785522; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=RBbkZN8uhAPfvCmgoNyogk91y3WUSKp675ZoXIJIark=; b=kCT52DRAwkP/E92kQrP9KIeJ+sDjP9QTHy20UeuBW7pJga6QsoSw+ZX5QkcX8C/ZASbjk3sMDfOwC1FrGtfLfx9tL1bbFtJ/cj199hPzu//n2m20e9RBBZKaE29jQ1U6StBVH4E4OxKLuu6AscndE66WYSCxTHgpQBAhX4MEBUE= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+43502+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1562785522388660.467814422537; Wed, 10 Jul 2019 12:05:22 -0700 (PDT) Return-Path: X-Received: from mga17.intel.com (mga17.intel.com []) by groups.io with SMTP; Wed, 10 Jul 2019 12:05:21 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jul 2019 12:05:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,475,1557212400"; d="scan'208";a="171008189" X-Received: from mdkinney-mobl2.amr.corp.intel.com ([10.241.98.74]) by orsmga006.jf.intel.com with ESMTP; 10 Jul 2019 12:05:20 -0700 From: "Michael D Kinney" To: devel@edk2.groups.io Cc: Gary Lin , Zailiang Sun , Yi Qian Subject: [edk2-devel] [edk2-platforms Patch 14/28] Vlv2TbltDevicePkg/SmBiosMiscDxe: Fix the indentation Date: Wed, 10 Jul 2019 12:05:02 -0700 Message-Id: <20190710190516.6012-15-michael.d.kinney@intel.com> In-Reply-To: <20190710190516.6012-1-michael.d.kinney@intel.com> References: <20190710190516.6012-1-michael.d.kinney@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1562785521; bh=OeAEN1vv1wi16PAu6E/hIBXPG0uPpaU3z7tb1HMSwn0=; h=Cc:Date:From:Reply-To:Subject:To; b=cSCbpmBdcER/BZqleRkhF32Vj59g/ZoInU+vfL6N80l/4G3PXVfBAKhXQN0nxK9Ns0h 3NNDCVkyiCPLwz0D2hgqKJ326nAXc5wfFSK9YQLwUw89kBk0hgIJm1D2Po9WrWSCp4AsX ktTz0EizCLS05BebaM65WB0JjaXD40NSLe0= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" From: Gary Lin Fix the indentation of MiscSystemManufacturerFunction.c to improve the readability. Cc: Zailiang Sun Cc: Yi Qian Cc: Michael D Kinney Signed-off-by: Gary Lin Reviewed-By: Zailiang Sun --- .../MiscSystemManufacturerFunction.c | 51 +++++++++---------- 1 file changed, 24 insertions(+), 27 deletions(-) diff --git a/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscSystemManuf= acturerFunction.c b/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscSyst= emManufacturerFunction.c index f537e0db76..da660cb3a8 100644 --- a/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscSystemManufacturer= Function.c +++ b/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscSystemManufacturer= Function.c @@ -52,14 +52,14 @@ AddSmbiosManuCallback ( UINTN PdNameStrLen; UINTN SerialNumStrLen; UINTN SkuNumberStrLen; - UINTN FamilyNameStrLen; + UINTN FamilyNameStrLen; EFI_STATUS Status; EFI_STRING Manufacturer; EFI_STRING ProductName; EFI_STRING Version; EFI_STRING SerialNumber; EFI_STRING SkuNumber; - EFI_STRING FamilyName; + EFI_STRING FamilyName; STRING_REF TokenToGet; EFI_SMBIOS_HANDLE SmbiosHandle; SMBIOS_TABLE_TYPE1 *SmbiosRecord; @@ -323,40 +323,37 @@ MISC_SMBIOS_TABLE_FUNCTION(MiscSystemManufacturer) { EFI_STATUS Status; static BOOLEAN CallbackIsInstalledManu =3D FALSE; - VOID *AddSmbiosManuCallbackNotifyReg; - EFI_EVENT AddSmbiosManuCallbackEvent; + VOID *AddSmbiosManuCallbackNotifyReg; + EFI_EVENT AddSmbiosManuCallbackEvent; =20 =20 if (CallbackIsInstalledManu =3D=3D FALSE) { CallbackIsInstalledManu =3D TRUE; // Prevent more than 1 callb= ack. DEBUG ((EFI_D_INFO, "Create Smbios Manu callback.\n")); =20 - // - // gEfiDxeSmmReadyToLockProtocolGuid is ready - // - Status =3D gBS->CreateEvent ( - EVT_NOTIFY_SIGNAL, - TPL_CALLBACK, - (EFI_EVENT_NOTIFY)AddSmbiosManuCallback, - RecordData, - &AddSmbiosManuCallbackEvent - ); + // + // gEfiDxeSmmReadyToLockProtocolGuid is ready + // + Status =3D gBS->CreateEvent ( + EVT_NOTIFY_SIGNAL, + TPL_CALLBACK, + (EFI_EVENT_NOTIFY)AddSmbiosManuCallback, + RecordData, + &AddSmbiosManuCallbackEvent + ); =20 - ASSERT_EFI_ERROR (Status); - if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + if (EFI_ERROR (Status)) { + return Status; + } + + Status =3D gBS->RegisterProtocolNotify ( + &gEfiDxeSmmReadyToLockProtocolGuid, + AddSmbiosManuCallbackEvent, + &AddSmbiosManuCallbackNotifyReg + ); return Status; - - } - - Status =3D gBS->RegisterProtocolNotify ( - &gEfiDxeSmmReadyToLockProtocolGuid, - AddSmbiosManuCallbackEvent, - &AddSmbiosManuCallbackNotifyReg - ); - - return Status; } =20 return EFI_SUCCESS; - } --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43502): https://edk2.groups.io/g/devel/message/43502 Mute This Topic: https://groups.io/mt/32419735/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-