[edk2-devel] [edk2-platforms Patch 02/28] Vlv2TbltDevicePkg/Build_IFWI.sh: Change the root directory path

Michael D Kinney posted 28 patches 21 weeks ago

[edk2-devel] [edk2-platforms Patch 02/28] Vlv2TbltDevicePkg/Build_IFWI.sh: Change the root directory path

Posted by Michael D Kinney 21 weeks ago
From: Gary Lin <glin@suse.com>

Also make Build_IFWI.sh executable

Cc: Zailiang Sun <zailiang.sun@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Gary Lin <glin@suse.com>
---
 Platform/Intel/Vlv2TbltDevicePkg/Build_IFWI.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
 mode change 100644 => 100755 Platform/Intel/Vlv2TbltDevicePkg/Build_IFWI.sh

diff --git a/Platform/Intel/Vlv2TbltDevicePkg/Build_IFWI.sh b/Platform/Intel/Vlv2TbltDevicePkg/Build_IFWI.sh
old mode 100644
new mode 100755
index 7063b7470d..2a22309f5f
--- a/Platform/Intel/Vlv2TbltDevicePkg/Build_IFWI.sh
+++ b/Platform/Intel/Vlv2TbltDevicePkg/Build_IFWI.sh
@@ -86,12 +86,12 @@ else
 fi
 
 ## Go to root directory
-cd ..
+cd ../../..
 
 ## Build BIOS
 echo "======================================================================"
 echo "Build_IFWI:  Calling BIOS build Script..."
-./$PLATFORM_PACKAGE/bld_vlv.sh $Build_Flags $Platform_Type $Build_Target
+./Platform/Intel/$PLATFORM_PACKAGE/bld_vlv.sh $Build_Flags $Platform_Type $Build_Target
 
 echo
 echo Finished Building BIOS.
-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43496): https://edk2.groups.io/g/devel/message/43496
Mute This Topic: https://groups.io/mt/32419729/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms Patch 02/28] Vlv2TbltDevicePkg/Build_IFWI.sh: Change the root directory path

Posted by rebecca@bsdio.com 20 weeks ago
On 2019-07-10 13:04, Michael D Kinney wrote:
>  echo "Build_IFWI:  Calling BIOS build Script..."
> -./$PLATFORM_PACKAGE/bld_vlv.sh $Build_Flags $Platform_Type $Build_Target
> +./Platform/Intel/$PLATFORM_PACKAGE/bld_vlv.sh $Build_Flags $Platform_Type $Build_Target


It looks like these changes are for getting ready to move the code into
master.

I've just started working on porting the BroxtonPlatformPkg over to
master too, and just wanted to check if you know if anyone's already
working on it? If so, I'll stop my work to avoid the duplication of effort.


-- 
Rebecca Cran


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43636): https://edk2.groups.io/g/devel/message/43636
Mute This Topic: https://groups.io/mt/32419729/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms Patch 02/28] Vlv2TbltDevicePkg/Build_IFWI.sh: Change the root directory path

Posted by Michael D Kinney 20 weeks ago
Hi Rebecca,

Vlv2 is already in edk2-platforms/master.  This patch series is fixing some 
Linux/GCC build issues.

I have a few more queued up after this to make it even better by
removing the use of the FCE tool in the build script.

Mike

> -----Original Message-----
> From: Rebecca Cran [mailto:rebecca@bsdio.com]
> Sent: Thursday, July 11, 2019 8:03 PM
> To: devel@edk2.groups.io; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] [edk2-platforms Patch 02/28]
> Vlv2TbltDevicePkg/Build_IFWI.sh: Change the root
> directory path
> 
> On 2019-07-10 13:04, Michael D Kinney wrote:
> >  echo "Build_IFWI:  Calling BIOS build Script..."
> > -./$PLATFORM_PACKAGE/bld_vlv.sh $Build_Flags
> $Platform_Type
> > $Build_Target
> > +./Platform/Intel/$PLATFORM_PACKAGE/bld_vlv.sh
> $Build_Flags
> > +$Platform_Type $Build_Target
> 
> 
> It looks like these changes are for getting ready to move
> the code into master.
> 
> I've just started working on porting the
> BroxtonPlatformPkg over to master too, and just wanted to
> check if you know if anyone's already working on it? If
> so, I'll stop my work to avoid the duplication of effort.
> 
> 
> --
> Rebecca Cran


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43661): https://edk2.groups.io/g/devel/message/43661
Mute This Topic: https://groups.io/mt/32419729/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms Patch 02/28] Vlv2TbltDevicePkg/Build_IFWI.sh: Change the root directory path

Posted by rebecca@bsdio.com 20 weeks ago
On 2019-07-12 10:23, Michael D Kinney wrote:
> Hi Rebecca,
>
> Vlv2 is already in edk2-platforms/master.  This patch series is fixing some 
> Linux/GCC build issues.
>
> I have a few more queued up after this to make it even better by
> removing the use of the FCE tool in the build script.


Oh, thanks!


-- 

Rebecca Cran


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43662): https://edk2.groups.io/g/devel/message/43662
Mute This Topic: https://groups.io/mt/32419729/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms Patch 02/28] Vlv2TbltDevicePkg/Build_IFWI.sh: Change the root directory path

Posted by Sun, Zailiang 21 weeks ago
Reviewed-By: Zailiang Sun <zailiang.sun@intel.com>

> -----Original Message-----
> From: Kinney, Michael D
> Sent: Thursday, July 11, 2019 3:05 AM
> To: devel@edk2.groups.io
> Cc: Gary Lin <glin@suse.com>; Sun, Zailiang <zailiang.sun@intel.com>; Qian,
> Yi <yi.qian@intel.com>
> Subject: [edk2-platforms Patch 02/28] Vlv2TbltDevicePkg/Build_IFWI.sh:
> Change the root directory path
> 
> From: Gary Lin <glin@suse.com>
> 
> Also make Build_IFWI.sh executable
> 
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> Cc: Yi Qian <yi.qian@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: Gary Lin <glin@suse.com>
> ---
>  Platform/Intel/Vlv2TbltDevicePkg/Build_IFWI.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)  mode change 100644 => 100755
> Platform/Intel/Vlv2TbltDevicePkg/Build_IFWI.sh
> 
> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/Build_IFWI.sh
> b/Platform/Intel/Vlv2TbltDevicePkg/Build_IFWI.sh
> old mode 100644
> new mode 100755
> index 7063b7470d..2a22309f5f
> --- a/Platform/Intel/Vlv2TbltDevicePkg/Build_IFWI.sh
> +++ b/Platform/Intel/Vlv2TbltDevicePkg/Build_IFWI.sh
> @@ -86,12 +86,12 @@ else
>  fi
> 
>  ## Go to root directory
> -cd ..
> +cd ../../..
> 
>  ## Build BIOS
>  echo
> "==========================================================
> ============"
>  echo "Build_IFWI:  Calling BIOS build Script..."
> -./$PLATFORM_PACKAGE/bld_vlv.sh $Build_Flags $Platform_Type
> $Build_Target
> +./Platform/Intel/$PLATFORM_PACKAGE/bld_vlv.sh $Build_Flags
> +$Platform_Type $Build_Target
> 
>  echo
>  echo Finished Building BIOS.
> --
> 2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43557): https://edk2.groups.io/g/devel/message/43557
Mute This Topic: https://groups.io/mt/32419729/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-