From nobody Fri Mar 29 06:21:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+43348+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+43348+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1562322872; cv=none; d=zoho.com; s=zohoarc; b=aeejRbYA8HSZF700WU/+/v6fEbbggdzKUT6Y+xEKP/SvNtTcZqPuDzWEQ4SWamD00P4mS6K0xZai3Jopj9f+JPUyysS5oYqmwT5ndZUx89+yIapdJ+zYJQ6uT/+ihKRnytQxXjdFjb7hVNfqMltIuI9CoDTZzoAnITl7Ib0g/Ms= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562322872; h=Cc:Date:From:List-Id:List-Unsubscribe:Message-ID:Reply-To:Sender:Subject:To:ARC-Authentication-Results; bh=nGs6uicO+xT4MeqEUzLcZS2r2XtBv52y4wyY9+CirxQ=; b=Z5XO+qyNMQqvz6tyR928TxoKnK6wgtt7R9aGrOreDELkZePMCKO5cDbdA2OUhGFuQx5uWNOBuh2/9eq0uyAnEM7OAX7mwNzKpeijVv0CuMl7vZcK1yzCtVkYm+6nsgYUo0ACkJ/R+G6V93Xab302l5r3U33HbRYVC104EZR9eig= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+43348+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1562322872089813.9695492242333; Fri, 5 Jul 2019 03:34:32 -0700 (PDT) Return-Path: X-Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by groups.io with SMTP; Fri, 05 Jul 2019 03:34:31 -0700 X-Received: by mail-wm1-f68.google.com with SMTP id z23so8826830wma.4 for ; Fri, 05 Jul 2019 03:34:30 -0700 (PDT) X-Gm-Message-State: APjAAAWOhhLqrguBP9wfVBNxJm7DwSDAG9DlzVU47v2v4QPIdXvbjNKb UhNnO4NqL+tvJsKsIRaMMi0qNsV7kK8= X-Google-Smtp-Source: APXvYqxpFKBvs759AUGu+sunzKIl9ssp0yCXh0soz4brnURjjG2Il5RYGo2JLoR1jAHrTfUmqQinRw== X-Received: by 2002:a7b:c3d5:: with SMTP id t21mr2729723wmj.87.1562322868812; Fri, 05 Jul 2019 03:34:28 -0700 (PDT) X-Received: from urvogel.hemma.eciton.net (cpc92302-cmbg19-2-0-cust304.5-4.cable.virginm.net. [82.1.209.49]) by smtp.gmail.com with ESMTPSA id r4sm8315271wrv.34.2019.07.05.03.34.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Jul 2019 03:34:28 -0700 (PDT) From: "Leif Lindholm" To: devel@edk2.groups.io Cc: Bob Feng , Liming Gao Subject: [edk2-devel] [PATCH] BaseTools: fix FCE build when edksetup not executed Date: Fri, 5 Jul 2019 11:34:26 +0100 Message-Id: <20190705103426.1423-1-leif.lindholm@linaro.org> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,leif.lindholm@linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1562322871; bh=2IoGHt1TAbT/UTLPZ3f8J6JchL3e8iR2bJmEIxwGa1w=; h=Cc:Date:From:Reply-To:Subject:To; b=ilXn7Lmn8+LY0xAb0S1I3mD69x4CBKDE8niAv1cE7pBxwkdxvWBtFFHXaqkJRMz9Ylg 6K5cn6C/2R1O5X9uOd+rRsOLECjp6wg5wPgHBmTFSHNQ0eNmV8+taw/yPQbnJ07Mbjckw j7YRXz6dIlX0BixJb5+Wwcpc4F+PcGr6i0c= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Commit 3c59d94637ad ("BaseTools/FCE: Add a tool FCE") added a new tool that is always built. Pre-existing tools locate the makefile includes with relative paths, but FCE uses EDK_TOOLS_PATH, adding a new dependency on having sourced edksetup.sh before building BaseTools. Change FCE GNUmakefile to match other tools. Signed-off-by: Leif Lindholm --- This broke our CI setup, so I'd appreciate if it could be merged quickly. BaseTools/Source/C/FCE/GNUmakefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Source/C/FCE/GNUmakefile b/BaseTools/Source/C/FCE/GN= Umakefile index 3e1b6a85e2..7a7e1ef4b8 100644 --- a/BaseTools/Source/C/FCE/GNUmakefile +++ b/BaseTools/Source/C/FCE/GNUmakefile @@ -42,7 +42,7 @@ endif export ARCH export HOST_ARCH=3D$(ARCH) =20 -MAKEROOT ?=3D $(EDK_TOOLS_PATH)/Source/C +MAKEROOT ?=3D .. =20 APPNAME =3D FCE =20 --=20 2.11.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43348): https://edk2.groups.io/g/devel/message/43348 Mute This Topic: https://groups.io/mt/32316137/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-