From nobody Thu May 2 18:46:33 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+43119+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1561979687; cv=none; d=zoho.com; s=zohoarc; b=ITKJSJBreHDA1zRCMmMQqM21i+PmIRpZrb/jFwQXQvj9CVfLUuKaRXT3z8TUZTPPl/nUMC4hcYExFxkNzxtXfoJ7rosNR11Zlsf6W9cIG3WKjeWNv6rTT6jA5j5pn/YA2CKN9FpgdfPPvgy4/GjiQIGYWi33p5o7C3xl5viMy6E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1561979687; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To:ARC-Authentication-Results; bh=ql9YfG25hQCiFDEnBHQEQplZdrb33euZE7V2e+p5FPQ=; b=oO5t4bEejkVHKppU47E71V7ckFKkizX2vbpxC8e6tiiFXPIJI87XpmHX7Tnp5F6JSEcxgSYMJrJ15qJ6JiHz1fB+Kj5ieThqsrVW9bH1kCZNRmcn7EgDLe4Avc1w2OIpJWppzXbJ+yVBG8/ACUGp1+853OlOH6ibMrCYsqSm6Io= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+43119+1787277+3901457@groups.io Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1561979687533759.4059567022306; Mon, 1 Jul 2019 04:14:47 -0700 (PDT) Return-Path: X-Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by groups.io with SMTP; Mon, 01 Jul 2019 04:14:46 -0700 Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+43119+1787277+3901457@groups.io; helo=web01.groups.io; Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of anthony.perard@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa6.hc3370-68.iphmx.com: domain of anthony.perard@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: oseTF2XiLF7OJQ3ElmtrMjCOloLto1A9OilOveWiHy0JSiKHMScmitw3br7mBb4XWJu69IyrLN u2z3bW9yjQMpp1cS6vWHzuXoSwdxRV6CoRfM6AxssrbNcQJBS/rugGhZQrACUtpzTr5a2pbGgo NHXBbxrza6p1l9M420olYE6lf93uLJqhEiVuGVVYUxfZ+FTyKc21ESLv1f/NgKYxiBvjMXo/N8 B3pxOHGkPJ9f3KOLVEuAFuKKh6H9OIakyZOtlN3JPqYNO9FOYWCyqTy0DynzmNJlCwq6P055Rl /cA= X-SBRS: 2.7 X-MesageID: 2457178 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.63,439,1557201600"; d="scan'208";a="2457178" From: "Anthony PERARD" To: CC: Jordan Justen , Laszlo Ersek , Ard Biesheuvel , Julien Grall , Anthony PERARD Subject: [edk2-devel] [PATCH] OvmfPkg/XenBusDxe: Don't call DisconnectController in Stop() Date: Mon, 1 Jul 2019 12:14:03 +0100 Message-ID: <20190701111403.7007-1-anthony.perard@citrix.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,anthony.perard@citrix.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1561979687; bh=2h+DrNMqXwY8gIZHymRDO52PizlrkEaSKOfwL4C1jOY=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=ZFaJE4hPaeCTPCkstBp3BqabSkP+cBMhXa/TTQlvJkyhAvGGki1T25V5CtQAWiZhMj1 Jg0vtFLsryilh0gCz/ygvCUc6eOoBF6QfrJOUb5UtbBrpL7qpggccQLQVEvbgv5Z76/4T bI8G++vW4MtBAzKAlFgW0BMwf6iha80ghtM= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Calling DisconnectController() on children isn't part of the job of EFI_DRIVER_BINDING_PROTOCOL.Stop() as it only needs to deallocate resources allocated in Start(). The disconnection will happen when both DevicePath and XenBus protocols gets uninstalled. Reported-by: Laszlo Ersek Signed-off-by: Anthony PERARD Reviewed-by: Laszlo Ersek --- Notes: Please apply this patch after: "OvmfPkg/XenBusDxe: Close XenIoProtocol openned by children" OvmfPkg/XenBusDxe/XenBusDxe.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/OvmfPkg/XenBusDxe/XenBusDxe.c b/OvmfPkg/XenBusDxe/XenBusDxe.c index 7c07a96650..634c7b71eb 100644 --- a/OvmfPkg/XenBusDxe/XenBusDxe.c +++ b/OvmfPkg/XenBusDxe/XenBusDxe.c @@ -446,12 +446,6 @@ XenBusDxeDriverBindingStop ( continue; } ChildData =3D XENBUS_PRIVATE_DATA_FROM_THIS (XenBusIo); - Status =3D gBS->DisconnectController (ChildData->Handle, NULL, NULL); - if (EFI_ERROR (Status)) { - DEBUG ((EFI_D_ERROR, "XenBusDxe: error disconnecting child: %r\n", - Status)); - continue; - } =20 Status =3D gBS->CloseProtocol (Dev->ControllerHandle, &gXenIoProtocolG= uid, Dev->This->DriverBindingHandle, ChildData->Handle); --=20 Anthony PERARD -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43119): https://edk2.groups.io/g/devel/message/43119 Mute This Topic: https://groups.io/mt/32270256/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-