From nobody Fri May 3 10:36:53 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+43031+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1561738585; cv=none; d=zoho.com; s=zohoarc; b=WG9bsZuQ9aklTYvM9Ol/VeWSTRRqgni/HDPSAXlPD6N1dmxCWFZmd4oAcZHoshnw1ePcC+MPQhL65czrGKnzqHeoqYQxeOJoZi/Hwlr0EkcZsXSQUo0/QPiNY8QS4Q7h7XD2pMqEIDLsfi/2tAPIeZbg4oaOGP3H6PS16v0Nq0k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1561738585; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To:ARC-Authentication-Results; bh=qNjP2aEhfPnBboS2kMaXRT9D8r50aKSWnmeyDgVwTk8=; b=XHzlYaXqKNmqkGxaATSo3bOm0/hKcdP5LlFo0zPGEeowc3rZud49ChmzSmCbVAoUrWOpGP+0cBFjA5OWU2EqWS4nvDHSM2WCdIxochFkxM2WXY+4l65VxjB6uSdy+RxLbJttu9ntm7qmtmNEeygFnvZvZWMvOdXhItNs7EqElp8= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+43031+1787277+3901457@groups.io Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1561738585646386.6342421255184; Fri, 28 Jun 2019 09:16:25 -0700 (PDT) Return-Path: X-Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by groups.io with SMTP; Fri, 28 Jun 2019 09:16:24 -0700 Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+43031+1787277+3901457@groups.io; helo=web01.groups.io; Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of anthony.perard@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa6.hc3370-68.iphmx.com: domain of anthony.perard@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: jxCdj+4xhBSANXoA2Sdd0pPbrCsuBFvw4uJNIHhyNDMY2igv//TdQfvEmKPKsBWhXThG6IwNN5 4K2U2V2isXHp20G8Up+4wB2j14M46rP/dZoPFSnNqaEQHxLu5yu3vLZXH78fmDdU2a7MxxvrZx ILHNDNYroWDhnT1Uxpbk9GmD7xfB20ZvUdDSNY6tUXZAbqIApSRCqz9E80Z6xkzax/FNUdKr0o P+7tSEL5mPGUSXLpx8s30yqFWDT9+2+lrjKzc6oBlMUQOCzKkYKq6Nq51z44OmxaRPfSrZZd6w 2wU= X-SBRS: 2.7 X-MesageID: 2392058 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.63,428,1557201600"; d="scan'208";a="2392058" From: "Anthony PERARD" To: CC: Jordan Justen , Laszlo Ersek , Ard Biesheuvel , Julien Grall , Anthony PERARD Subject: [edk2-devel] [PATCH] OvmfPkg/XenBusDxe: Close XenIoProtocol openned by childs Date: Fri, 28 Jun 2019 17:16:06 +0100 Message-ID: <20190628161606.13141-1-anthony.perard@citrix.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,anthony.perard@citrix.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1561738584; bh=BGOJG/FXeVCqpdr5S68R4KoA09RcgUTyCHyDQoNUXSI=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=KlNJ9Q51dBWxlI2svT4xLi2vxVlT1nwMVrQHCMqwxu4+eo1dHBHTHunrDj6njrg4lE5 XWcqMYTrai+6q3fRqlgwR4x3eFvRdLs8W+tOTcN+tyncdklsP5bmNQIEywQ91qqTyUZ10 /csD+0a9PUEJ09J+Dwp229LPBZA++Lp6cAM= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" In XenBusDxe, the XenBusAddDevice() opens the gXenIoProtocolGuid on behalf of child controllers. It is never closed and prevent from uninstalling the protocol. Close it were we stop all the childs in XenBusDxe->Stop(). Signed-off-by: Anthony PERARD Reviewed-by: Laszlo Ersek --- OvmfPkg/XenBusDxe/XenBusDxe.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/OvmfPkg/XenBusDxe/XenBusDxe.c b/OvmfPkg/XenBusDxe/XenBusDxe.c index 0e63707f50..fac6f3a09d 100644 --- a/OvmfPkg/XenBusDxe/XenBusDxe.c +++ b/OvmfPkg/XenBusDxe/XenBusDxe.c @@ -453,6 +453,11 @@ XenBusDxeDriverBindingStop ( continue; } =20 + Status =3D gBS->CloseProtocol (Dev->ControllerHandle, &gXenIoProtocolG= uid, + Dev->This->DriverBindingHandle, + ChildData->Handle); + ASSERT_EFI_ERROR (Status); + Status =3D gBS->UninstallMultipleProtocolInterfaces ( ChildData->Handle, &gEfiDevicePathProtocolGuid, ChildData->DevicePath, --=20 Anthony PERARD -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43031): https://edk2.groups.io/g/devel/message/43031 Mute This Topic: https://groups.io/mt/32243460/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-