From nobody Wed Nov 27 02:22:47 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+41891+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+41891+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1559683133; cv=none; d=zoho.com; s=zohoarc; b=nBZjIxX2pIF4F4jlMln3mPcVbcCKktuMscFtKqTEY/0KW1JcbT75yfpSzD2/zT8HEzi/r7g9alx6h6456yEHTXl6SPoGaazqVgD5EixuS2I4Tz3PnIV8LzogH6FlZOEbqGXBbFb+BNOz3TkU77aPNWGz2lGdbPbylAKtkQu49hE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559683133; h=Cc:Date:From:List-Id:List-Unsubscribe:Message-ID:Reply-To:Sender:Subject:To:ARC-Authentication-Results; bh=5lsB6r8IH4Ad2vACQMnNKfhQ/UuDhuC7HRNgPwzAeDI=; b=EH7ITyJB0jqmbQGRlgtRSAULsHqGY0gJCERrTb34XJFCvRMhr8uv40jtO/bmac/vy49/JOpkVa8qQsztRF2jfnyoQjI94eVVuP0LMfmKbUbrbpoRWgJiz3cPwcpE1HVRIPIhL1pNQ0by2cUFFNm9AGH37bYDnU7Ns7pwBgt+6Tc= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+41891+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1559683133195664.2944604830697; Tue, 4 Jun 2019 14:18:53 -0700 (PDT) Return-Path: X-Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by groups.io with SMTP; Tue, 04 Jun 2019 14:18:51 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Jun 2019 14:18:50 -0700 X-ExtLoop1: 1 X-Received: from shwdeopenpsi777.ccr.corp.intel.com ([10.239.158.28]) by FMSMGA003.fm.intel.com with ESMTP; 04 Jun 2019 14:18:49 -0700 From: "Wang, Jian J" To: devel@edk2.groups.io Cc: Dandan Bi , Xiaoyu Lu Subject: [edk2-devel] [PATCH] CryptoPkg/OpensslLib: fix VS2017 build failure Date: Wed, 5 Jun 2019 05:18:44 +0800 Message-Id: <20190604211844.4424-1-jian.j.wang@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jian.j.wang@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1559683132; bh=7Ww/bCw5KZyx4OTGaTaS2+L8f46kGOkNKotqerzodJI=; h=Cc:Date:From:Reply-To:Subject:To; b=E6OkRWD7lRfsUV7EZ/5t0TYlJF9XSatIBoHmgQDvIOcBSvlUV1WuBPUhqiaE/NyYOiC NFUJKOthyl0foXajBtCG579OK22qZP77Y22tuSO+RMwsS0g5reP+R744yvgn8IOfZkboj HvOLds9c6fVukV1EqzyGRxdLrM97ZI/BRac= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1878 This issue is specific to VS2017 which tries to resolve symbol referenced by a symbol not really referenced eventually. ossl_init_load_crypto_strings -> err_load_crypto_strings_int (not really referenced) -> ERR_load_OSSL_STORE_strings Because OPENSSL_NO_ERR and OPENSSL_NO_AUTOERRINIT are not defined by default, err_load_crypto_strings_int() will not be actually referenced by ossl_init_load_crypto_strings(). Since err_load_crypto_strings_int() is not actually referenced at all, the fix can be done simply by removing crypto/err/err_all.c from build. Cc: Dandan Bi Cc: Xiaoyu Lu Signed-off-by: Jian J Wang Reviewed-by: Liming Gao --- CryptoPkg/Library/OpensslLib/OpensslLib.inf | 1 - CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 1 - 2 files changed, 2 deletions(-) diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf b/CryptoPkg/Librar= y/OpensslLib/OpensslLib.inf index 378fa6588e..5a2424fc16 100644 --- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf +++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf @@ -218,7 +218,6 @@ $(OPENSSL_PATH)/crypto/dso/dso_win32.c $(OPENSSL_PATH)/crypto/ebcdic.c $(OPENSSL_PATH)/crypto/err/err.c - $(OPENSSL_PATH)/crypto/err/err_all.c $(OPENSSL_PATH)/crypto/err/err_prn.c $(OPENSSL_PATH)/crypto/evp/bio_b64.c $(OPENSSL_PATH)/crypto/evp/bio_enc.c diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf b/CryptoPkg/= Library/OpensslLib/OpensslLibCrypto.inf index 24d3d96459..588da4c040 100644 --- a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf +++ b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf @@ -218,7 +218,6 @@ $(OPENSSL_PATH)/crypto/dso/dso_win32.c $(OPENSSL_PATH)/crypto/ebcdic.c $(OPENSSL_PATH)/crypto/err/err.c - $(OPENSSL_PATH)/crypto/err/err_all.c $(OPENSSL_PATH)/crypto/err/err_prn.c $(OPENSSL_PATH)/crypto/evp/bio_b64.c $(OPENSSL_PATH)/crypto/evp/bio_enc.c --=20 2.17.1.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41891): https://edk2.groups.io/g/devel/message/41891 Mute This Topic: https://groups.io/mt/31930984/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-