From nobody Mon Apr 29 01:34:21 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+41874+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1559665437; cv=none; d=zoho.com; s=zohoarc; b=RoOELh/tF0VPFEvDvHdy1XyKemH8XgunuomeXdjo+vqTHk3x3mBykuLUaO2JqES5sgM+VCf4iQiiwQPnxisU3hDm/egCOm4LzgbAr7mmvZCJ29MmrZVQhvZGN0yqAVJjgj6BxFQLmCwBN9Qo8/FEL3jBONdmii7aOdiAOGwodww= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559665437; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=djMiBz7AbHcSGvidYnjy2g64w48HDlaJ0CFYp+sM9Rw=; b=oCJHVaJ2Sr4AEtxxPPlMV2rLcFc+hRg2DnRUefpQQO+0jJcZWWKRYmcInz5TrMW0LOa0K/3tI1Cy2pHQ0nZMn6ixxOPSFxQpsUrHIa1JfFMu2VKLUWFzcxkshfTtKRcYbPbuX7zUO1qP8yWbKqvpVEjVSpUmCUE9jzbBB2i347g= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+41874+1787277+3901457@groups.io Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1559665437858970.6195432173893; Tue, 4 Jun 2019 09:23:57 -0700 (PDT) Return-Path: X-Received: from NAM03-CO1-obe.outbound.protection.outlook.com (NAM03-CO1-obe.outbound.protection.outlook.com [40.107.79.44]) by groups.io with SMTP; Tue, 04 Jun 2019 08:41:19 -0700 X-Received: from DM6PR11MB2955.namprd11.prod.outlook.com (20.177.217.28) by DM6PR11MB3001.namprd11.prod.outlook.com (20.177.217.206) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1965.12; Tue, 4 Jun 2019 15:41:17 +0000 X-Received: from DM6PR11MB2955.namprd11.prod.outlook.com ([fe80::a06e:bee7:e6ee:3907]) by DM6PR11MB2955.namprd11.prod.outlook.com ([fe80::a06e:bee7:e6ee:3907%7]) with mapi id 15.20.1943.018; Tue, 4 Jun 2019 15:41:17 +0000 From: Roman Agafonov To: "devel@edk2.groups.io" CC: Bob Feng , Liming Gao , Yonghong Zhu Subject: [edk2-devel] [PATCH v1 1/1] BaseTools: don't use WHOLEARCHIVE linker flag for VS2017 toolchain Thread-Topic: [PATCH v1 1/1] BaseTools: don't use WHOLEARCHIVE linker flag for VS2017 toolchain Thread-Index: AQHVGuvztnZTUQXnBEyYuTMVWYDXFw== Date: Tue, 4 Jun 2019 15:41:17 +0000 Message-ID: <20190604154059.30380-2-roman.agafonov@aquantia.com> References: <20190604154059.30380-1-roman.agafonov@aquantia.com> In-Reply-To: <20190604154059.30380-1-roman.agafonov@aquantia.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HE1P191CA0014.EURP191.PROD.OUTLOOK.COM (2603:10a6:3:cf::24) To DM6PR11MB2955.namprd11.prod.outlook.com (2603:10b6:5:64::28) x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [95.79.108.179] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c7a774fe-a56b-4aa8-c672-08d6e903155b x-ms-traffictypediagnostic: DM6PR11MB3001: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3968; Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+41874+1787277+3901457@groups.io; helo=web01.groups.io; received-spf: None (protection.outlook.com: aquantia.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: HSN8r0rOxJlD6k44nWP3wu4TyMeJ83x9UJfGC/zFIqoMCHhHUdWqN+z4/wLe/AnrEKYHN0JbIij7eSfjGIod2Uge3tmrTB62n7ZtMu2+Vvnb+AAKMuxhG9DSA2+7aK9JjQ3cukg/CDDz+SoFcWHWLzkdJKPW5cqQd+IlXt+zqORiuMdEoCjFGEpxKWTDHgBqPe+oTaCS/u3EFftXuAdCfunFMDEf8DBcKJeCUZI0M8bYathgNveyirRga78DoJX34Y5/JAAF1j/S83UuTlKJWk8KlXHIwL/Zn3cftuGPG+5hJ+6yz/6O/985QTdoLAY5xq5j1uW0JnXXcz4S75mmpb982JR/9frVzbCNBEvdmKYmvbz0BW+lrh5Q7/qwGeTVWBSM/j01973LEor3BzTzUwbAV3/mck7e4ILCjVxrJvg= MIME-Version: 1.0 X-OriginatorOrg: aquantia.com X-MS-Exchange-CrossTenant-Network-Message-Id: c7a774fe-a56b-4aa8-c672-08d6e903155b X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jun 2019 15:41:17.7960 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 83e2e134-991c-4ede-8ced-34d47e38e6b1 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ragaf@aquantia.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3001 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,Roman.Agafonov@aquantia.com Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1559665436; bh=djMiBz7AbHcSGvidYnjy2g64w48HDlaJ0CFYp+sM9Rw=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=gKlkvNbI4j6k5fSLFR5kGcdUo83pXqH6G11T8zpHgCfEXYLPECnJLkoldvlUTTuZYji RGSJLIH2IWIQNj9q+MlzU9MOBgmDFuAYw1oLjvUcLTZ7UyNWo5IO51nV7Kwg8uBHYYZGh 3PrtZVSK96xxzFylP2kNnc7vgpvMl30D+Dc= X-ZohoMail-DKIM: pass (identity @groups.io) I have noticed the resulting binaries are about twice as large when using VS2017 toolchain compared to the ones built with VS2015. It appears this is caused by /WHOLEARCHIVE linker flag used by this toolchain. This flag was previously removed from VS2015 toolchain due to compatibility issues. I believe it should not be used with VS2017 as well. Cc: Bob Feng Cc: Liming Gao Cc: Yonghong Zhu Signed-off-by: Roman Agafonov --- BaseTools/Conf/tools_def.template | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.t= emplate index 26a2cf604f74..482a526f3052 100755 --- a/BaseTools/Conf/tools_def.template +++ b/BaseTools/Conf/tools_def.template @@ -1545,7 +1545,7 @@ NOOPT_VS2015x86_X64_DLINK_FLAGS =3D /NOLOGO /NODEF= AULTLIB /IGNORE:4001 /OPT:REF *_VS2017_*_APP_FLAGS =3D /nologo /E /TC *_VS2017_*_PP_FLAGS =3D /nologo /E /TC /FIAutoGen.h *_VS2017_*_VFRPP_FLAGS =3D /nologo /E /TC /DVFRCOMPILE /FI$(MODULE_NAM= E)StrDefs.h -*_VS2017_*_DLINK2_FLAGS =3D /WHOLEARCHIVE +*_VS2017_*_DLINK2_FLAGS =3D *_VS2017_*_ASM16_PATH =3D DEF(VS2017_BIN_IA32)\ml.exe =20 ################## --=20 2.9.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41874): https://edk2.groups.io/g/devel/message/41874 Mute This Topic: https://groups.io/mt/31928156/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-