From nobody Fri May 3 15:34:08 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+41851+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+41851+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1559617453; cv=none; d=zoho.com; s=zohoarc; b=KW9+riS13bWOomv1iEXkYJsehHDvok79nAnhKTD5JN0lv8oaBX8YiRwUu+B7/9P0V+tE2+BGc8Gy+I3gGKCeZGLR7TeR/l4LFkCe/PDlq5ewqoK/PFo59EwFyZjArA/CmE/Od4bBhUm6PWAWsvCHJTVHX86FUaF0stB4jrXFgDM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559617453; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=nu7KwF5uUkGMpO96p/uq+ryeE8C25jQT3CMLjthn6Hw=; b=hWkRMOWghdSBqpVe8nQ1rO9jKj9VeKOZvmjulYnF/U3y2oE7YiZlWUl55aKJF++1ZC0JdISsHI+7GAd3x/z5/STK3UJY/xVgTJQk+eY3KcQ9tiWvEE5Q4ISYA2l1X6gZKpb1PO47B4/6CZPLMSoAHnZ+TLoKanym9usUhMwyccQ= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+41851+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1559617453153373.62812403295754; Mon, 3 Jun 2019 20:04:13 -0700 (PDT) Return-Path: X-Received: from mga04.intel.com (mga04.intel.com []) by groups.io with SMTP; Mon, 03 Jun 2019 20:04:12 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jun 2019 20:04:12 -0700 X-ExtLoop1: 1 X-Received: from cchiu4-mobl1.gar.corp.intel.com ([10.5.240.40]) by orsmga007.jf.intel.com with ESMTP; 03 Jun 2019 20:04:10 -0700 From: "Chiu, Chasel" To: devel@edk2.groups.io Cc: Michael Kubacki , Nate DeSimone , Liming Gao Subject: [edk2-devel] [PATCH 1/2] Platform/Intel: Switch to FSP Dispatch mode. Date: Tue, 4 Jun 2019 11:03:58 +0800 Message-Id: <20190604030359.4296-2-chasel.chiu@intel.com> In-Reply-To: <20190604030359.4296-1-chasel.chiu@intel.com> References: <20190604030359.4296-1-chasel.chiu@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,chasel.chiu@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1559617452; bh=UI4zGTDaiiL3TtKMlqmRB/RKy20YFarQyFhQfsk3JIg=; h=Cc:Date:From:Reply-To:Subject:To; b=goPcxuaKd3KSJ4SWDODUzM65+hjjD/5ur3cxirLKBO8fVdlseIe+ryo5PUIwPl4xibl VD9NOam5PNFy/ZGLo6QPdRYc3E9PSNjG5JTVSDVScAu3MsJJDHHHub0k4DyUtQH0TAz5U 1yxBi+8TynfmmnXqO77YG+ehBbpDkcA4cdU= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1874 Build configuration is updated to support different *FspBinPkg between FSP wrapper API and Dispatch modes. Default will be Dispatch mode and to build FSP wrapper for API mode: "py -2 build_bios.py --platform KabylakeRvp3 --fspapi" Cc: Michael Kubacki Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Chasel Chiu Reviewed-by: Nate DeSimone --- Platform/Intel/build_bios.py | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/Platform/Intel/build_bios.py b/Platform/Intel/build_bios.py index 9f8d78f6e8..09eceddeff 100644 --- a/Platform/Intel/build_bios.py +++ b/Platform/Intel/build_bios.py @@ -125,6 +125,16 @@ def pre_build(build_config, build_type=3D"DEBUG", sile= nt=3DFalse, toolchain=3DNone): config["BASE_TOOLS_PATH"] =3D config["EDK_TOOLS_PATH"] config["EDK_TOOLS_BIN"] =3D os.path.join(config["WORKSPACE"], config["EDK_TOOLS_BIN"]) + + # + # Board may have different FSP binary between API and Dispatch modes. + # In API mode if FSP_BIN_PKG_FOR_API_MODE is assigned, it should + # override FSP_BIN_PKG. + # + if config.get("API_MODE_FSP_WRAPPER_BUILD", "FALSE") =3D=3D "TRUE": + if config.get("FSP_BIN_PKG_FOR_API_MODE") is not None: + config['FSP_BIN_PKG'] =3D config['FSP_BIN_PKG_FOR_API_MODE'] + config["PLATFORM_FSP_BIN_PACKAGE"] =3D \ os.path.join(config['WORKSPACE_FSP_BIN'], config['FSP_BIN_PKG']) config['PROJECT_DSC'] =3D os.path.join(config["WORKSPACE_PLATFORM"], --=20 2.13.3.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41851): https://edk2.groups.io/g/devel/message/41851 Mute This Topic: https://groups.io/mt/31918437/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 3 15:34:08 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+41852+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+41852+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1559617454; cv=none; d=zoho.com; s=zohoarc; b=DBIXQRyXMLlAoqGKweZ6JWWpHMLKYPi+RGCGlokvAcM8eJ9eWlOoSsw0yryR06DTgpnrVAal6QLG77YIBAXUbccN4XFyrtcH/pSRQn4kJj/ZPqYONizfPeq3Mz642bByOJHWJf5GQLANIbin9gyntTSkQpvJb5PnnlN5eFvUEG0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559617454; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=Gpf5VST/bcZfUpw/fRFZInGXZc51vMmuHqDMKRAsxv4=; b=lyIIP21TWt1ypIjM1j/gCqdKiN03GrKV3Z2n24sVJfky9K9TddV/Vn/zLrSNNbTKM/SAlvm0oy4SmtLu2llPYWPiG1FBMrUbZcP7q2yeASfX1ZqDgJfjt0VkfwbAa/93cghN4ZXmDgpU6q/5gpDgCsdXJqX/QPibL/LBb61iXmI= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+41852+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1559617454500635.5724158443289; Mon, 3 Jun 2019 20:04:14 -0700 (PDT) Return-Path: X-Received: from mga04.intel.com (mga04.intel.com []) by groups.io with SMTP; Mon, 03 Jun 2019 20:04:13 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jun 2019 20:04:13 -0700 X-ExtLoop1: 1 X-Received: from cchiu4-mobl1.gar.corp.intel.com ([10.5.240.40]) by orsmga007.jf.intel.com with ESMTP; 03 Jun 2019 20:04:12 -0700 From: "Chiu, Chasel" To: devel@edk2.groups.io Cc: Michael Kubacki , Nate DeSimone , Liming Gao Subject: [edk2-devel] [PATCH 2/2] KabylakeOpenBoardPkg: Switch to FSP Dispatch mode. Date: Tue, 4 Jun 2019 11:03:59 +0800 Message-Id: <20190604030359.4296-3-chasel.chiu@intel.com> In-Reply-To: <20190604030359.4296-1-chasel.chiu@intel.com> References: <20190604030359.4296-1-chasel.chiu@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,chasel.chiu@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1559617454; bh=e5eUX4HBmUV7BHmuA4UUKd5ANh20UHcje+ACU1KL1Bo=; h=Cc:Date:From:Reply-To:Subject:To; b=tT/xrKfFxdMN1+NErDgVxf+YUeL1Ws+1yAxIPkrF0GS2zq1Ir419c2QPRZharshJsuf mqQcCaZ+a0LQg5vdpDrgyTWD/jVjWIZ4YP9BinQxzEoAKx81ergyHFsb9fLp6rXNlxHWX GokTfQzDl5WVN4v7ouVvNA3Iqs//0D2QwNM= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1874 Now KabylakeOpenBoardPkg is building in FSP Dispatch mode as default. Test: Both FSP API and Dispatch mode can boot to Windows. Cc: Michael Kubacki Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Chasel Chiu Reviewed-by: Nate DeSimone --- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc | 2 +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg | 5 += ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgP= cd.dsc b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.d= sc index 63d0c4c2e6..81244d7216 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc @@ -32,7 +32,7 @@ # 0: FSP Wrapper is running in Dispatch mode. # 1: FSP Wrapper is running in API mode. # - gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection|1 + gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection|0 =20 !if gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable =3D=3D TRUE gEfiMdePkgTokenSpaceGuid.PcdPerformanceLibraryPropertyMask|0x1 diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.= cfg b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg index 64e02f7f48..bf89ea399c 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg @@ -27,8 +27,9 @@ TARGET =3D DEBUG TARGET_SHORT =3D D PERFORMANCE_BUILD =3D FALSE FSP_WRAPPER_BUILD =3D TRUE -FSP_BIN_PKG =3D KabylakeFspBinPkg -FSP_PKG_NAME =3D KabylakeFspPkg +FSP_BIN_PKG =3D AmberLakeFspBinPkg +FSP_BIN_PKG_FOR_API_MODE =3D KabylakeFspBinPkg +FSP_PKG_NAME =3D AmberLakeFspPkg FSP_BINARY_BUILD =3D FALSE FSP_TEST_RELEASE =3D FALSE SECURE_BOOT_ENABLE =3D FALSE --=20 2.13.3.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41852): https://edk2.groups.io/g/devel/message/41852 Mute This Topic: https://groups.io/mt/31918438/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-