From nobody Sun Apr 28 21:37:24 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+41845+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+41845+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1559609560; cv=none; d=zoho.com; s=zohoarc; b=eqp/TbMpB5GpYNrYDgHQ8Ds+z6+ASOjHk7GkzKwSEEayx7uQiyl69WbmQFG2zVVeNJfGASFv0W4pUXJT060QZhEQqddjyR1yrkqaCSO9FtvkjuPJoWRMhmdbohcb3IAx98sHoHSSkczJjD3UeIdC3ObOfhPOFQO4vE2AjpyuiNg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559609560; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=y9SccMyAPRjE6lUl6qnaXJRwtdSnNsdpp1ZVJsQi9eU=; b=fs7ZGWInpAIxfyQl3+MSQHbCwI2736xaCpwKMbhJ7hk022M6cMfhXtbf3dVWKaNH7cMezJsmq66Dx+ViRsehgP4Iy+6MJtlfppxyerwzuDFiDxSKR2UjyXSAfcx0yYMggT9OHFTyEHLrCuMtD5P2ACK13F+rJ+fbXyMiKJ5yuPs= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+41845+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1559609560134428.04399023100063; Mon, 3 Jun 2019 17:52:40 -0700 (PDT) Return-Path: X-Received: from mga02.intel.com (mga02.intel.com []) by groups.io with SMTP; Mon, 03 Jun 2019 17:52:39 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jun 2019 17:52:38 -0700 X-ExtLoop1: 1 X-Received: from cchiu4-mobl1.gar.corp.intel.com ([10.5.240.40]) by fmsmga008.fm.intel.com with ESMTP; 03 Jun 2019 17:52:37 -0700 From: "Chiu, Chasel" To: devel@edk2.groups.io Cc: "Chasel, Chiu" , Michael Kubacki , Nate DeSimone , Liming Gao Subject: [edk2-devel] [PATCH 1/2] Intel/MinPlatformPkg: Support DXE drivers in FSP 2.1. Date: Tue, 4 Jun 2019 08:52:32 +0800 Message-Id: <20190604005233.12312-2-chasel.chiu@intel.com> In-Reply-To: <20190604005233.12312-1-chasel.chiu@intel.com> References: <20190604005233.12312-1-chasel.chiu@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,chasel.chiu@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1559609559; bh=/YIJFkyEVtxfryyXpctlJ235Oj/TptB8+EbCZv+ySqY=; h=Cc:Date:From:Reply-To:Subject:To; b=q3TDEjYA6GOGA3+moKL3ftByY/L2V5ZyeOM8k/hj1+O9Z0SQzIIjNceZJNjXbTRmAlv LfN/Zd27I1yz2Y6jEKluu6C0IxMnu82+W9uOykCmpCkfoev7r8G3rXjeH1eEeGCNVHNKi 84y7GVKSvibVGpEZwaJ7VLBp078YnqlmXsk= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Chasel, Chiu" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1873 In dispatch mode FSP-S contains DXE drivers so needs to BuildFvHob for DXE dispatcher to dispatch this FV. Test: FSP API mode still boots successfully without impact. Cc: Michael Kubacki Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Chasel Chiu Reviewed-by: Nate DeSimone --- Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobProcessLi= b/FspWrapperHobProcessLib.c | 19 ++++++++++++++++--- Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobProcessLi= b/PeiFspWrapperHobProcessLib.inf | 5 ++++- 2 files changed, 20 insertions(+), 4 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapper= HobProcessLib/FspWrapperHobProcessLib.c b/Platform/Intel/MinPlatformPkg/Fsp= Wrapper/Library/PeiFspWrapperHobProcessLib/FspWrapperHobProcessLib.c index e8df06dfb7..7ee4d3a31c 100644 --- a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobProc= essLib/FspWrapperHobProcessLib.c +++ b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobProc= essLib/FspWrapperHobProcessLib.c @@ -1,7 +1,7 @@ /** @file Provide FSP wrapper hob process related function. =20 -Copyright (c) 2017, Intel Corporation. All rights reserved.
+Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ @@ -653,8 +653,21 @@ PostFspsHobProcess ( { EFI_STATUS Status; =20 - ProcessFspHobList (FspHobList); - + if (PcdGet8 (PcdFspModeSelection) =3D=3D 1) { + // + // Only in FSP API mode the wrapper has to build hobs basing on FSP ou= tput data. + // + ASSERT (FspHobList !=3D NULL); + ProcessFspHobList (FspHobList); + } else { + // + // Only in FSP Dispatch mode, FSP-S should be reported to DXE dispatch= er. + // + BuildFvHob ( + (EFI_PHYSICAL_ADDRESS) (UINTN) PcdGet32 (PcdFlashFvFspSBase), + PcdGet32 (PcdFlashFvFspSSize) + ); + } CheckFspGraphicsDeviceInfoHob (); DEBUG_CODE_BEGIN (); DumpFspSmbiosMemoryInfoHob (); diff --git a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapper= HobProcessLib/PeiFspWrapperHobProcessLib.inf b/Platform/Intel/MinPlatformPk= g/FspWrapper/Library/PeiFspWrapperHobProcessLib/PeiFspWrapperHobProcessLib.= inf index a76e3195d6..64f3302959 100644 --- a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobProc= essLib/PeiFspWrapperHobProcessLib.inf +++ b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperHobProc= essLib/PeiFspWrapperHobProcessLib.inf @@ -1,7 +1,7 @@ ## @file # Provide FSP wrapper hob process related function. # -# Copyright (c) 2017, Intel Corporation. All rights reserved.
+# Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -65,6 +65,9 @@ gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress gMinPlatformPkgTokenSpaceGuid.PcdPciExpressRegionLength gMinPlatformPkgTokenSpaceGuid.PcdFspCpuPeiApWakeupBufferAddr + gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection + gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSBase + gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSSize =20 [Guids] gFspReservedMemoryResourceHobGuid ## CONSUMES ## H= OB --=20 2.13.3.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41845): https://edk2.groups.io/g/devel/message/41845 Mute This Topic: https://groups.io/mt/31917294/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun Apr 28 21:37:24 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+41846+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+41846+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1559609561; cv=none; d=zoho.com; s=zohoarc; b=R+JI/hM8uuBryfQ7F+chg1bUpv6y1RClXLSQFo4+1UdzLBsRuX7mx4wc15676HxxAjQtSFLlnum/wTweQ1qEwZjNQCThKifs17GesKLZ8TvPYKqF3YqqSKDE6MF4uIlZHKmKYUeD7sajC26I2YtR25nkGlHOnpnRq3dcJQLC4Zw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559609561; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=7NBdvX2u4bTTaUZDaMRLK0RU2gfcDCUR9tHJfZ1B9Gg=; b=kahsiD9MgcT9WHfDDkuWq/dCDqwWd47b88xNYz6S4RyeH1QxlMHmj26qmDhShuyQxhhYl561G0e3tY118N3viQh4x83q3j21LItxG5XlGJVdHvh2t9XV3uf13GEbdhBVjq4BIAk2KqHYuI8mti4//s2xXgEZCuNNLxIhHQMoeqY= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+41846+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1559609560985520.1531832498814; Mon, 3 Jun 2019 17:52:40 -0700 (PDT) Return-Path: X-Received: from mga02.intel.com (mga02.intel.com []) by groups.io with SMTP; Mon, 03 Jun 2019 17:52:40 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jun 2019 17:52:39 -0700 X-ExtLoop1: 1 X-Received: from cchiu4-mobl1.gar.corp.intel.com ([10.5.240.40]) by fmsmga008.fm.intel.com with ESMTP; 03 Jun 2019 17:52:38 -0700 From: "Chiu, Chasel" To: devel@edk2.groups.io Cc: "Chasel, Chiu" , Michael Kubacki , Nate DeSimone , Liming Gao Subject: [edk2-devel] [PATCH 2/2] KabylakeOpenBoardPkg: Support DXE drivers in FSP 2.1. Date: Tue, 4 Jun 2019 08:52:33 +0800 Message-Id: <20190604005233.12312-3-chasel.chiu@intel.com> In-Reply-To: <20190604005233.12312-1-chasel.chiu@intel.com> References: <20190604005233.12312-1-chasel.chiu@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,chasel.chiu@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1559609560; bh=5Joq7NNUm0UuaxY3onJ8L5YOTmjqXt29tjJy5W67BMo=; h=Cc:Date:From:Reply-To:Subject:To; b=k+wRKX8G7A0qRaaCim71HUZi3Fvc7UxC3Q/LCXVR2Jv4OcwrZyYE4uBBb5qB2EH5GdD QULDDXTxe0S3KN5UXgNWPAkd+aeHFluKfgfEQD1LFjovYkrlzzBi7IFeIyek/LTq31WgK 5SeJu45itSsDGF604HntbKlMsm6TVEfmwQI= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Chasel, Chiu" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1873 In dispatch mode since FSP DXE drivers will be dispatched directly by boot loader dispatcher, FspWrapperNotifyDxe driver should be skipped. Test: FSP API mode still boots successfully without impact. Cc: Michael Kubacki Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Chasel Chiu Reviewed-by: Nate DeSimone --- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc | 6 ++++= +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf | 9 ++++= +++-- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.= dsc b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc index 1dfe49a7ad..653e17c8e4 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc @@ -329,8 +329,12 @@ # $(PLATFORM_PACKAGE)/PlatformInit/SiliconPolicyDxe/SiliconPolicyDxe.inf $(PLATFORM_PACKAGE)/PlatformInit/PlatformInitDxe/PlatformInitDxe.inf +!if gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection =3D=3D 1 + # + # Below module is used by FSP API mode + # IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.inf - +!endif $(PLATFORM_PACKAGE)/FspWrapper/SaveMemoryConfig/SaveMemoryConfig.inf =20 $(PLATFORM_PACKAGE)/Test/TestPointStubDxe/TestPointStubDxe.inf diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.= fdf b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf index 0cff53e308..24dc29c129 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf @@ -1,7 +1,7 @@ ## @file # FDF file of Platform. # -# Copyright (c) 2017 - 2018, Intel Corporation. All rights reserved.
+# Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -332,7 +332,12 @@ INF MdeModulePkg/Universal/Console/GraphicsOutputDxe/= GraphicsOutputDxe.inf INF ShellPkg/Application/Shell/Shell.inf =20 INF $(PLATFORM_PACKAGE)/PlatformInit/PlatformInitDxe/PlatformInitDxe.inf -INF IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.inf +!if gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection =3D=3D 1 + # + # Below module is used by FSP API mode + # + INF IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.inf +!endif =20 INF $(PLATFORM_PACKAGE)/Test/TestPointStubDxe/TestPointStubDxe.inf =20 --=20 2.13.3.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41846): https://edk2.groups.io/g/devel/message/41846 Mute This Topic: https://groups.io/mt/31917295/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-