From nobody Thu May 2 17:12:37 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+41465+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+41465+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1559031250; cv=none; d=zoho.com; s=zohoarc; b=ninFRRgVVNwHQRASMvohh9LD3v5Igq/MLzADPBVQ077JO7CmjjKfMg/z5LpVVaEJnJ/OYG1wvFbiZJH010PC0zF59KDsstJm+ht6sOV0Eq8yNVU0C7692W+WcOZp9Zhm/t3YJDyBaR3oxPQ6P1wf/cTm1gZp/WMflMi+mel1wEE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559031250; h=Cc:Date:From:List-Id:List-Unsubscribe:Message-ID:Reply-To:Sender:Subject:To:ARC-Authentication-Results; bh=PA1UbFWPTDjn9POHogXZuLBRQfxlUoB1WWS3QQGG480=; b=cHOzoHhjXpT5OwwvJGQhe2FYFggfMdhhr3SxioVO3wUTD1gt38M1v5Gz8V00nJ8Y00oCh0X/BFWnHP0F1Gxl7luGUwjto7rrAllbFNrkdJh0vKNbOBO4TQt+ZaaOfwP4LtZlGHJQo1Z3SS2uGivZcqCiLgMCQ+ou/Li7cGry75E= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+41465+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1559031250477691.2428605155187; Tue, 28 May 2019 01:14:10 -0700 (PDT) Return-Path: X-Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by groups.io with SMTP; Tue, 28 May 2019 01:14:09 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 May 2019 01:14:09 -0700 X-ExtLoop1: 1 X-Received: from jshi19-mobl.ccr.corp.intel.com ([10.254.209.247]) by fmsmga006.fm.intel.com with ESMTP; 28 May 2019 01:14:06 -0700 From: "Steven Shi" To: devel@edk2.groups.io Cc: liming.gao@intel.com, bob.c.feng@intel.com, christian.rodriguez@intel.com Subject: [edk2-devel] [PATCH] BaseTools:Fix the library dependency missing in Binary Cache Date: Tue, 28 May 2019 16:13:40 +0800 Message-Id: <20190528081340.14448-1-steven.shi@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,steven.shi@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1559031250; bh=a8TuHE+7xcik06H6lDFCl8tPKSafK/uDkMe9B/FUGuM=; h=Cc:Date:From:Reply-To:Subject:To; b=H7D1Hst0NUjm94Bi5gwr80ALiEAEckjS/9gyvGCaIcdjehdgA6k78W0bflwCr0xa23E dcHivwnDhzI3z5rOp/AjvgUd2keeRIIzxRyQP2oSzmhUeh3O4RM0gs/ZuZTVRRcyWtQGh WGWiRHjKqnuVGspllXZ/oQCondoavpfzB8o= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=3D1788 The library dependency of a module is wrongly filtered out by binary cache implementation which cause all dependent libraries will not been built prior to the module in the build scheduler and the module build fails if cache miss happen. Cc: Liming Gao Cc: Bob Feng Cc: Christian Rodriguez Signed-off-by: Steven Shi --- BaseTools/Source/Python/build/build.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Source/Python/build/build.py b/BaseTools/Source/Pyth= on/build/build.py index 80ceb98310..673a9379ba 100644 --- a/BaseTools/Source/Python/build/build.py +++ b/BaseTools/Source/Python/build/build.py @@ -593,7 +593,7 @@ class BuildTask: # def AddDependency(self, Dependency): for Dep in Dependency: - if not Dep.BuildObject.IsBinaryModule and not Dep.BuildObject.= CanSkipbyHash(): + if not Dep.BuildObject.IsBinaryModule: self.DependencyList.append(BuildTask.New(Dep)) # BuildT= ask list =20 ## The thread wrapper of LaunchCommand function --=20 2.17.1.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41465): https://edk2.groups.io/g/devel/message/41465 Mute This Topic: https://groups.io/mt/31819545/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-