From nobody Sun May 19 00:17:20 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+41460+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+41460+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1559029946; cv=none; d=zoho.com; s=zohoarc; b=PM0cMVz5TG8zsOLNchPAgz6zvQlMM7wcVnjJKKqnZ6fkZ+s/He4AM7qJzZrpF5VOsXdIyJws7vzz3g6hogfZwXoeuypyeBaTSCyvbO6AGqCxss/nIyACmtUe7SurSTtfxc1jGCqygZOoaC+vGVTnn8YmfI4C4JbwrUIHKqWS5LA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559029946; h=Cc:Date:From:List-Id:List-Unsubscribe:Message-ID:Reply-To:Sender:Subject:To:ARC-Authentication-Results; bh=zc7JZz2OasySU0MlPYWOMAFXsvAY1MF46DJluddoIPw=; b=DXTBkCEkhxV+A9YommMgNBmOzRdHijUT2JcxESLLZkIjb29278/kNCa+OVBOH1As0+JNF9O1I5viEndP6tJAE/YOyEYegiPLRLHt2wh2M/YVSmU8Y6uVe1rhSpjAl7xRXyYH5jHWmj6TdKVN+rVPKEUV495+MAKZmP8x7xFVjdw= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+41460+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1559029946271854.3184922011937; Tue, 28 May 2019 00:52:26 -0700 (PDT) Return-Path: X-Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by groups.io with SMTP; Tue, 28 May 2019 00:52:25 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 May 2019 00:52:24 -0700 X-ExtLoop1: 1 X-Received: from cchiu4-mobl1.gar.corp.intel.com ([10.5.240.30]) by fmsmga004.fm.intel.com with ESMTP; 28 May 2019 00:52:22 -0700 From: "Chiu, Chasel" To: devel@edk2.groups.io Cc: Agyeman Prince , Nate DeSimone , Michael Kubacki Subject: [edk2-devel] [PATCH] Platform/Intel: Add fspapi build parameter Date: Tue, 28 May 2019 15:52:20 +0800 Message-Id: <20190528075220.12576-1-chasel.chiu@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,chasel.chiu@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1559029945; bh=eY1Xo/D/km4XR4Y1FjXygNUwAlhyVVj1aHd2FVVrbEs=; h=Cc:Date:From:Reply-To:Subject:To; b=eSnHjsIpIPGbNwyKP5wNKzqcq/e6SrpO/6tDHL/fYKU2SiFdyjfwph+hHM1EFJoc41d WsrXmvToIlqUZ9rrwCXPsMCmE/5Jkq8YzqeY7jSiIjQKJPysBKsaKR63NSIlKGHOwm6yA /CRVYraJ4a9cb5jUYsV7btIu+ukj1QdkNxY= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1824 Going forward FSP Dispatch mode will be default in KabylakeOpenBoardPkg and requires fspapi build parameter to switch back to FSP API mode. When --fspapi given to build python script it will set gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection to 1, otherwise the PCD will be the default value defined by each *BoardPkg. Test: verified the PCD PcdFspModeSelection can be overridden by new build parameter. Cc: Agyeman Prince Cc: Nate DeSimone Cc: Michael Kubacki Signed-off-by: Chasel Chiu Reviewed-by: Nate DeSimone --- Platform/Intel/build_bios.py | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/Platform/Intel/build_bios.py b/Platform/Intel/build_bios.py index 9effefc0c7..9f8d78f6e8 100644 --- a/Platform/Intel/build_bios.py +++ b/Platform/Intel/build_bios.py @@ -359,6 +359,11 @@ def build(config): command.append("-D") command.append("MAX_SOCKET=3D" + config["MAX_SOCKET"]) =20 + if config.get("API_MODE_FSP_WRAPPER_BUILD", "FALSE") =3D=3D "TRUE": + #Override PCD to enable API mode FSP wrapper. + command.append("--pcd") + command.append("gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelectio= n=3D1") + shell =3D True if os.name =3D=3D "posix": shell =3D False @@ -840,6 +845,9 @@ def get_cmd_config_arguments(arguments): if arguments.fsp is True: result["FSP_WRAPPER_BUILD"] =3D "TRUE" =20 + if arguments.fspapi is True: + result["API_MODE_FSP_WRAPPER_BUILD"] =3D "TRUE" + return result =20 =20 @@ -910,9 +918,12 @@ def get_cmd_arguments(build_config): parser.add_argument("--performance", help=3D"performance build enabled= ", action=3D'store_true', dest=3D"performance") =20 - parser.add_argument("--fsp", help=3D"fsp build enabled", + parser.add_argument("--fsp", help=3D"fsp wrapper build enabled", action=3D'store_true', dest=3D"fsp") =20 + parser.add_argument("--fspapi", help=3D"API mode fsp wrapper build ena= bled", + action=3D'store_true', dest=3D"fspapi") + return parser.parse_args() =20 =20 --=20 2.13.3.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41460): https://edk2.groups.io/g/devel/message/41460 Mute This Topic: https://groups.io/mt/31819454/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-