From nobody Sun Feb 8 15:25:54 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+40782+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+40782+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1558002822; cv=none; d=zoho.com; s=zohoarc; b=BRKAsKzOyv0sGGL8HIC1iY0SvOjJEQp/A7x6WQ6T7SAuMSaDY4zSoSIhPVyeisfIV8dke9tqh+UppDvm+f1LQEdW+v8s16+3MLZcXgZJgUBKWnNRjXZ4cWQDIC76ZGiqjUkdfmc6ScYRp5SQYT5buy1GZpDD1D0zV4uG7c7ArL4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1558002822; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To:ARC-Authentication-Results; bh=K3GCowRVe1ZqzREuJkIWtIu2/2p0ewpgun3AuG82tSM=; b=eklbbX7u+998OQxFIIr2N2ahZIdYHVhopzSlunNgh5v3izORnEZDVHD5aEqdZtLpWLsYa7d8dPEuJxlnHUmB4MqniclHqTfa146MYUIUtN4AjisHGp9w5z297xH3zPNUE2AqVnuTQCxfuyxozGqcjQeZouiqeSZWJ9ZNnmM3Pc4= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+40782+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1558002822972823.1833173813706; Thu, 16 May 2019 03:33:42 -0700 (PDT) Return-Path: X-Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by groups.io with SMTP; Thu, 16 May 2019 03:33:41 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 May 2019 03:33:40 -0700 X-ExtLoop1: 1 X-Received: from shwdeopenpsi068.ccr.corp.intel.com ([10.239.158.73]) by fmsmga005.fm.intel.com with ESMTP; 16 May 2019 03:33:39 -0700 From: "Zeng, Star" To: devel@edk2.groups.io Cc: Star Zeng , Laszlo Ersek , Eric Dong , Ruiyu Ni , Chandana Kumar Subject: [edk2-devel] [PATCH] UefiCpuPkg CpuCommonFeaturesLib: Remove CPU generation check Date: Thu, 16 May 2019 18:33:35 +0800 Message-Id: <20190516103335.76628-1-star.zeng@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,star.zeng@intel.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1558002822; bh=fPE/k3PTK/ij1G+wcHUDj/G68RuX6Bhf4F/G2to6xRM=; h=Cc:Date:From:Reply-To:Subject:To; b=gV9hVwXnRLxuK9j10RR83nUmjuSN6bswE9UKDOk5JT9OX0JfUy72oXGTBJRClcQaJDc rJ6yiM+2cwakAQu9sBBiCj895vvKphZx97CNWPQGcyTRDkDqtcnrd9e6nSYJez50uEzYs kintENYclHysIEewnjXSCVsyiOBB5EU1e94= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1679 The checking to CpuInfo->CpuIdVersionInfoEcx.Bits.AESNI is enough, the checking to CPU generation could be removed, then the code could be reused by more platforms. Cc: Laszlo Ersek Cc: Eric Dong Cc: Ruiyu Ni Cc: Chandana Kumar Signed-off-by: Star Zeng Reviewed-by: Ray Ni --- UefiCpuPkg/Library/CpuCommonFeaturesLib/Aesni.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/Aesni.c b/UefiCpuPkg/L= ibrary/CpuCommonFeaturesLib/Aesni.c index b79446ba3ca9..4a56eec1b267 100644 --- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/Aesni.c +++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/Aesni.c @@ -57,15 +57,9 @@ AesniSupport ( MSR_SANDY_BRIDGE_FEATURE_CONFIG_REGISTER *MsrFeatureConfig; =20 if (CpuInfo->CpuIdVersionInfoEcx.Bits.AESNI =3D=3D 1) { - if (IS_SANDY_BRIDGE_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->Displa= yModel) || - IS_SILVERMONT_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayM= odel) || - IS_XEON_5600_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayMo= del) || - IS_XEON_E7_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayMode= l) || - IS_XEON_PHI_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayMod= el)) { - MsrFeatureConfig =3D (MSR_SANDY_BRIDGE_FEATURE_CONFIG_REGISTER *) Co= nfigData; - ASSERT (MsrFeatureConfig !=3D NULL); - MsrFeatureConfig[ProcessorNumber].Uint64 =3D AsmReadMsr64 (MSR_SANDY= _BRIDGE_FEATURE_CONFIG); - } + MsrFeatureConfig =3D (MSR_SANDY_BRIDGE_FEATURE_CONFIG_REGISTER *) Conf= igData; + ASSERT (MsrFeatureConfig !=3D NULL); + MsrFeatureConfig[ProcessorNumber].Uint64 =3D AsmReadMsr64 (MSR_SANDY_B= RIDGE_FEATURE_CONFIG); return TRUE; } return FALSE; --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#40782): https://edk2.groups.io/g/devel/message/40782 Mute This Topic: https://groups.io/mt/31639184/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-