[edk2-devel] [PATCH v1 0/3] Detect duplicate field values in ACPI tables

Krzysztof Koch posted 3 patches 4 years, 10 months ago
Failed in applying to current master (apply log)
DynamicTablesPkg/Include/Library/TableHelperLib.h                | 48 +++++++++++
DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c | 66 +++++++++++++-
DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c | 90 ++++++++++++++++++--
DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c     | 64 ++++++++++++++
4 files changed, 259 insertions(+), 9 deletions(-)
[edk2-devel] [PATCH v1 0/3] Detect duplicate field values in ACPI tables
Posted by Krzysztof Koch 4 years, 10 months ago
This patch set introduces generic code for finding duplicate elements
in an array and uses it to validate two ACPI tables: MADT and GTDT.

This change is motivated by the need for certain ACPI table field
to have unique values across the entire table.

Changes can be seen at: https://github.com/KrzysztofKoch1/edk2/tree/479_find_duplicate_ids_v1


Krzysztof Koch (3):
  DynamicTablesPkg: Add code for finding duplicate values in arrays
  DynamicTablesPkg: Test for duplicate UIDs in MADT generator
  DynamicTablesPkg: Test for duplicate GT Block frame numbers

 DynamicTablesPkg/Include/Library/TableHelperLib.h                | 48 +++++++++++
 DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c | 66 +++++++++++++-
 DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c | 90 ++++++++++++++++++--
 DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c     | 64 ++++++++++++++
 4 files changed, 259 insertions(+), 9 deletions(-)

--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#40778): https://edk2.groups.io/g/devel/message/40778
Mute This Topic: https://groups.io/mt/31639036/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 0/3] Detect duplicate field values in ACPI tables
Posted by Sami Mujawar 4 years, 9 months ago
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

-----Original Message-----
From: Krzysztof Koch <krzysztof.koch@arm.com> 
Sent: 16 May 2019 11:12 AM
To: devel@edk2.groups.io
Cc: leif.lindholm@linaro.org; Sami Mujawar <Sami.Mujawar@arm.com>; Alexei Fedorov <Alexei.Fedorov@arm.com>; Matteo Carlini <Matteo.Carlini@arm.com>; Stephanie Hughes-Fitt <Stephanie.Hughes-Fitt@arm.com>; nd <nd@arm.com>
Subject: [PATCH v1 0/3] Detect duplicate field values in ACPI tables

This patch set introduces generic code for finding duplicate elements in an array and uses it to validate two ACPI tables: MADT and GTDT.

This change is motivated by the need for certain ACPI table field to have unique values across the entire table.

Changes can be seen at: https://github.com/KrzysztofKoch1/edk2/tree/479_find_duplicate_ids_v1


Krzysztof Koch (3):
  DynamicTablesPkg: Add code for finding duplicate values in arrays
  DynamicTablesPkg: Test for duplicate UIDs in MADT generator
  DynamicTablesPkg: Test for duplicate GT Block frame numbers

 DynamicTablesPkg/Include/Library/TableHelperLib.h                | 48 +++++++++++
 DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c | 66 +++++++++++++-  DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c | 90 ++++++++++++++++++--
 DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c     | 64 ++++++++++++++
 4 files changed, 259 insertions(+), 9 deletions(-)

--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42131): https://edk2.groups.io/g/devel/message/42131
Mute This Topic: https://groups.io/mt/31639036/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 0/3] Detect duplicate field values in ACPI tables
Posted by Sami Mujawar 4 years, 9 months ago
Pushed as 75bf10a68914..ccc97f6df415

-----Original Message-----
From: Sami Mujawar 
Sent: 10 June 2019 08:46 PM
To: devel@edk2.groups.io
Cc: nd <nd@arm.com>
Subject: RE: [PATCH v1 0/3] Detect duplicate field values in ACPI tables

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

-----Original Message-----
From: Krzysztof Koch <krzysztof.koch@arm.com> 
Sent: 16 May 2019 11:12 AM
To: devel@edk2.groups.io
Cc: leif.lindholm@linaro.org; Sami Mujawar <Sami.Mujawar@arm.com>; Alexei Fedorov <Alexei.Fedorov@arm.com>; Matteo Carlini <Matteo.Carlini@arm.com>; Stephanie Hughes-Fitt <Stephanie.Hughes-Fitt@arm.com>; nd <nd@arm.com>
Subject: [PATCH v1 0/3] Detect duplicate field values in ACPI tables

This patch set introduces generic code for finding duplicate elements in an array and uses it to validate two ACPI tables: MADT and GTDT.

This change is motivated by the need for certain ACPI table field to have unique values across the entire table.

Changes can be seen at: https://github.com/KrzysztofKoch1/edk2/tree/479_find_duplicate_ids_v1


Krzysztof Koch (3):
  DynamicTablesPkg: Add code for finding duplicate values in arrays
  DynamicTablesPkg: Test for duplicate UIDs in MADT generator
  DynamicTablesPkg: Test for duplicate GT Block frame numbers

 DynamicTablesPkg/Include/Library/TableHelperLib.h                | 48 +++++++++++
 DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c | 66 +++++++++++++-  DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c | 90 ++++++++++++++++++--
 DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c     | 64 ++++++++++++++
 4 files changed, 259 insertions(+), 9 deletions(-)

--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42132): https://edk2.groups.io/g/devel/message/42132
Mute This Topic: https://groups.io/mt/31639036/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 0/3] Detect duplicate field values in ACPI tables
Posted by Alexei.Fedorov@arm.com 4 years, 9 months ago
Reviewed-by: Alexei Fedorov Alexei.Fedorov@arm.com ( Alexei.Fedorov@arm.com )

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41808): https://edk2.groups.io/g/devel/message/41808
Mute This Topic: https://groups.io/mt/31639036/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-