[edk2-devel] [edk2-platforms][PATCH v1 07/16] Hisilicon/D06: Drop the consume of PcdShellFile

Wu, Hao A posted 16 patches 14 weeks ago

[edk2-devel] [edk2-platforms][PATCH v1 07/16] Hisilicon/D06: Drop the consume of PcdShellFile

Posted by Wu, Hao A 14 weeks ago
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800

After the drop of the consume of GenericBdsLib, there is no module that
will use gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile. This
commit will drop the consume of this PCD.

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Hao A Wu <hao.a.wu@intel.com>
---
 Platform/Hisilicon/D06/D06.dsc | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Platform/Hisilicon/D06/D06.dsc b/Platform/Hisilicon/D06/D06.dsc
index 0c12181a38..bcd57db6bb 100644
--- a/Platform/Hisilicon/D06/D06.dsc
+++ b/Platform/Hisilicon/D06/D06.dsc
@@ -187,7 +187,6 @@
 
 
   gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE
-  gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 }
   gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0x31 }
   gHisiTokenSpaceGuid.PcdSysControlBaseAddress|0x94010000
   gHisiTokenSpaceGuid.PcdMailBoxAddress|0x0000FFF8
-- 
2.12.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#40553): https://edk2.groups.io/g/devel/message/40553
Mute This Topic: https://groups.io/mt/31614328/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms][PATCH v1 07/16] Hisilicon/D06: Drop the consume of PcdShellFile

Posted by Ard Biesheuvel 14 weeks ago
On Tue, 14 May 2019 at 04:08, Hao A Wu <hao.a.wu@intel.com> wrote:
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800
>
> After the drop of the consume of GenericBdsLib, there is no module that
> will use gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile. This
> commit will drop the consume of this PCD.
>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: Hao A Wu <hao.a.wu@intel.com>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---
>  Platform/Hisilicon/D06/D06.dsc | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/Platform/Hisilicon/D06/D06.dsc b/Platform/Hisilicon/D06/D06.dsc
> index 0c12181a38..bcd57db6bb 100644
> --- a/Platform/Hisilicon/D06/D06.dsc
> +++ b/Platform/Hisilicon/D06/D06.dsc
> @@ -187,7 +187,6 @@
>
>
>    gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE
> -  gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 }
>    gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0x31 }
>    gHisiTokenSpaceGuid.PcdSysControlBaseAddress|0x94010000
>    gHisiTokenSpaceGuid.PcdMailBoxAddress|0x0000FFF8
> --
> 2.12.0.windows.1
>

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#40933): https://edk2.groups.io/g/devel/message/40933
Mute This Topic: https://groups.io/mt/31614328/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-