From nobody Mon Feb 9 05:41:38 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+39725+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+39725+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1556504207; cv=none; d=zoho.com; s=zohoarc; b=SoTmvE6JwpzbMubj2nCWrSSHxsOJ84Sd48JplYpvlOS7R8K0QF1jIhCO3lgDGmoivxLR2Yo69PKPGKX8EmBFxwKoGM1x6uSCZ2quKTT175YtjOFgUHx7D8Beb/K2bVmR3s6o1y6+besCZaFlLogEEh6n+J5G+MdG4IG4+ZaIW2Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556504207; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=d7RzdDV1mfe8gti7DdLMq1CJkJ+mq7Kog0n0qv1Bp/8=; b=SS47S0Q2FME4H7+i5zkQitOqWOT5rhaRckEYE3hctn9ObJXI4WoznMMf1JzO8K6qsIuLthNb7StS1JVktmA7VuU298QhjScBFMQP7gVy1zfYXqksLRlRR2KIpKhFstc6jb/yJU5iwIc/nWr2JmdMhJi+lmyeDjw62v6R3kPq0lM= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+39725+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1556504207887577.3648677594591; Sun, 28 Apr 2019 19:16:47 -0700 (PDT) Return-Path: X-Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by groups.io with SMTP; Sun, 28 Apr 2019 19:16:47 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Apr 2019 19:16:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,408,1549958400"; d="scan'208";a="139631973" X-Received: from shwdeopenpsi114.ccr.corp.intel.com ([10.239.157.147]) by orsmga006.jf.intel.com with ESMTP; 28 Apr 2019 19:16:45 -0700 From: "Dandan Bi" To: devel@edk2.groups.io Cc: Michael D Kinney , Kelly Steele , Liming Gao Subject: [edk2-devel] [patch 07/11] QuarkPlatformPkg: Remove PcdFrameworkCompatibilitySupport usage Date: Mon, 29 Apr 2019 10:16:03 +0800 Message-Id: <20190429021607.11304-8-dandan.bi@intel.com> In-Reply-To: <20190429021607.11304-1-dandan.bi@intel.com> References: <20190429021607.11304-1-dandan.bi@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,dandan.bi@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1556504207; bh=CkNzp6iKOXlq9en+KShanZmIsUP0CNTU4UrJY9Ek6UA=; h=Cc:Date:From:Reply-To:Subject:To; b=GC6I1FWkon/GkvG9kL0r/JhbrhkwMOVNc+uxvDHPvIlMpOAOD2PFt8MuFMgxX+4mbJu gQZGM/9rSQ6oIfcHeQtzWRYxnoyR65saK8e7P51PUVGC88T1DAlDDr5aDWpCbAtGMm+Ce OSddYQGMYvfVDEzRe1H65iFLddX1RO2Y/IM= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1464 Currently Framework compatibility support is not needed and PcdFrameworkCompatibilitySupport will be removed from edk2. So remove the usage of this PCD firstly. Cc: Michael D Kinney Cc: Kelly Steele Cc: Liming Gao Signed-off-by: Dandan Bi Reviewed-by: Liming Gao --- .../Pei/PlatformInit/Generic/Recovery.c | 50 ++++++------------- .../Pei/PlatformInit/PlatformEarlyInit.inf | 3 +- 2 files changed, 15 insertions(+), 38 deletions(-) diff --git a/QuarkPlatformPkg/Platform/Pei/PlatformInit/Generic/Recovery.c = b/QuarkPlatformPkg/Platform/Pei/PlatformInit/Generic/Recovery.c index f6a076f757..67299a68b7 100644 --- a/QuarkPlatformPkg/Platform/Pei/PlatformInit/Generic/Recovery.c +++ b/QuarkPlatformPkg/Platform/Pei/PlatformInit/Generic/Recovery.c @@ -1,10 +1,10 @@ /** @file Install Platform EFI_PEI_RECOVERY_MODULE_PPI and Implementation of EFI_PEI_LOAD_RECOVERY_CAPSULE service. =20 -Copyright (c) 2013-2016 Intel Corporation. +Copyright (c) 2013-2019 Intel Corporation. =20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ =20 @@ -195,29 +195,17 @@ Returns: // // If there is an image provider, get the capsule ID // if (ProviderAvailable) { RecoveryCapsuleSize =3D 0; - if (FeaturePcdGet (PcdFrameworkCompatibilitySupport)) { - Status =3D DeviceRecoveryModule->GetRecoveryCapsuleInfo ( - PeiServices, - DeviceRecoveryModule, - 0, - &RecoveryCapsuleSize, - &DeviceId - ); - } else { - Status =3D DeviceRecoveryModule->GetRecoveryCapsuleInfo ( - PeiServices, - DeviceRecoveryModule, - 1, - &RecoveryCapsuleSize, - &DeviceId - ); - - - } + Status =3D DeviceRecoveryModule->GetRecoveryCapsuleInfo ( + PeiServices, + DeviceRecoveryModule, + 1, + &RecoveryCapsuleSize, + &DeviceId + ); =20 if (EFI_ERROR (Status)) { return Status; } =20 @@ -237,26 +225,16 @@ Returns: Buffer =3D NULL; Address =3D (UINTN) AllocatePages ((RecoveryCapsuleSize - 1) / 0x1000 = + 1); ASSERT (Address); =20 Buffer =3D (UINT8 *) (UINTN) Address; - if (FeaturePcdGet (PcdFrameworkCompatibilitySupport)) { - Status =3D DeviceRecoveryModule->LoadRecoveryCapsule ( - PeiServices, - DeviceRecoveryModule, - 0, - Buffer - ); - } else { - Status =3D DeviceRecoveryModule->LoadRecoveryCapsule ( - PeiServices, - DeviceRecoveryModule, - 1, - Buffer - ); - - } + Status =3D DeviceRecoveryModule->LoadRecoveryCapsule ( + PeiServices, + DeviceRecoveryModule, + 1, + Buffer + ); =20 DEBUG ((EFI_D_INFO | EFI_D_LOAD, "LoadRecoveryCapsule Returns: %r\n", = Status)); =20 if (Status =3D=3D EFI_DEVICE_ERROR) { AssertMediaDeviceError (PeiServices); diff --git a/QuarkPlatformPkg/Platform/Pei/PlatformInit/PlatformEarlyInit.i= nf b/QuarkPlatformPkg/Platform/Pei/PlatformInit/PlatformEarlyInit.inf index 617d681d77..df8b0dd3bd 100644 --- a/QuarkPlatformPkg/Platform/Pei/PlatformInit/PlatformEarlyInit.inf +++ b/QuarkPlatformPkg/Platform/Pei/PlatformInit/PlatformEarlyInit.inf @@ -34,11 +34,11 @@ # Recovery.c - provides the platform recoveyr functionality. # MrcWrapper.c - Contains the logic to call MRC PPI and do Framework # memory specific stuff like build memory map, build # resource description hob for DXE phase,etc. # Bootmode.c - Detect boot mode. -# Copyright (c) 2013 - 2016 Intel Corporation. +# Copyright (c) 2013 - 2019 Intel Corporation. # # SPDX-License-Identifier: BSD-2-Clause-Patent # ## =20 @@ -138,11 +138,10 @@ [FeaturePcd] gEfiMdeModulePkgTokenSpaceGuid.PcdRecoveryOnFatUsbDisk gEfiMdeModulePkgTokenSpaceGuid.PcdRecoveryOnDataCD gEfiMdeModulePkgTokenSpaceGuid.PcdRecoveryOnFatFloppyDisk gEfiMdeModulePkgTokenSpaceGuid.PcdRecoveryOnIdeDisk - gEfiMdeModulePkgTokenSpaceGuid.PcdFrameworkCompatibilitySupport gQuarkPlatformTokenSpaceGuid.WaitIfResetDueToError =20 [Pcd] gQuarkPlatformTokenSpaceGuid.PcdEsramStage1Base gQuarkPlatformTokenSpaceGuid.PcdFlashAreaSize --=20 2.18.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#39725): https://edk2.groups.io/g/devel/message/39725 Mute This Topic: https://groups.io/mt/31379000/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-