From nobody Sat Feb 7 07:25:51 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+39683+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+39683+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1556326440; cv=none; d=zoho.com; s=zohoarc; b=Umjlp9y9ht30HkMqTwzGLte42LUE3hib9G3E9c43L2H+eHNjTANxYzDFWSRWMy5yPsQCeR2O1l8b9nwmbAdoNhSLWS6Pq/p+pUAdwsJKlmbhJCVlMzYqpVKReBVJwXq3uHc2w8z/1cyScYzC+JLrjHMhkTnPBXoz7Fho7fCPHH0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556326440; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=w0o+cHcXpyrJSasbf7NUrvk8kJjtA+eYfg/8YSLhP+g=; b=mr6NChSGW90p/uCSedHsRlICRxEcShye84tFtZBbGvH04q0cN//wiZH0TRNTnvMxEUtxn+gR8nk6YguVsj+OUsAgT61EQD29ctAuMdnFR1DjK835JkINJ1XTopAQM8aPGyAjjlSV2zpEpqTQgB8mw13ialiX/JvmFDaauypM7FQ= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+39683+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1556326440550284.61306242151727; Fri, 26 Apr 2019 17:54:00 -0700 (PDT) Return-Path: X-Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Fri, 26 Apr 2019 17:53:59 -0700 X-Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 88CB8307027C; Sat, 27 Apr 2019 00:53:59 +0000 (UTC) X-Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-104.rdu2.redhat.com [10.10.121.104]) by smtp.corp.redhat.com (Postfix) with ESMTP id 795F15D70A; Sat, 27 Apr 2019 00:53:57 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Anthony Perard , Ard Biesheuvel , Jordan Justen , Julien Grall Subject: [edk2-devel] [PATCH 08/16] OvmfPkg/EnrollDefaultKeys: remove unneeded EFIAPI call. conv. specifiers Date: Sat, 27 Apr 2019 02:53:20 +0200 Message-Id: <20190427005328.27005-9-lersek@redhat.com> In-Reply-To: <20190427005328.27005-1-lersek@redhat.com> References: <20190427005328.27005-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Sat, 27 Apr 2019 00:53:59 +0000 (UTC) Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1556326440; bh=wsVVvqkA+qAx6Jus0PfgQaYOt534zEX+Dz3A+U5RLK4=; h=Cc:Date:From:Reply-To:Subject:To; b=hi8FBZVQN7IP1iMW0ZCeZvkqskq70qasBZD+7yWrhrAiShuhv8xDMUygYA32ax7+wRH 7iuJ6doagWyAGOej0Xu43Oj7IGwMEfGiZuI0tO9bpC+io2Xq8Ow7Hw/7CAOVbXVSsfh5/ MLfevUKpQcBylhXQg1wf63ZS1s/4aVXPXio= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" The GetExact(), GetSettings(), PrintSettings() functions are only called from within "EnrollDefaultKeys.c", and none of them take variable arguments. Drop their EFIAPI calling convention specifiers. Cc: Anthony Perard Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Julien Grall Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1747 Signed-off-by: Laszlo Ersek Reviewed-by: Philippe Mathieu-Daude --- OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.c b/OvmfPkg/Enroll= DefaultKeys/EnrollDefaultKeys.c index be0e4d8f8e96..671efef8d6ad 100644 --- a/OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.c +++ b/OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.c @@ -806,17 +806,16 @@ Out: VendorGuid, Status); } return Status; } =20 =20 STATIC EFI_STATUS -EFIAPI GetExact ( IN CHAR16 *VariableName, IN EFI_GUID *VendorGuid, OUT VOID *Data, IN UINTN DataSize, IN BOOLEAN AllowMissing ) { @@ -850,17 +849,16 @@ typedef struct { UINT8 SecureBoot; UINT8 SecureBootEnable; UINT8 CustomMode; UINT8 VendorKeys; } SETTINGS; =20 STATIC EFI_STATUS -EFIAPI GetSettings ( OUT SETTINGS *Settings ) { EFI_STATUS Status; =20 Status =3D GetExact (EFI_SETUP_MODE_NAME, &gEfiGlobalVariableGuid, &Settings->SetupMode, sizeof Settings->SetupMode, FALSE); @@ -889,17 +887,16 @@ GetSettings ( =20 Status =3D GetExact (EFI_VENDOR_KEYS_VARIABLE_NAME, &gEfiGlobalVariableG= uid, &Settings->VendorKeys, sizeof Settings->VendorKeys, FALSE); return Status; } =20 STATIC VOID -EFIAPI PrintSettings ( IN CONST SETTINGS *Settings ) { AsciiPrint ("info: SetupMode=3D%d SecureBoot=3D%d SecureBootEnable=3D%d " "CustomMode=3D%d VendorKeys=3D%d\n", Settings->SetupMode, Settings->Se= cureBoot, Settings->SecureBootEnable, Settings->CustomMode, Settings->VendorKeys= ); } --=20 2.19.1.3.g30247aa5d201 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#39683): https://edk2.groups.io/g/devel/message/39683 Mute This Topic: https://groups.io/mt/31359378/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-