From nobody Mon May 6 02:29:06 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+39494+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+39494+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1556112269; cv=none; d=zoho.com; s=zohoarc; b=ZZJuKWpD7ggwAe5tkZ1sDJKCoN6cDAuUQNJ/TAVPMGvMPufPF9GVMXgfRUYuaXq5MSIWh4Yor8O+5qGEck1wr/TgVaEEO7TAztWy2tBKCjkHReQR8KIPSYm5PEPIkFnpQ5Awde/ZqiFClJNebsIi40eRl4pEtqc+RKpS1NLDK6I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556112269; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=+5yNL3wNVaZ5O1RzY53QSe7FQIO86MFMZxflnfLzeuU=; b=cSdbwFKHfbvn2mby9NGgKScE1bqQPIKSS4nXWP27PrRmozRpYF+Py2R75NiyImxRbU+H4Kb4wF30ykU27BJZdnv4ahlMeb3md8zF4teURqtY3ahQrHiVJ/srI/wF7SPikq4lgYpjajPEcOlUSKxWkgEYMmJsoOeFFTEiIYc8mpI= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+39494+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1556112269566918.750281727033; Wed, 24 Apr 2019 06:24:29 -0700 (PDT) Return-Path: X-Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by groups.io with SMTP; Wed, 24 Apr 2019 06:24:28 -0700 X-Received: by mail-wr1-f66.google.com with SMTP id c12so18976518wrt.8 for ; Wed, 24 Apr 2019 06:24:28 -0700 (PDT) X-Gm-Message-State: APjAAAWZMWEEkBrzlKeIRlgbUisj6Gtr7e/zgrigo7eXAXlXseQEfUc+ g4KGzdWs+vdZlxOMIFkDdlLjfN/z+4D6yg== X-Google-Smtp-Source: APXvYqyhACkYcXty3fmqj+gHUA8npa5etRei/QXYtKH9kKMdlptBda0SWK4LAyKF6JbtrD5pXHMk4g== X-Received: by 2002:adf:e407:: with SMTP id g7mr21009445wrm.47.1556112266648; Wed, 24 Apr 2019 06:24:26 -0700 (PDT) X-Received: from localhost.localdomain (91-167-84-221.subs.proxad.net. [91.167.84.221]) by smtp.gmail.com with ESMTPSA id x18sm21281291wrw.14.2019.04.24.06.24.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Apr 2019 06:24:25 -0700 (PDT) From: "Ard Biesheuvel" To: devel@edk2.groups.io Cc: leif.lindholm@linaro.org, mw@semihalf.com, Ard Biesheuvel Subject: [edk2-devel] [PATCH edk2-platforms v2 1/3] Platform/DeveloperBox: conditionally include the X64 PE/COFF emulator Date: Wed, 24 Apr 2019 15:23:55 +0200 Message-Id: <20190424132357.8565-2-ard.biesheuvel@linaro.org> In-Reply-To: <20190424132357.8565-1-ard.biesheuvel@linaro.org> References: <20190424132357.8565-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ard.biesheuvel@linaro.org Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1556112269; bh=Jik6ttLoWjMCTWyJwd2YpZjcwxoOlDFWvZXUN2t2LT0=; h=Cc:Date:From:Reply-To:Subject:To; b=eqgsLNZ/UT5qVvRyQtyAXBeqw0Tmi5UaOls1Ontbj6FATdOwAxg8tQ3abqjqESSAxHk I3dKFsidST9HWLrMfMH8f5upcTqeAsQv8w+BmZbiso+fWgH/o2LlzSwW1U1GyLtean6li AXHeAfl08enLOR9Wh39wQMc3UJsP1Pzgwgo= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Add the X64 emulator to the build if '-D X64EMU_ENABLE=3DTRUE' is passed on the build command line. Note that this only works on AARCH64 builds. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm --- Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 1 + Platform/Socionext/DeveloperBox/DeveloperBox.fdf | 3 +++ 2 files changed, 4 insertions(+) diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/So= cionext/DeveloperBox/DeveloperBox.dsc index 4ddb0d427f13..909cfb550757 100644 --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc @@ -30,6 +30,7 @@ =20 DEFINE DEBUG_ON_UART1 =3D FALSE DEFINE SECURE_BOOT_ENABLE =3D FALSE + DEFINE X64EMU_ENABLE =3D FALSE =20 !include Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc =20 diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.fdf b/Platform/So= cionext/DeveloperBox/DeveloperBox.fdf index 72997e143de5..e6b42fc2028c 100644 --- a/Platform/Socionext/DeveloperBox/DeveloperBox.fdf +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.fdf @@ -159,6 +159,9 @@ READ_LOCK_STATUS =3D TRUE INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf !if $(ARCH) =3D=3D AARCH64 INF MdeModulePkg/Universal/EbcDxe/EbcDxe.inf +!if $(X64EMU_ENABLE) =3D=3D TRUE + INF Emulator/X86EmulatorDxe/X86EmulatorDxe.inf +!endif !endif INF MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphic= sResourceTableDxe.inf INF MdeModulePkg/Bus/Pci/PciSioSerialDxe/PciSioSerialDxe.inf --=20 2.20.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#39494): https://edk2.groups.io/g/devel/message/39494 Mute This Topic: https://groups.io/mt/31321812/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 6 02:29:06 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+39495+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+39495+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1556112270; cv=none; d=zoho.com; s=zohoarc; b=EFODv83fvbcvFUn1LAi/gj6qPmao5kXBXRJivNmZ+OtPPlDXaLywBSHmEmMavuL18Zv25gz0C2MMDZ+uwZTysU+zjuibuWpV7K2vqJQNxksWsrkvY2vh2yWIYEgJ0AHDdMu20vZJ0b93Rt9jpo2rQFQj3uYdFqUrKtAamuM2TsA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556112270; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=218tOZbSLMESyx3K4VDK2RRW5dMvBTfCrcE19ffQjPg=; b=PzAbe5UGpUdoMTonFTCfvjxLoZ6e4g+HTuMRhX5rOmv6sl3DndKnyEg0CF6/dyTcjf9kQxphkiBikKUh3PdgOMvB5n1NMdwkKAVFs+0k0X2dH5nVKpFyl2Yx3fLwsaxgm8IjdyEGW4mvrEoQQRRWd+5nbIOV+BSPE8KHHDqjyPQ= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+39495+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1556112270937234.95207852026067; Wed, 24 Apr 2019 06:24:30 -0700 (PDT) Return-Path: X-Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by groups.io with SMTP; Wed, 24 Apr 2019 06:24:30 -0700 X-Received: by mail-wr1-f68.google.com with SMTP id b1so13809779wru.3 for ; Wed, 24 Apr 2019 06:24:29 -0700 (PDT) X-Gm-Message-State: APjAAAUxLULpttPoOdArsC5O6ZAKlsEoHgB2EcxqrGDcDk2tW23swtYG oSUjoSc9jjEsi4Ly03AElFShapd8MUGRXw== X-Google-Smtp-Source: APXvYqyCf6I8ijuxbBvjK8cSJNiMBAovu+CQrSlLb5dKJNY3RMIpGoln5nu48TUS6rA8JCY1BGSljw== X-Received: by 2002:a05:6000:9:: with SMTP id h9mr2964739wrx.194.1556112268093; Wed, 24 Apr 2019 06:24:28 -0700 (PDT) X-Received: from localhost.localdomain (91-167-84-221.subs.proxad.net. [91.167.84.221]) by smtp.gmail.com with ESMTPSA id x18sm21281291wrw.14.2019.04.24.06.24.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Apr 2019 06:24:26 -0700 (PDT) From: "Ard Biesheuvel" To: devel@edk2.groups.io Cc: leif.lindholm@linaro.org, mw@semihalf.com, Ard Biesheuvel Subject: [edk2-devel] [PATCH edk2-platforms v2 2/3] Platform/Overdrive: conditionally include the X64 PE/COFF emulator Date: Wed, 24 Apr 2019 15:23:56 +0200 Message-Id: <20190424132357.8565-3-ard.biesheuvel@linaro.org> In-Reply-To: <20190424132357.8565-1-ard.biesheuvel@linaro.org> References: <20190424132357.8565-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ard.biesheuvel@linaro.org Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1556112270; bh=Jw7gYP/MJvibgg8Tk+RnIig+4blRJjCTU9r/avtSTGs=; h=Cc:Date:From:Reply-To:Subject:To; b=IhojRCTB2vGDtzqN5EzVMUVbuamJhgpyVMP66mzc+nBOr1WkQnT6i7BlXcRfSxPDcID XlMbfzgTWGtCjPt7I+njFA3ZgsuhcXcAtRKKZZHIrL786WTiAej/3qSve5ABSsKNm2tmX o7nvNvVUaZCcWYi1rMFPMmX8WqJgEKox0wk= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Add the X64 emulator to the build if '-D X64EMU_ENABLE=3DTRUE' is passed on the build command line. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm --- Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 5 +++-- Platform/AMD/OverdriveBoard/OverdriveBoard.fdf | 3 +++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/= OverdriveBoard/OverdriveBoard.dsc index b6a1507b4ae3..0e1db0745d89 100644 --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc @@ -17,8 +17,9 @@ ##########################################################################= ###### [Defines] =20 -DEFINE NUM_CORES =3D 8 -DEFINE DO_FLASHER =3D FALSE +DEFINE NUM_CORES =3D 8 +DEFINE DO_FLASHER =3D FALSE +DEFINE X64EMU_ENABLE =3D FALSE =20 PLATFORM_NAME =3D Overdrive PLATFORM_GUID =3D B2296C02-9DA1-4CD1-BD48-4D4F0F1276EB diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.fdf b/Platform/AMD/= OverdriveBoard/OverdriveBoard.fdf index 4b6b808c1454..a058665bccdd 100644 --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.fdf +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.fdf @@ -159,6 +159,9 @@ READ_LOCK_STATUS =3D TRUE INF MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf INF MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf +!if $(X64EMU_ENABLE) =3D=3D TRUE + INF Emulator/X86EmulatorDxe/X86EmulatorDxe.inf +!endif =20 # # AHCI Support --=20 2.20.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#39495): https://edk2.groups.io/g/devel/message/39495 Mute This Topic: https://groups.io/mt/31321813/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 6 02:29:06 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+39496+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+39496+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1556112272; cv=none; d=zoho.com; s=zohoarc; b=dLWQm9r7dJMzC54qQIuh+yJCcW0TDdOlJcamAdpykkS/y5dIGxhZY5BRBDL9z7TNItFjT4AiCzT06tR/3MQccrs1aGlbjTeTPM1aVvQvYdaoeT8VlQ0TE9bop4wyVHM+7oqK77y9vvJkHZWlcjZDPWoYC9vXJWF7D13VYsDos40= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1556112272; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=z/T5tWvbT7p/QYqy39NFClATrh5uDNyAUuiuxk+PkH4=; b=MZOSvLTZgqlY/ghD0vLDTbHy0nnatdOBmM80fzcZQayp5Y1lAeXvX0EcAlqTNSdOjcBBpT+w4TGzi0l/briRWuOWQdx6DIQ9Wqt3DXrLwHqnnGmahCwrvFhWo74m3ek5pfzq/Ry3sqyyd6rgvoaMEkNnoGOERaWEDBCc8MFoGz8= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+39496+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 155611227206836.90879697989692; Wed, 24 Apr 2019 06:24:32 -0700 (PDT) Return-Path: X-Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by groups.io with SMTP; Wed, 24 Apr 2019 06:24:31 -0700 X-Received: by mail-wr1-f66.google.com with SMTP id t17so13422501wrr.4 for ; Wed, 24 Apr 2019 06:24:30 -0700 (PDT) X-Gm-Message-State: APjAAAWTGYrZ2dsljcyviMsNLSJ3Z23a8TWhWeUswOfj2wtkQCeYI2Yc udYQGYPEl8Sa+Iepyg5Nq8tn9wcP4mGZig== X-Google-Smtp-Source: APXvYqweGHY7JEzEt87k+mL8ui4YY/nAxtQvhBftvJmbpPnGUwcrqVAFLBtYN0jN+QVTqSvB/LoKsg== X-Received: by 2002:a5d:664c:: with SMTP id f12mr22553070wrw.302.1556112269275; Wed, 24 Apr 2019 06:24:29 -0700 (PDT) X-Received: from localhost.localdomain (91-167-84-221.subs.proxad.net. [91.167.84.221]) by smtp.gmail.com with ESMTPSA id x18sm21281291wrw.14.2019.04.24.06.24.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Apr 2019 06:24:28 -0700 (PDT) From: "Ard Biesheuvel" To: devel@edk2.groups.io Cc: leif.lindholm@linaro.org, mw@semihalf.com, Ard Biesheuvel Subject: [edk2-devel] [PATCH edk2-platforms v2 3/3] Platform/MacchiatoBin: conditionally include the X64 PE/COFF emulator Date: Wed, 24 Apr 2019 15:23:57 +0200 Message-Id: <20190424132357.8565-4-ard.biesheuvel@linaro.org> In-Reply-To: <20190424132357.8565-1-ard.biesheuvel@linaro.org> References: <20190424132357.8565-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ard.biesheuvel@linaro.org Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1556112271; bh=dwc5lqv/eMQ80WtKcTr0hG1uw3ku7OkHebmyTIbc7gM=; h=Cc:Date:From:Reply-To:Subject:To; b=m9je7Rk3szSHmoE7IwpgOe7mQTFlyRb9fvisOJIGY5MBLXLZPij3aPDxqUj6/JvZubK jdttLp9vZG6bx4N8Pg+zis84iGTZYRub+eG3k6THKSjy8sAJ2+cWIIUNsiOmAN8icirnA skQ+hi9UcA9wNijlw7erKVV95FgsAdR0ElM= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Add the X64 emulator to the build if '-D X64EMU_ENABLE=3DTRUE' is passed on the build command line. Note that this only works on AARCH64 builds. Also note that the edk2-non-osi repository needs to be listed in the PACKAGES_PATH environment variable. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm --- Silicon/Marvell/Armada7k8k/Armada7k8k.fdf | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.fdf b/Silicon/Marvell/Ar= mada7k8k/Armada7k8k.fdf index e90e10e69623..ccfeb90102a2 100644 --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.fdf +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.fdf @@ -220,6 +220,10 @@ FvNameGuid =3D 5eda4200-2c5f-43cb-9da3-0baf74b= 1b30c # ACPI support INF MdeModulePkg/Universal/Acpi/AcpiPlatformDxe/AcpiPlatformDxe.inf INF MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf +!if $(X64EMU_ENABLE) =3D=3D TRUE + # PE/COFF emulator for X64 option ROMs taken from edk2-non-osi + INF Emulator/X86EmulatorDxe/X86EmulatorDxe.inf +!endif !endif =20 !include $(BOARD_DXE_FV_COMPONENTS) --=20 2.20.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#39496): https://edk2.groups.io/g/devel/message/39496 Mute This Topic: https://groups.io/mt/31321814/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-