From nobody Mon Feb 9 09:32:29 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+39309+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+39309+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1555609648; cv=none; d=zoho.com; s=zohoarc; b=cfxPPJcTfCc8/P/PN2yPIzqWLgDhzmYnqIB9a8nI0meEF26SGtLlmse8J4xn75FoVTlNqVn1Gm+AhhbO1IGNIgCLL+Ru1Q+p0PSp1VBG+igsqgNkmg78rcamWVWVA6MubVFQCqeccLw2+731O91FFPWPeBgQayKUuw/NFjdXOis= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1555609648; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=fA4Yq2Q0qjwWgOaBX+9OkSLifr5R19IqZmTBXDa9evM=; b=kZ1tO0CMoth80+vghiWTbYHylNMtCjIpluTQmsoQSPBH4e1xQ+aptNMjXfdwEYnKNJCxSIXW2ebIh+AkFb/Gi5udTIC7/MO4J6v7YJthbbD09F1k6bBUKGwbkbFCKbM5mxyToOZTCgayX9lRk8DcGwquQBqzFY8+PpZ5eSnb9UU= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+39309+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1555609648673639.4605465878136; Thu, 18 Apr 2019 10:47:28 -0700 (PDT) Return-Path: X-Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Thu, 18 Apr 2019 10:47:27 -0700 X-Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 77C4E307DAC8; Thu, 18 Apr 2019 17:47:27 +0000 (UTC) X-Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-179.rdu2.redhat.com [10.10.120.179]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3CDEF600C1; Thu, 18 Apr 2019 17:47:26 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Bob Feng , Liming Gao , Yonghong Zhu Subject: [edk2-devel] [PATCH v2 3/5] BaseTools/PiFirmwareFile: fix undefined behavior in SECTION_SIZE Date: Thu, 18 Apr 2019 19:47:08 +0200 Message-Id: <20190418174710.12236-4-lersek@redhat.com> In-Reply-To: <20190418174710.12236-1-lersek@redhat.com> References: <20190418174710.12236-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Thu, 18 Apr 2019 17:47:27 +0000 (UTC) Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1555609648; bh=hCTUE/nBGoWvOCjGTaOgzF1I1ga7QuR2eAC3rnuWIYA=; h=Cc:Date:From:Reply-To:Subject:To; b=rchI+ef6ZUsMRMEWtLA+yagPf5AL3LORmBk73bsY7j5scm8hG3PjWKqD5qjz4KE5+5m QtMEcIFTj5Oy8Anblmwo2NWqsPtH9T5BWwcHWO6R9IbKi/+R527XZoLMyhp44zdlnJwP7 5LP3iVhB0X9DkDGIxe283doqK70RBg5zAMQ= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Sync SECTION_SIZE() from MdePkg to BaseTools, from an earlier patch in this series. Cc: Bob Feng Cc: Liming Gao Cc: Yonghong Zhu Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1710 Signed-off-by: Laszlo Ersek Reviewed-by: Bob Feng Reviewed-by: Liming Gao Reviewed-by: Philippe Mathieu-Daude --- Notes: v2: =20 - sync with the v2 MdePkg/PiFirmwareFile SECTION_SIZE patch BaseTools/Source/C/Include/Common/PiFirmwareFile.h | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/BaseTools/Source/C/Include/Common/PiFirmwareFile.h b/BaseTools= /Source/C/Include/Common/PiFirmwareFile.h index 5bc871df4855..7d8acb669b69 100644 --- a/BaseTools/Source/C/Include/Common/PiFirmwareFile.h +++ b/BaseTools/Source/C/Include/Common/PiFirmwareFile.h @@ -300,8 +300,15 @@ typedef struct { CHAR16 VersionString[1]; } EFI_VERSION_SECTION2; =20 -#define SECTION_SIZE(SectionHeaderPtr) \ - ((UINT32) (*((UINT32 *) ((EFI_COMMON_SECTION_HEADER *) SectionHeaderPt= r)->Size) & 0x00ffffff)) +// +// The argument passed as the SectionHeaderPtr parameter to the SECTION_SI= ZE() +// function-like macro below must not have side effects: SectionHeaderPtr = is +// evaluated multiple times. +// +#define SECTION_SIZE(SectionHeaderPtr) ((UINT32) ( \ + (((EFI_COMMON_SECTION_HEADER *) (SectionHeaderPtr))->Size[0] ) | \ + (((EFI_COMMON_SECTION_HEADER *) (SectionHeaderPtr))->Size[1] << 8) | \ + (((EFI_COMMON_SECTION_HEADER *) (SectionHeaderPtr))->Size[2] << 16))) =20 #pragma pack() =20 --=20 2.19.1.3.g30247aa5d201 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#39309): https://edk2.groups.io/g/devel/message/39309 Mute This Topic: https://groups.io/mt/31233851/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-