From nobody Thu Apr 18 07:28:26 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail(p=none dis=none) header.from=intel.com Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1534213119856911.4310048694816; Mon, 13 Aug 2018 19:18:39 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 689DA210EE4FC; Mon, 13 Aug 2018 19:18:37 -0700 (PDT) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 44CCE21BADAB2 for ; Mon, 13 Aug 2018 19:18:35 -0700 (PDT) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Aug 2018 19:18:35 -0700 Received: from shenglei-dev.ccr.corp.intel.com ([10.239.158.52]) by fmsmga002.fm.intel.com with ESMTP; 13 Aug 2018 19:18:34 -0700 X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=shenglei.zhang@intel.com; receiver=edk2-devel@lists.01.org X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,236,1531810800"; d="scan'208";a="76473913" From: shenglei To: edk2-devel@lists.01.org Date: Tue, 14 Aug 2018 10:18:28 +0800 Message-Id: <20180814021828.16936-1-shenglei.zhang@intel.com> X-Mailer: git-send-email 2.18.0.windows.1 Subject: [edk2] [PATCH v2] SignedCapsulePkg: Remove redundant things in inf, .h and .c files X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jiewen Yao MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RDMRC_1 RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Two redundant library classes have been removed. The redundant function "IsSystemFmp" has been removed. https://bugzilla.tianocore.org/show_bug.cgi?id=3D1067 v2: Remove DxeServicesLib from SystemFirmwareUpdateDxe.inf. Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei Reviewed-by: Jiewen Yao Reviewed-by: Star Zeng --- .../SystemFirmwareCommonDxe.c | 27 ------------------- .../SystemFirmwareUpdate/SystemFirmwareDxe.h | 1 - .../SystemFirmwareReportDxe.inf | 2 -- .../SystemFirmwareUpdateDxe.inf | 1 - 4 files changed, 31 deletions(-) diff --git a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmware= CommonDxe.c b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwar= eCommonDxe.c index 7f7a9a1982..8e16763597 100644 --- a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCommonD= xe.c +++ b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCommonD= xe.c @@ -343,31 +343,4 @@ InitializePrivateData ( return EFI_SUCCESS; } =20 -/** - Return if this FMP is a system FMP or a device FMP, based upon FmpImageI= nfo. - - @param[in] FmpImageInfo A pointer to EFI_FIRMWARE_IMAGE_DESCRIPTOR - - @retval TRUE It is a system FMP. - @retval FALSE It is a device FMP. -**/ -BOOLEAN -IsSystemFmp ( - IN EFI_FIRMWARE_IMAGE_DESCRIPTOR *FmpImageInfo - ) -{ - GUID *Guid; - UINTN Count; - UINTN Index; - - Guid =3D PcdGetPtr(PcdSystemFmpCapsuleImageTypeIdGuid); - Count =3D PcdGetSize(PcdSystemFmpCapsuleImageTypeIdGuid) / sizeof(GUID); =20 - for (Index =3D 0; Index < Count; Index++, Guid++) { - if (CompareGuid(&FmpImageInfo->ImageTypeId, Guid)) { - return TRUE; - } - } - - return FALSE; -} diff --git a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmware= Dxe.h b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe.h index 999b2b2501..cd6601e815 100644 --- a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe.h +++ b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe.h @@ -36,7 +36,6 @@ #include #include #include -#include #include #include #include diff --git a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmware= ReportDxe.inf b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmw= areReportDxe.inf index cc9614ef14..b15736cf0d 100644 --- a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareReportD= xe.inf +++ b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareReportD= xe.inf @@ -50,9 +50,7 @@ HobLib UefiRuntimeServicesTableLib UefiDriverEntryPoint - DxeServicesLib DxeServicesTableLib - PrintLib EdkiiSystemCapsuleLib =20 [Pcd] diff --git a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmware= UpdateDxe.inf b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmw= areUpdateDxe.inf index 2695fb6eb5..7ddea3679e 100644 --- a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdateD= xe.inf +++ b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdateD= xe.inf @@ -51,7 +51,6 @@ HobLib UefiRuntimeServicesTableLib UefiDriverEntryPoint - DxeServicesLib EdkiiSystemCapsuleLib PlatformFlashAccessLib IniParsingLib --=20 2.18.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel