[edk2] [Patch 0/4] Vlv2TbltDevicePkg: Add FmpDevicePkg support

Michael D Kinney posted 4 patches 17 weeks ago
Failed in applying to current master (apply log)
.../Capsule/GenerateCapsule/GenCapsuleAll.bat      |  35 ++
.../GenerateCapsule/GenCapsuleMinnowMax.bat        | 139 +++++
.../GenerateCapsule/GenCapsuleMinnowMaxRelease.bat | 139 +++++
.../GenerateCapsule/GenCapsuleSampleColor.bat      | 145 +++++
...kenSpaceGuid.PcdFmpDevicePkcs7CertBufferXdr.inc |   1 +
...kenSpaceGuid.PcdFmpDevicePkcs7CertBufferXdr.inc |   1 +
...kenSpaceGuid.PcdFmpDevicePkcs7CertBufferXdr.inc |   1 +
.../Capsule/Library/FmpDeviceLib/FmpDeviceLib.c    | 607 +++++++++++++++++++++
.../Capsule/Library/FmpDeviceLib/FmpDeviceLib.inf  |  63 +++
.../Library/FmpDeviceLibSample/FmpDeviceLib.c      | 429 +++++++++++++++
.../Library/FmpDeviceLibSample/FmpDeviceLib.inf    |  51 ++
Vlv2TbltDevicePkg/FmpBlueSampleDevice.dsc          |  61 +++
Vlv2TbltDevicePkg/FmpCertificate.dsc               |  28 +
Vlv2TbltDevicePkg/FmpGreenSampleDevice.dsc         |  61 +++
Vlv2TbltDevicePkg/FmpMinnowMaxSystem.dsc           |  65 +++
Vlv2TbltDevicePkg/FmpRedSampleDevice.dsc           |  61 +++
.../Library/GenericBdsLib/BdsConsole.c             |  11 +
.../Library/GenericBdsLib/GenericBdsLib.inf        |   1 +
Vlv2TbltDevicePkg/PlatformCapsule.dsc              |   1 +
Vlv2TbltDevicePkg/PlatformCapsule.fdf              |  23 -
Vlv2TbltDevicePkg/PlatformCapsuleGcc.fdf           |  23 -
Vlv2TbltDevicePkg/PlatformPkg.dec                  |   5 +
Vlv2TbltDevicePkg/PlatformPkg.fdf                  |  61 +--
Vlv2TbltDevicePkg/PlatformPkgConfig.dsc            |  19 +-
Vlv2TbltDevicePkg/PlatformPkgGcc.fdf               |  61 +--
Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc            |  66 +--
Vlv2TbltDevicePkg/PlatformPkgIA32.dsc              |  64 +--
Vlv2TbltDevicePkg/PlatformPkgX64.dsc               |  62 +--
28 files changed, 2032 insertions(+), 252 deletions(-)
create mode 100644 Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleAll.bat
create mode 100644 Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleMinnowMax.bat
create mode 100644 Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleMinnowMaxRelease.bat
create mode 100644 Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleSampleColor.bat
create mode 100644 Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/NewRoot.cer.gFmpDevicePkgTokenSpaceGuid.PcdFmpDevicePkcs7CertBufferXdr.inc
create mode 100644 Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/SAMPLE_DEVELOPMENT.cer.gFmpDevicePkgTokenSpaceGuid.PcdFmpDevicePkcs7CertBufferXdr.inc
create mode 100644 Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/SAMPLE_DEVELOPMENT_SAMPLE_PRODUCTION.cer.gFmpDevicePkgTokenSpaceGuid.PcdFmpDevicePkcs7CertBufferXdr.inc
create mode 100644 Vlv2TbltDevicePkg/Feature/Capsule/Library/FmpDeviceLib/FmpDeviceLib.c
create mode 100644 Vlv2TbltDevicePkg/Feature/Capsule/Library/FmpDeviceLib/FmpDeviceLib.inf
create mode 100644 Vlv2TbltDevicePkg/Feature/Capsule/Library/FmpDeviceLibSample/FmpDeviceLib.c
create mode 100644 Vlv2TbltDevicePkg/Feature/Capsule/Library/FmpDeviceLibSample/FmpDeviceLib.inf
create mode 100644 Vlv2TbltDevicePkg/FmpBlueSampleDevice.dsc
create mode 100644 Vlv2TbltDevicePkg/FmpCertificate.dsc
create mode 100644 Vlv2TbltDevicePkg/FmpGreenSampleDevice.dsc
create mode 100644 Vlv2TbltDevicePkg/FmpMinnowMaxSystem.dsc
create mode 100644 Vlv2TbltDevicePkg/FmpRedSampleDevice.dsc

[edk2] [Patch 0/4] Vlv2TbltDevicePkg: Add FmpDevicePkg support

Posted by Michael D Kinney 17 weeks ago
Update Vlv2TbltDevicePkg to build UEFI capsules for system firmare and device
firmware using the GenerateCapsule tool and use the FmpDevicePkg to implement
drivers that produce the Firmware Management Protocol to process UEFI capsules.

* Update Vlv2TbltDevicePkg specific BDS to notify when test key is detected.
* Add FmpDeviceLib instance for Minnow Max FLASH update
* Add FmpDeviceLib instance for sample devices
* Add scripts to generate UEFI Capsules for system and device firmware
* Update Vlv2TbltDevicePkg DSC/FDF to use FmpDevicePkg

Cc: David Wei <david.wei@intel.com>
Cc: Mang Guo <mang.guo@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>

Kinney, Michael D (1):
  Vlv2TbltDevicePkg/Override/Bds: Add test key notification

Michael D Kinney (3):
  Vlv2TbltDevicePkg/Feature/Capsule: Add FmpDeviceLib instances
  Vlv2TbltDevicePkg/Capsule: Add scripts to generate capsules
  Vlv2TbltDevicePkg: Update DSC/FDF to use FmpDevicePkg

 .../Capsule/GenerateCapsule/GenCapsuleAll.bat      |  35 ++
 .../GenerateCapsule/GenCapsuleMinnowMax.bat        | 139 +++++
 .../GenerateCapsule/GenCapsuleMinnowMaxRelease.bat | 139 +++++
 .../GenerateCapsule/GenCapsuleSampleColor.bat      | 145 +++++
 ...kenSpaceGuid.PcdFmpDevicePkcs7CertBufferXdr.inc |   1 +
 ...kenSpaceGuid.PcdFmpDevicePkcs7CertBufferXdr.inc |   1 +
 ...kenSpaceGuid.PcdFmpDevicePkcs7CertBufferXdr.inc |   1 +
 .../Capsule/Library/FmpDeviceLib/FmpDeviceLib.c    | 607 +++++++++++++++++++++
 .../Capsule/Library/FmpDeviceLib/FmpDeviceLib.inf  |  63 +++
 .../Library/FmpDeviceLibSample/FmpDeviceLib.c      | 429 +++++++++++++++
 .../Library/FmpDeviceLibSample/FmpDeviceLib.inf    |  51 ++
 Vlv2TbltDevicePkg/FmpBlueSampleDevice.dsc          |  61 +++
 Vlv2TbltDevicePkg/FmpCertificate.dsc               |  28 +
 Vlv2TbltDevicePkg/FmpGreenSampleDevice.dsc         |  61 +++
 Vlv2TbltDevicePkg/FmpMinnowMaxSystem.dsc           |  65 +++
 Vlv2TbltDevicePkg/FmpRedSampleDevice.dsc           |  61 +++
 .../Library/GenericBdsLib/BdsConsole.c             |  11 +
 .../Library/GenericBdsLib/GenericBdsLib.inf        |   1 +
 Vlv2TbltDevicePkg/PlatformCapsule.dsc              |   1 +
 Vlv2TbltDevicePkg/PlatformCapsule.fdf              |  23 -
 Vlv2TbltDevicePkg/PlatformCapsuleGcc.fdf           |  23 -
 Vlv2TbltDevicePkg/PlatformPkg.dec                  |   5 +
 Vlv2TbltDevicePkg/PlatformPkg.fdf                  |  61 +--
 Vlv2TbltDevicePkg/PlatformPkgConfig.dsc            |  19 +-
 Vlv2TbltDevicePkg/PlatformPkgGcc.fdf               |  61 +--
 Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc            |  66 +--
 Vlv2TbltDevicePkg/PlatformPkgIA32.dsc              |  64 +--
 Vlv2TbltDevicePkg/PlatformPkgX64.dsc               |  62 +--
 28 files changed, 2032 insertions(+), 252 deletions(-)
 create mode 100644 Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleAll.bat
 create mode 100644 Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleMinnowMax.bat
 create mode 100644 Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleMinnowMaxRelease.bat
 create mode 100644 Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleSampleColor.bat
 create mode 100644 Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/NewRoot.cer.gFmpDevicePkgTokenSpaceGuid.PcdFmpDevicePkcs7CertBufferXdr.inc
 create mode 100644 Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/SAMPLE_DEVELOPMENT.cer.gFmpDevicePkgTokenSpaceGuid.PcdFmpDevicePkcs7CertBufferXdr.inc
 create mode 100644 Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/SAMPLE_DEVELOPMENT_SAMPLE_PRODUCTION.cer.gFmpDevicePkgTokenSpaceGuid.PcdFmpDevicePkcs7CertBufferXdr.inc
 create mode 100644 Vlv2TbltDevicePkg/Feature/Capsule/Library/FmpDeviceLib/FmpDeviceLib.c
 create mode 100644 Vlv2TbltDevicePkg/Feature/Capsule/Library/FmpDeviceLib/FmpDeviceLib.inf
 create mode 100644 Vlv2TbltDevicePkg/Feature/Capsule/Library/FmpDeviceLibSample/FmpDeviceLib.c
 create mode 100644 Vlv2TbltDevicePkg/Feature/Capsule/Library/FmpDeviceLibSample/FmpDeviceLib.inf
 create mode 100644 Vlv2TbltDevicePkg/FmpBlueSampleDevice.dsc
 create mode 100644 Vlv2TbltDevicePkg/FmpCertificate.dsc
 create mode 100644 Vlv2TbltDevicePkg/FmpGreenSampleDevice.dsc
 create mode 100644 Vlv2TbltDevicePkg/FmpMinnowMaxSystem.dsc
 create mode 100644 Vlv2TbltDevicePkg/FmpRedSampleDevice.dsc

-- 
2.14.2.windows.3

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [Patch 0/4] Vlv2TbltDevicePkg: Add FmpDevicePkg support

Posted by Guo, Mang 17 weeks ago
Reviewed-by: Guo Mang <mang.guo@intel.com>


-----Original Message-----
From: Kinney, Michael D 
Sent: Friday, August 10, 2018 9:28 AM
To: edk2-devel@lists.01.org
Cc: Wei, David; Guo, Mang
Subject: [Patch 0/4] Vlv2TbltDevicePkg: Add FmpDevicePkg support

Update Vlv2TbltDevicePkg to build UEFI capsules for system firmare and device
firmware using the GenerateCapsule tool and use the FmpDevicePkg to implement
drivers that produce the Firmware Management Protocol to process UEFI capsules.

* Update Vlv2TbltDevicePkg specific BDS to notify when test key is detected.
* Add FmpDeviceLib instance for Minnow Max FLASH update
* Add FmpDeviceLib instance for sample devices
* Add scripts to generate UEFI Capsules for system and device firmware
* Update Vlv2TbltDevicePkg DSC/FDF to use FmpDevicePkg

Cc: David Wei <david.wei@intel.com>
Cc: Mang Guo <mang.guo@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>

Kinney, Michael D (1):
  Vlv2TbltDevicePkg/Override/Bds: Add test key notification

Michael D Kinney (3):
  Vlv2TbltDevicePkg/Feature/Capsule: Add FmpDeviceLib instances
  Vlv2TbltDevicePkg/Capsule: Add scripts to generate capsules
  Vlv2TbltDevicePkg: Update DSC/FDF to use FmpDevicePkg

 .../Capsule/GenerateCapsule/GenCapsuleAll.bat      |  35 ++
 .../GenerateCapsule/GenCapsuleMinnowMax.bat        | 139 +++++
 .../GenerateCapsule/GenCapsuleMinnowMaxRelease.bat | 139 +++++
 .../GenerateCapsule/GenCapsuleSampleColor.bat      | 145 +++++
 ...kenSpaceGuid.PcdFmpDevicePkcs7CertBufferXdr.inc |   1 +
 ...kenSpaceGuid.PcdFmpDevicePkcs7CertBufferXdr.inc |   1 +
 ...kenSpaceGuid.PcdFmpDevicePkcs7CertBufferXdr.inc |   1 +
 .../Capsule/Library/FmpDeviceLib/FmpDeviceLib.c    | 607 +++++++++++++++++++++
 .../Capsule/Library/FmpDeviceLib/FmpDeviceLib.inf  |  63 +++
 .../Library/FmpDeviceLibSample/FmpDeviceLib.c      | 429 +++++++++++++++
 .../Library/FmpDeviceLibSample/FmpDeviceLib.inf    |  51 ++
 Vlv2TbltDevicePkg/FmpBlueSampleDevice.dsc          |  61 +++
 Vlv2TbltDevicePkg/FmpCertificate.dsc               |  28 +
 Vlv2TbltDevicePkg/FmpGreenSampleDevice.dsc         |  61 +++
 Vlv2TbltDevicePkg/FmpMinnowMaxSystem.dsc           |  65 +++
 Vlv2TbltDevicePkg/FmpRedSampleDevice.dsc           |  61 +++
 .../Library/GenericBdsLib/BdsConsole.c             |  11 +
 .../Library/GenericBdsLib/GenericBdsLib.inf        |   1 +
 Vlv2TbltDevicePkg/PlatformCapsule.dsc              |   1 +
 Vlv2TbltDevicePkg/PlatformCapsule.fdf              |  23 -
 Vlv2TbltDevicePkg/PlatformCapsuleGcc.fdf           |  23 -
 Vlv2TbltDevicePkg/PlatformPkg.dec                  |   5 +
 Vlv2TbltDevicePkg/PlatformPkg.fdf                  |  61 +--
 Vlv2TbltDevicePkg/PlatformPkgConfig.dsc            |  19 +-
 Vlv2TbltDevicePkg/PlatformPkgGcc.fdf               |  61 +--
 Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc            |  66 +--
 Vlv2TbltDevicePkg/PlatformPkgIA32.dsc              |  64 +--
 Vlv2TbltDevicePkg/PlatformPkgX64.dsc               |  62 +--
 28 files changed, 2032 insertions(+), 252 deletions(-)
 create mode 100644 Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleAll.bat
 create mode 100644 Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleMinnowMax.bat
 create mode 100644 Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleMinnowMaxRelease.bat
 create mode 100644 Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleSampleColor.bat
 create mode 100644 Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/NewRoot.cer.gFmpDevicePkgTokenSpaceGuid.PcdFmpDevicePkcs7CertBufferXdr.inc
 create mode 100644 Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/SAMPLE_DEVELOPMENT.cer.gFmpDevicePkgTokenSpaceGuid.PcdFmpDevicePkcs7CertBufferXdr.inc
 create mode 100644 Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/SAMPLE_DEVELOPMENT_SAMPLE_PRODUCTION.cer.gFmpDevicePkgTokenSpaceGuid.PcdFmpDevicePkcs7CertBufferXdr.inc
 create mode 100644 Vlv2TbltDevicePkg/Feature/Capsule/Library/FmpDeviceLib/FmpDeviceLib.c
 create mode 100644 Vlv2TbltDevicePkg/Feature/Capsule/Library/FmpDeviceLib/FmpDeviceLib.inf
 create mode 100644 Vlv2TbltDevicePkg/Feature/Capsule/Library/FmpDeviceLibSample/FmpDeviceLib.c
 create mode 100644 Vlv2TbltDevicePkg/Feature/Capsule/Library/FmpDeviceLibSample/FmpDeviceLib.inf
 create mode 100644 Vlv2TbltDevicePkg/FmpBlueSampleDevice.dsc
 create mode 100644 Vlv2TbltDevicePkg/FmpCertificate.dsc
 create mode 100644 Vlv2TbltDevicePkg/FmpGreenSampleDevice.dsc
 create mode 100644 Vlv2TbltDevicePkg/FmpMinnowMaxSystem.dsc
 create mode 100644 Vlv2TbltDevicePkg/FmpRedSampleDevice.dsc

-- 
2.14.2.windows.3

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [Patch 0/4] Vlv2TbltDevicePkg: Add FmpDevicePkg support

Posted by Laszlo Ersek 17 weeks ago
Hi,

On 08/10/18 08:25, Guo, Mang wrote:
> Reviewed-by: Guo Mang <mang.guo@intel.com>

please consider the diffstat on this patch set:

>  28 files changed, 2032 insertions(+), 252 deletions(-)

May I ask why this patch set has been committed during the quiet period,
before the upcoming stable tag? See "[edk2] EDK II Stable Tag release
edk2-stable201808 and quiet period starting today":

https://lists.01.org/pipermail/edk2-devel/2018-August/028210.html

On 08/08/18 16:16, Kinney, Michael D wrote:
> I recommend we target 8/15/2018 and start a quiet period
> on edk2/master starting today.  This means critical bug
> fixes only on edk2/master.  New features and large changes
> should be held until the edk2-stable201808 tag is created.

Based on the diffstat, this series is not a "critical bugfix" (the blurb
bears the subject "Vlv2TbltDevicePkg: Add FmpDevicePkg support").

The quiet period / stable tags don't make much sense if we don't honor
them.

Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [Patch 0/4] Vlv2TbltDevicePkg: Add FmpDevicePkg support

Posted by Kinney, Michael D 17 weeks ago
Hi Laszlo,

I should have entered a Bugzilla for this item so I 
could clearly document why this is required before
the stable tag and sent email to edk2-devel to inform
everyone that this Bugzilla should be considered for
the stable tag release to give the community a chance
to vote if it should be allowed or not. 

One feature that has been added for this stable tag
is the FmpDevicePkg and the GenerateCapsule tool.
These work together to provide a simpler method to
generate and process UEFI capsules for firmware updates.

I am using the platform in the Vlv2TbltDevicePkg to
demonstrate the use of this feature.  I am adding
Wiki pages on this feature that will reference this
platform with functional examples.

I had hoped I could get this content in before the
start of the quiet period, but I missed the window.

Thanks,

Mike

> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Tuesday, August 14, 2018 7:59 AM
> To: Guo, Mang <mang.guo@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; edk2-devel@lists.01.org
> Cc: Wei, David <david.wei@intel.com>; Leif Lindholm
> (Linaro address) <leif.lindholm@linaro.org>
> Subject: Re: [edk2] [Patch 0/4] Vlv2TbltDevicePkg: Add
> FmpDevicePkg support
> 
> Hi,
> 
> On 08/10/18 08:25, Guo, Mang wrote:
> > Reviewed-by: Guo Mang <mang.guo@intel.com>
> 
> please consider the diffstat on this patch set:
> 
> >  28 files changed, 2032 insertions(+), 252
> deletions(-)
> 
> May I ask why this patch set has been committed during
> the quiet period,
> before the upcoming stable tag? See "[edk2] EDK II
> Stable Tag release
> edk2-stable201808 and quiet period starting today":
> 
> https://lists.01.org/pipermail/edk2-devel/2018-
> August/028210.html
> 
> On 08/08/18 16:16, Kinney, Michael D wrote:
> > I recommend we target 8/15/2018 and start a quiet
> period
> > on edk2/master starting today.  This means critical
> bug
> > fixes only on edk2/master.  New features and large
> changes
> > should be held until the edk2-stable201808 tag is
> created.
> 
> Based on the diffstat, this series is not a "critical
> bugfix" (the blurb
> bears the subject "Vlv2TbltDevicePkg: Add FmpDevicePkg
> support").
> 
> The quiet period / stable tags don't make much sense if
> we don't honor
> them.
> 
> Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel