From nobody Mon Feb 9 07:04:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail(p=none dis=none) header.from=intel.com Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 15311057804351016.0256342810732; Sun, 8 Jul 2018 20:09:40 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 05C6721BADAB2; Sun, 8 Jul 2018 20:09:34 -0700 (PDT) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2013A202E53F3 for ; Sun, 8 Jul 2018 20:09:32 -0700 (PDT) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Jul 2018 20:09:31 -0700 Received: from shwdeopenpsi014.ccr.corp.intel.com ([10.239.9.19]) by fmsmga004.fm.intel.com with ESMTP; 08 Jul 2018 20:09:22 -0700 X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.120; helo=mga04.intel.com; envelope-from=hao.a.wu@intel.com; receiver=edk2-devel@lists.01.org X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,328,1526367600"; d="scan'208";a="69690801" From: Hao Wu To: edk2-devel@lists.01.org Date: Mon, 9 Jul 2018 11:09:17 +0800 Message-Id: <20180709030919.8464-3-hao.a.wu@intel.com> X-Mailer: git-send-email 2.12.0.windows.1 In-Reply-To: <20180709030919.8464-1-hao.a.wu@intel.com> References: <20180709030919.8464-1-hao.a.wu@intel.com> Subject: [edk2] [PATCH edk2-platforms\devel-MinPlatform 2/4] AdvancedFeaturePkg/Ipmi: Update codes for header changes in MdePkg X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Hao Wu , Jiewen Yao MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The commit will remove the dependency on file: Platform/Intel/AdvancedFeaturePkg/Ipmi/Include/IpmiEx.h The IPMI header files within: edk2/MdePkg/Include/IndustryStandard/ already have the structure definitions in this IpmiEx.h file. Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Hao Wu --- Platform/Intel/AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.c = | 4 ++-- Platform/Intel/AdvancedFeaturePkg/Ipmi/Frb/FrbDxe.c = | 11 +++++------ Platform/Intel/AdvancedFeaturePkg/Ipmi/Frb/FrbPei.c = | 5 ++--- Platform/Intel/AdvancedFeaturePkg/Ipmi/Include/Library/IpmiCommandLib.h = | 3 +-- Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiFru/IpmiFru.c = | 5 ++--- Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiInit/DxeIpmiInit.c = | 10 ++++++++-- Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiInit/PeiIpmiInit.c = | 10 ++++++++-- Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCommandL= ibNetFnApp.c | 1 - Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCommandL= ibNetFnChassis.c | 1 - Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCommandL= ibNetFnStorage.c | 7 +++---- Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCommandL= ibNetFnTransport.c | 1 - Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiLibNull/IpmiLibNull.c = | 1 - Platform/Intel/AdvancedFeaturePkg/Ipmi/OsWdt/OsWdt.c = | 7 +++---- Platform/Intel/AdvancedFeaturePkg/Ipmi/SolStatus/SolStatus.c = | 11 +++++------ 14 files changed, 39 insertions(+), 38 deletions(-) diff --git a/Platform/Intel/AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.c b/Pla= tform/Intel/AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.c index 988b179c01..6125e2bd94 100644 --- a/Platform/Intel/AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.c +++ b/Platform/Intel/AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.c @@ -130,7 +130,7 @@ Returns: } =20 if (EnableElog =3D=3D NULL) { - *ElogStatus =3D GetBmcGlobalEnables.SystemEventLogging; + *ElogStatus =3D GetBmcGlobalEnables.GetEnables.Bits.SystemEventLogging; } else { if (Status =3D=3D EFI_SUCCESS) { if (*EnableElog) { @@ -138,7 +138,7 @@ Returns: } =20 CopyMem (&SetBmcGlobalEnables, (UINT8 *)&GetBmcGlobalEnables + sizeo= f(UINT8), sizeof(UINT8)); - SetBmcGlobalEnables.EnableSystemEventLogging =3D ElogStat; + SetBmcGlobalEnables.SetEnables.Bits.SystemEventLogging =3D ElogStat; =20 Status =3D IpmiSetBmcGlobalEnables (&SetBmcGlobalEnables, &Completio= nCode); } diff --git a/Platform/Intel/AdvancedFeaturePkg/Ipmi/Frb/FrbDxe.c b/Platform= /Intel/AdvancedFeaturePkg/Ipmi/Frb/FrbDxe.c index 42fc6fc2ec..719d968b5a 100644 --- a/Platform/Intel/AdvancedFeaturePkg/Ipmi/Frb/FrbDxe.c +++ b/Platform/Intel/AdvancedFeaturePkg/Ipmi/Frb/FrbDxe.c @@ -21,7 +21,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER= EXPRESS OR IMPLIED. #include #include #include -#include =20 EFI_STATUS EfiDisableFrb ( @@ -56,7 +55,7 @@ EfiDisableFrb ( // // Check if timer is still running, if not abort disable routine. // - if (GetWatchdogTimer.TimerUse.TimerRunning =3D=3D 0) { + if (GetWatchdogTimer.TimerUse.Bits.TimerRunning =3D=3D 0) { return EFI_ABORTED; } =20 @@ -64,8 +63,8 @@ EfiDisableFrb ( // // Just flip the Timer Use bit. This should release the timer. // - SetWatchdogTimer.TimerUse.TimerRunning =3D 0; - SetWatchdogTimer.TimerUse.TimerUse =3D IPMI_WATCHDOG_TIMER_B= IOS_FRB2; + SetWatchdogTimer.TimerUse.Bits.TimerRunning =3D 0; + SetWatchdogTimer.TimerUse.Bits.TimerUse =3D IPMI_WATCHDOG_TIMER_B= IOS_FRB2; SetWatchdogTimer.TimerUseExpirationFlagsClear &=3D ~BIT2; SetWatchdogTimer.TimerUseExpirationFlagsClear |=3D BIT1 | BIT4; =20 @@ -150,7 +149,7 @@ CheckForAndReportErrors( SetWatchdogTimer.PretimeoutInterval =3D GetWatchdogTimer.Pre= timeoutInterval; SetWatchdogTimer.TimerUseExpirationFlagsClear =3D GetWatchdogTimer.Tim= erUseExpirationFlagsClear; SetWatchdogTimer.InitialCountdownValue =3D GetWatchdogTimer.Ini= tialCountdownValue; - SetWatchdogTimer.TimerUse.TimerRunning =3D 1; + SetWatchdogTimer.TimerUse.Bits.TimerRunning =3D 1; SetWatchdogTimer.TimerUseExpirationFlagsClear |=3D BIT1 | BIT2 | BIT3; =20 Status =3D IpmiSetWatchdogTimer (&SetWatchdogTimer, &CompletionCode); @@ -192,7 +191,7 @@ ReportFrb2Status ( // // Check if timer is running, report status to DEBUG_MODE output. // - if (GetWatchdogTimer.TimerUse.TimerRunning =3D=3D 1) { + if (GetWatchdogTimer.TimerUse.Bits.TimerRunning =3D=3D 1) { DEBUG ((DEBUG_INFO, "FRB2 Timer is running.\n")); } else { DEBUG ((DEBUG_INFO, "FRB2 Timer is not running.\n")); diff --git a/Platform/Intel/AdvancedFeaturePkg/Ipmi/Frb/FrbPei.c b/Platform= /Intel/AdvancedFeaturePkg/Ipmi/Frb/FrbPei.c index 73f401284c..2a077bc3b9 100644 --- a/Platform/Intel/AdvancedFeaturePkg/Ipmi/Frb/FrbPei.c +++ b/Platform/Intel/AdvancedFeaturePkg/Ipmi/Frb/FrbPei.c @@ -20,7 +20,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER= EXPRESS OR IMPLIED. #include =20 #include -#include =20 VOID SetWatchDogTimer ( @@ -40,9 +39,9 @@ SetWatchDogTimer ( if (Frb2Enabled) { ZeroMem (&FrbTimer, sizeof(FrbTimer)); //Byte 1 - FrbTimer.TimerUse.TimerUse =3D IPMI_WATCHDOG_TIMER_BIOS_FRB2; + FrbTimer.TimerUse.Bits.TimerUse =3D IPMI_WATCHDOG_TIMER_BIOS_FRB2; //Byte 2=20 - FrbTimer.TimerActions =3D 0; //NormalBoot, NoTimeOutInterrupt. i.e = no action when BMC watchdog timeout + FrbTimer.TimerActions.Uint8 =3D 0; //NormalBoot, NoTimeOutInterrupt= . i.e no action when BMC watchdog timeout //Byte 3 FrbTimer.PretimeoutInterval =3D 0; //Byte 4 diff --git a/Platform/Intel/AdvancedFeaturePkg/Ipmi/Include/Library/IpmiCom= mandLib.h b/Platform/Intel/AdvancedFeaturePkg/Ipmi/Include/Library/IpmiComm= andLib.h index 216f2adb55..592d9c6846 100644 --- a/Platform/Intel/AdvancedFeaturePkg/Ipmi/Include/Library/IpmiCommandLib= .h +++ b/Platform/Intel/AdvancedFeaturePkg/Ipmi/Include/Library/IpmiCommandLib= .h @@ -17,7 +17,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER= EXPRESS OR IMPLIED. =20 #include #include -#include =20 // // NetFnApp @@ -228,7 +227,7 @@ IpmiSetSelTime ( EFI_STATUS EFIAPI IpmiGetSdrRepositoryInfo ( - OUT IPMI_GET_SDR_REPOSITORY_INFO *GetSdrRepositoryInfo + OUT IPMI_GET_SDR_REPOSITORY_INFO_RESPONSE *GetSdrRepositoryInfoResp ); =20 EFI_STATUS diff --git a/Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiFru/IpmiFru.c b/Pla= tform/Intel/AdvancedFeaturePkg/Ipmi/IpmiFru/IpmiFru.c index acba9d8e23..1be62a882b 100644 --- a/Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiFru/IpmiFru.c +++ b/Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiFru/IpmiFru.c @@ -19,7 +19,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER= EXPRESS OR IMPLIED. #include #include #include -#include =20 EFI_STATUS InitializeFru ( @@ -57,9 +56,9 @@ Returns: return Status; } =20 - DEBUG((DEBUG_ERROR, "!!! IpmiFru FruInventorySupport %x\n", ControllerI= nfo.FruInventorySupport)); + DEBUG((DEBUG_ERROR, "!!! IpmiFru FruInventorySupport %x\n", ControllerI= nfo.DeviceSupport.Bits.FruInventorySupport)); =20 - if (ControllerInfo.FruInventorySupport) { + if (ControllerInfo.DeviceSupport.Bits.FruInventorySupport) { GetFruInventoryAreaInfoRequest.DeviceId =3D 0; Status =3D IpmiGetFruInventoryAreaInfo (&GetFruInventoryAreaInfoReques= t, &GetFruInventoryAreaInfoResponse); if (EFI_ERROR (Status)) { diff --git a/Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiInit/DxeIpmiInit.c = b/Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiInit/DxeIpmiInit.c index 0a49b87859..5c5079d7fb 100644 --- a/Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiInit/DxeIpmiInit.c +++ b/Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiInit/DxeIpmiInit.c @@ -104,8 +104,14 @@ Returns: } } while (TRUE); =20 - DEBUG((DEBUG_INFO, "[IPMI] BMC Device ID: 0x%02X, firmware version: %d.%= 02X\n", BmcInfo.DeviceId, BmcInfo.MajorFirmwareRev, BmcInfo.MinorFirmwareRe= v)); - *UpdateMode =3D (BOOLEAN)BmcInfo.UpdateMode; + DEBUG(( + DEBUG_INFO, + "[IPMI] BMC Device ID: 0x%02X, firmware version: %d.%02X\n", + BmcInfo.DeviceId, + BmcInfo.FirmwareRev1.Bits.MajorFirmwareRev, + BmcInfo.MinorFirmwareRev + )); + *UpdateMode =3D (BOOLEAN)BmcInfo.FirmwareRev1.Bits.UpdateMode; return Status; } =20 diff --git a/Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiInit/PeiIpmiInit.c = b/Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiInit/PeiIpmiInit.c index 962aff6f4b..85dfcf77e0 100644 --- a/Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiInit/PeiIpmiInit.c +++ b/Platform/Intel/AdvancedFeaturePkg/Ipmi/IpmiInit/PeiIpmiInit.c @@ -62,8 +62,14 @@ Returns: } } while (TRUE); =20 - DEBUG((DEBUG_INFO, "[IPMI] BMC Device ID: 0x%02X, firmware version: %d.%= 02X\n", BmcInfo.DeviceId, BmcInfo.MajorFirmwareRev, BmcInfo.MinorFirmwareRe= v)); - *UpdateMode =3D (BOOLEAN)BmcInfo.UpdateMode; + DEBUG(( + DEBUG_INFO, + "[IPMI] BMC Device ID: 0x%02X, firmware version: %d.%02X\n", + BmcInfo.DeviceId, + BmcInfo.FirmwareRev1.Bits.MajorFirmwareRev, + BmcInfo.MinorFirmwareRev + )); + *UpdateMode =3D (BOOLEAN)BmcInfo.FirmwareRev1.Bits.UpdateMode; return Status; } =20 diff --git a/Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/= IpmiCommandLibNetFnApp.c b/Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/I= pmiCommandLib/IpmiCommandLibNetFnApp.c index f11b23a439..4280f8805a 100644 --- a/Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCom= mandLibNetFnApp.c +++ b/Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCom= mandLibNetFnApp.c @@ -18,7 +18,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER= EXPRESS OR IMPLIED. #include =20 #include -#include =20 EFI_STATUS EFIAPI diff --git a/Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/= IpmiCommandLibNetFnChassis.c b/Platform/Intel/AdvancedFeaturePkg/Ipmi/Libra= ry/IpmiCommandLib/IpmiCommandLibNetFnChassis.c index eb699907a2..1f50ca1834 100644 --- a/Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCom= mandLibNetFnChassis.c +++ b/Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCom= mandLibNetFnChassis.c @@ -18,7 +18,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER= EXPRESS OR IMPLIED. #include =20 #include -#include =20 =20 EFI_STATUS diff --git a/Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/= IpmiCommandLibNetFnStorage.c b/Platform/Intel/AdvancedFeaturePkg/Ipmi/Libra= ry/IpmiCommandLib/IpmiCommandLibNetFnStorage.c index ce2b7b9eb8..c7af988bd8 100644 --- a/Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCom= mandLibNetFnStorage.c +++ b/Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCom= mandLibNetFnStorage.c @@ -18,7 +18,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER= EXPRESS OR IMPLIED. #include =20 #include -#include =20 =20 EFI_STATUS @@ -242,19 +241,19 @@ IpmiSetSelTime ( EFI_STATUS EFIAPI IpmiGetSdrRepositoryInfo ( - OUT IPMI_GET_SDR_REPOSITORY_INFO *GetSdrRepositoryInfo + OUT IPMI_GET_SDR_REPOSITORY_INFO_RESPONSE *GetSdrRepositoryInfoResp ) { EFI_STATUS Status; UINT32 DataSize; =20 - DataSize =3D sizeof(*GetSdrRepositoryInfo); + DataSize =3D sizeof(*GetSdrRepositoryInfoResp); Status =3D IpmiSubmitCommand ( IPMI_NETFN_STORAGE, IPMI_STORAGE_GET_SDR_REPOSITORY_INFO, NULL, 0, - (VOID *)GetSdrRepositoryInfo, + (VOID *)GetSdrRepositoryInfoResp, &DataSize ); return Status; diff --git a/Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/= IpmiCommandLibNetFnTransport.c b/Platform/Intel/AdvancedFeaturePkg/Ipmi/Lib= rary/IpmiCommandLib/IpmiCommandLibNetFnTransport.c index 925436e61e..309cea819f 100644 --- a/Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCom= mandLibNetFnTransport.c +++ b/Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiCommandLib/IpmiCom= mandLibNetFnTransport.c @@ -18,7 +18,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER= EXPRESS OR IMPLIED. #include =20 #include -#include =20 =20 EFI_STATUS diff --git a/Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiLibNull/Ipm= iLibNull.c b/Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiLibNull/Ipm= iLibNull.c index cdeac9d651..13b7e0b5a7 100644 --- a/Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiLibNull/IpmiLibNul= l.c +++ b/Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiLibNull/IpmiLibNul= l.c @@ -16,7 +16,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER= EXPRESS OR IMPLIED. #include =20 #include -#include =20 /** This service enables submitting commands via Ipmi. diff --git a/Platform/Intel/AdvancedFeaturePkg/Ipmi/OsWdt/OsWdt.c b/Platfor= m/Intel/AdvancedFeaturePkg/Ipmi/OsWdt/OsWdt.c index c64c70f2a9..1001cb0192 100644 --- a/Platform/Intel/AdvancedFeaturePkg/Ipmi/OsWdt/OsWdt.c +++ b/Platform/Intel/AdvancedFeaturePkg/Ipmi/OsWdt/OsWdt.c @@ -18,7 +18,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER= EXPRESS OR IMPLIED. #include #include #include -#include =20 BOOLEAN mOsWdtFlag =3D FALSE; =20 @@ -71,9 +70,9 @@ Returns: // // Just flip the Timer Use bit. This should release the timer. // - SetWatchdogTimer.TimerUse.TimerRunning =3D 1; - SetWatchdogTimer.TimerUse.TimerUse =3D IPMI_WATCHDOG_TIMER_O= S_LOADER; - SetWatchdogTimer.TimerActions =3D IPMI_WATCHDOG_TIMER_A= CTION_HARD_RESET; + SetWatchdogTimer.TimerUse.Bits.TimerRunning =3D 1; + SetWatchdogTimer.TimerUse.Bits.TimerUse =3D IPMI_WATCHDOG_TIMER_O= S_LOADER; + SetWatchdogTimer.TimerActions.Uint8 =3D IPMI_WATCHDOG_TIMER_A= CTION_HARD_RESET; SetWatchdogTimer.TimerUseExpirationFlagsClear &=3D ~BIT4; SetWatchdogTimer.TimerUseExpirationFlagsClear |=3D BIT1 | BIT2; SetWatchdogTimer.InitialCountdownValue =3D 600; // 100ms / count diff --git a/Platform/Intel/AdvancedFeaturePkg/Ipmi/SolStatus/SolStatus.c b= /Platform/Intel/AdvancedFeaturePkg/Ipmi/SolStatus/SolStatus.c index 6d2dbd5bea..4163fa1229 100644 --- a/Platform/Intel/AdvancedFeaturePkg/Ipmi/SolStatus/SolStatus.c +++ b/Platform/Intel/AdvancedFeaturePkg/Ipmi/SolStatus/SolStatus.c @@ -21,7 +21,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER= EXPRESS OR IMPLIED. #include #include #include -#include =20 #define SOL_CMD_RETRY_COUNT 10 =20 @@ -55,8 +54,8 @@ GetSOLStatus ( =20 for (RetryCount =3D 0; RetryCount < SOL_CMD_RETRY_COUNT; RetryCount++) { ZeroMem (&GetConfigurationParametersRequest, sizeof(GetConfigurationPa= rametersRequest)); - GetConfigurationParametersRequest.ChannelNumber =3D Channel; - GetConfigurationParametersRequest.ParameterSelector =3D ParamSel; + GetConfigurationParametersRequest.ChannelNumber.Bits.ChannelNumber =3D= Channel; + GetConfigurationParametersRequest.ParameterSelector =3D= ParamSel; =20 ZeroMem (&GetConfigurationParametersResponse, sizeof(GetConfigurationP= arametersResponse)); =20 @@ -110,9 +109,9 @@ SetSOLParams ( =20 for (RetryCount =3D 0; RetryCount < SOL_CMD_RETRY_COUNT; RetryCount++) { ZeroMem (&SetConfigurationParametersRequest, sizeof(SetConfigurationPa= rametersRequest)); - SetConfigurationParametersRequest.ChannelNumber =3D Channel; - SetConfigurationParametersRequest.ParameterSelector =3D ParamSel; - SetConfigurationParametersRequest.ParameterData[0] =3D Data; + SetConfigurationParametersRequest.ChannelNumber.Bits.ChannelNumber =3D= Channel; + SetConfigurationParametersRequest.ParameterSelector =3D= ParamSel; + SetConfigurationParametersRequest.ParameterData[0] =3D= Data; =20 CompletionCode =3D 0; =20 --=20 2.12.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel