From nobody Mon May 6 20:51:08 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail(p=none dis=none) header.from=intel.com Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1530242500968958.6045280471756; Thu, 28 Jun 2018 20:21:40 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 0C500203369C5; Thu, 28 Jun 2018 20:21:40 -0700 (PDT) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8D659202E53FE for ; Thu, 28 Jun 2018 20:21:38 -0700 (PDT) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Jun 2018 20:21:38 -0700 Received: from ydong10-win10.ccr.corp.intel.com ([10.239.9.24]) by orsmga005.jf.intel.com with ESMTP; 28 Jun 2018 20:20:50 -0700 X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.126; helo=mga18.intel.com; envelope-from=eric.dong@intel.com; receiver=edk2-devel@lists.01.org X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,285,1526367600"; d="scan'208";a="236499394" From: Eric Dong To: edk2-devel@lists.01.org Date: Fri, 29 Jun 2018 11:20:47 +0800 Message-Id: <20180629032047.6340-1-eric.dong@intel.com> X-Mailer: git-send-email 2.15.0.windows.1 Subject: [edk2] [Patch V2] UefiCpuPkg/MpInitLib: Remove redundant parameter. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ruiyu Ni MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Parameter StartCount duplicates with RunningCount. After this change,=20 RunningCount means the running AP count. V2 changes: Remove volatile for RunningCount. Done Test: 1.PI SCT Test 2.Boot OS / S3 Cc: Ruiyu Ni Cc: Jeff Fan Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong --- UefiCpuPkg/Library/MpInitLib/MpLib.c | 11 +++++------ UefiCpuPkg/Library/MpInitLib/MpLib.h | 3 +-- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c b/UefiCpuPkg/Library/MpIn= itLib/MpLib.c index 3945771764..52c9679099 100644 --- a/UefiCpuPkg/Library/MpInitLib/MpLib.c +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c @@ -1400,7 +1400,7 @@ CheckAllAPs ( // value of state after setting the it to CpuStateFinished, so BSP can= safely make use of its value. // if (GetApState(CpuData) !=3D CpuStateBusy) { - CpuMpData->RunningCount ++; + CpuMpData->RunningCount --; CpuMpData->CpuData[ProcessorNumber].Waiting =3D FALSE; =20 // @@ -1425,7 +1425,7 @@ CheckAllAPs ( // // If all APs finish, return EFI_SUCCESS. // - if (CpuMpData->RunningCount =3D=3D CpuMpData->StartCount) { + if (CpuMpData->RunningCount =3D=3D 0) { return EFI_SUCCESS; } =20 @@ -1442,7 +1442,7 @@ CheckAllAPs ( // if (CpuMpData->FailedCpuList !=3D NULL) { *CpuMpData->FailedCpuList =3D - AllocatePool ((CpuMpData->StartCount - CpuMpData->FinishedCount += 1) * sizeof (UINTN)); + AllocatePool ((CpuMpData->RunningCount + 1) * sizeof (UINTN)); ASSERT (*CpuMpData->FailedCpuList !=3D NULL); } ListIndex =3D 0; @@ -2121,7 +2121,7 @@ StartupAllAPsWorker ( return EFI_NOT_STARTED; } =20 - CpuMpData->StartCount =3D 0; + CpuMpData->RunningCount =3D 0; for (ProcessorNumber =3D 0; ProcessorNumber < ProcessorCount; ProcessorN= umber++) { CpuData =3D &CpuMpData->CpuData[ProcessorNumber]; CpuData->Waiting =3D FALSE; @@ -2131,7 +2131,7 @@ StartupAllAPsWorker ( // Mark this processor as responsible for current calling. // CpuData->Waiting =3D TRUE; - CpuMpData->StartCount++; + CpuMpData->RunningCount++; } } } @@ -2140,7 +2140,6 @@ StartupAllAPsWorker ( CpuMpData->ProcArguments =3D ProcedureArgument; CpuMpData->SingleThread =3D SingleThread; CpuMpData->FinishedCount =3D 0; - CpuMpData->RunningCount =3D 0; CpuMpData->FailedCpuList =3D FailedCpuList; CpuMpData->ExpectedTime =3D CalculateTimeout ( TimeoutInMicroseconds, diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h b/UefiCpuPkg/Library/MpIn= itLib/MpLib.h index 90c09fb8fb..ad62acf766 100644 --- a/UefiCpuPkg/Library/MpInitLib/MpLib.h +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.h @@ -210,9 +210,8 @@ struct _CPU_MP_DATA { UINTN BackupBuffer; UINTN BackupBufferSize; =20 - volatile UINT32 StartCount; volatile UINT32 FinishedCount; - volatile UINT32 RunningCount; + UINT32 RunningCount; BOOLEAN SingleThread; EFI_AP_PROCEDURE Procedure; VOID *ProcArguments; --=20 2.15.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel