From nobody Mon May 6 11:05:44 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1530118144142127.24033952666491; Wed, 27 Jun 2018 09:49:04 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 7211F202E540C; Wed, 27 Jun 2018 09:48:59 -0700 (PDT) Received: from cam-smtp0.cambridge.arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5E031202E53E9 for ; Wed, 27 Jun 2018 09:48:57 -0700 (PDT) Received: from E107187.Emea.Arm.com (E107187.Emea.Arm.com [10.1.206.129]) by cam-smtp0.cambridge.arm.com (8.13.8/8.13.8) with ESMTP id w5RGmrcQ010379; Wed, 27 Jun 2018 17:48:54 +0100 X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.96.140; helo=cam-smtp0.cambridge.arm.com; envelope-from=sami.mujawar@arm.com; receiver=edk2-devel@lists.01.org From: Sami Mujawar To: edk2-devel@lists.01.org Date: Wed, 27 Jun 2018 17:48:43 +0100 Message-Id: <20180627164848.24124-2-sami.mujawar@arm.com> X-Mailer: git-send-email 2.11.0.windows.3 In-Reply-To: <20180627164848.24124-1-sami.mujawar@arm.com> References: <20180627164848.24124-1-sami.mujawar@arm.com> Subject: [edk2] [PATCH edk2-platforms v1 1/6][platforms/devel-dynamictables] Platform/ARM: FVP: Add module info to file header X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nd@arm.com, Arvind Chauhan , Stephanie.Hughes-Fitt@arm.com MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The ecc tool reports that the Header comment section must have Abstract information. Added a brief module description to the file header. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Sami Mujawar Reviewed-by: Evan Lloyd Reviewed-by: Leif Lindholm Reviewed-by? --- The changes can be seen at https://github.com/samimujawar/edk2-platforms/tr= ee/290_fix_ecc_issues_v1 Notes: v1: - Fix ecc tool reported issues [SAMI] Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManager.dsc.inc= | 3 ++- Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/Conf= igurationManagerDxe.inf | 1 + Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/Platfor= mASLTablesLib.inf | 1 + 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationMan= ager.dsc.inc b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationM= anager.dsc.inc index 8402742ebb0249d8b585d2315e24bba2f5ecf480..68dbff08fb95721b766439c7e8e= 93849a1a76e5a 100644 --- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManager.ds= c.inc +++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManager.ds= c.inc @@ -1,6 +1,7 @@ ## @file +# dsc include file for Configuration Manager # -# Copyright (c) 2017, ARM Limited. All rights reserved. +# Copyright (c) 2017 - 2018, ARM Limited. All rights reserved. # # This program and the accompanying materials # are licensed and made available under the terms and conditions of the B= SD License diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationMan= agerDxe/ConfigurationManagerDxe.inf b/Platform/ARM/VExpressPkg/Configuratio= nManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf index ff61763f661289e2f86911b5f68576ac657a400c..3cef37fc61c03e0f740fc431608= 835038c9e26c5 100644 --- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe= /ConfigurationManagerDxe.inf +++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe= /ConfigurationManagerDxe.inf @@ -1,4 +1,5 @@ ## @file +# Configuration Manager Dxe # # Copyright (c) 2017 - 2018, ARM Limited. All rights reserved. # diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTable= sLib/PlatformASLTablesLib.inf b/Platform/ARM/VExpressPkg/ConfigurationManag= er/PlatformASLTablesLib/PlatformASLTablesLib.inf index 28426e18f32dc25af6faf51826e11d5e09fe105d..9a5f3d05fbe05461756bd6198dd= 1ecd95d26ac97 100644 --- a/Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/Pl= atformASLTablesLib.inf +++ b/Platform/ARM/VExpressPkg/ConfigurationManager/PlatformASLTablesLib/Pl= atformASLTablesLib.inf @@ -1,4 +1,5 @@ ## @file +# Platform ASL Tables # # Copyright (c) 2017 - 2018, ARM Limited. All rights reserved. # --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel From nobody Mon May 6 11:05:44 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1530118151338637.3688935244095; Wed, 27 Jun 2018 09:49:11 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id CF829202E541D; Wed, 27 Jun 2018 09:48:59 -0700 (PDT) Received: from cam-smtp0.cambridge.arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 62CD5202E53ED for ; Wed, 27 Jun 2018 09:48:57 -0700 (PDT) Received: from E107187.Emea.Arm.com (E107187.Emea.Arm.com [10.1.206.129]) by cam-smtp0.cambridge.arm.com (8.13.8/8.13.8) with ESMTP id w5RGmrcR010379; Wed, 27 Jun 2018 17:48:55 +0100 X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.96.140; helo=cam-smtp0.cambridge.arm.com; envelope-from=sami.mujawar@arm.com; receiver=edk2-devel@lists.01.org From: Sami Mujawar To: edk2-devel@lists.01.org Date: Wed, 27 Jun 2018 17:48:44 +0100 Message-Id: <20180627164848.24124-3-sami.mujawar@arm.com> X-Mailer: git-send-email 2.11.0.windows.3 In-Reply-To: <20180627164848.24124-1-sami.mujawar@arm.com> References: <20180627164848.24124-1-sami.mujawar@arm.com> Subject: [edk2] [PATCH edk2-platforms v1 2/6][platforms/devel-dynamictables] Platform/ARM: FVP: Fix function documentation X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nd@arm.com, Arvind Chauhan , Stephanie.Hughes-Fitt@arm.com MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Fixed function documentation issues reported by ecc tool. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Sami Mujawar Reviewed-by: Evan Lloyd Reviewed-by: Leif Lindholm Reviewed-by? --- Notes: v1: - Fix ecc tool reported issues [SAMI] Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/Conf= igurationManager.c | 84 ++++++++++---------- 1 file changed, 42 insertions(+), 42 deletions(-) diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationMan= agerDxe/ConfigurationManager.c b/Platform/ARM/VExpressPkg/ConfigurationMana= ger/ConfigurationManagerDxe/ConfigurationManager.c index 2e1be34acf49962fd1899d84dec96c8cb9155b2c..a67a09cb6c197a14b376d4a8ef9= a90e438efb2bb 100644 --- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe= /ConfigurationManager.c +++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe= /ConfigurationManager.c @@ -230,7 +230,7 @@ EFI_PLATFORM_REPOSITORY_INFO VExpressPlatRepositoryInfo= =3D { =20 @retval EFI_SUCCESS Success -*/ +**/ STATIC EFI_STATUS EFIAPI @@ -243,16 +243,16 @@ InitializePlatformRepository ( =20 /** Return a GT Block timer frame info list. =20 - @param [in] This Pointer to the Configuration Manager Protocol. - @param [in] CmObjectId The Configuration Manager Object ID. - @param [in] Token A token for identifying the object - @param [out] CmObject Pointer to the Configuration Manager Object - descriptor describing the requested Object. + @param [in] This Pointer to the Configuration Manager Protoc= ol. + @param [in] CmObjectId The Configuration Manager Object ID. + @param [in] Token A token for identifying the object + @param [in, out] CmObject Pointer to the Configuration Manager Object + descriptor describing the requested Object. =20 @retval EFI_SUCCESS Success. @retval EFI_INVALID_PARAMETER A parameter is invalid. @retval EFI_NOT_FOUND The required object information is not fou= nd. -*/ +**/ EFI_STATUS EFIAPI GetGTBlockTimerFrameInfo ( @@ -283,17 +283,17 @@ GetGTBlockTimerFrameInfo ( =20 /** Return a standard namespace object. =20 - @param [in] This Pointer to the Configuration Manager Protocol. - @param [in] CmObjectId The Configuration Manager Object ID. - @param [in] Token An optional token identifying the object. If - unused this must be CM_NULL_TOKEN. - @param [out] CmObject Pointer to the Configuration Manager Object - descriptor describing the requested Object. + @param [in] This Pointer to the Configuration Manager Protoc= ol. + @param [in] CmObjectId The Configuration Manager Object ID. + @param [in] Token An optional token identifying the object. If + unused this must be CM_NULL_TOKEN. + @param [in, out] CmObject Pointer to the Configuration Manager Object + descriptor describing the requested Object. =20 @retval EFI_SUCCESS Success. @retval EFI_INVALID_PARAMETER A parameter is invalid. @retval EFI_NOT_FOUND The required object information is not fou= nd. -*/ +**/ EFI_STATUS EFIAPI GetStandardNameSpaceObject ( @@ -333,17 +333,17 @@ GetStandardNameSpaceObject ( =20 /** Return an ARM namespace object. =20 - @param [in] This Pointer to the Configuration Manager Protocol. - @param [in] CmObjectId The Configuration Manager Object ID. - @param [in] Token An optional token identifying the object. If - unused this must be CM_NULL_TOKEN. - @param [out] CmObject Pointer to the Configuration Manager Object - descriptor describing the requested Object. + @param [in] This Pointer to the Configuration Manager Protoc= ol. + @param [in] CmObjectId The Configuration Manager Object ID. + @param [in] Token An optional token identifying the object. If + unused this must be CM_NULL_TOKEN. + @param [in, out] CmObject Pointer to the Configuration Manager Object + descriptor describing the requested Object. =20 @retval EFI_SUCCESS Success. @retval EFI_INVALID_PARAMETER A parameter is invalid. @retval EFI_NOT_FOUND The required object information is not fou= nd. -*/ +**/ EFI_STATUS EFIAPI GetArmNameSpaceObject ( @@ -414,12 +414,12 @@ GetArmNameSpaceObject ( =20 /** Return an OEM namespace object. =20 - @param [in] This Pointer to the Configuration Manager Protocol. - @param [in] CmObjectId The Configuration Manager Object ID. - @param [in] Token An optional token identifying the object. If - unused this must be CM_NULL_TOKEN. - @param [out] CmObject Pointer to the Configuration Manager Object - descriptor describing the requested Object. + @param [in] This Pointer to the Configuration Manager Protoc= ol. + @param [in] CmObjectId The Configuration Manager Object ID. + @param [in] Token An optional token identifying the object. If + unused this must be CM_NULL_TOKEN. + @param [in, out] CmObject Pointer to the Configuration Manager Object + descriptor describing the requested Object. =20 @retval EFI_SUCCESS Success. @retval EFI_INVALID_PARAMETER A parameter is invalid. @@ -427,7 +427,7 @@ GetArmNameSpaceObject ( @retval EFI_BAD_BUFFER_SIZE The size returned by the Configuration Man= ager is less than the Object size for the reque= sted object. -*/ +**/ EFI_STATUS EFIAPI GetOemNameSpaceObject ( @@ -465,17 +465,17 @@ GetOemNameSpaceObject ( Configuration Manager Protocol for returning the Configuration Manager Objects. =20 - @param [in] This Pointer to the Configuration Manager Protocol. - @param [in] CmObjectId The Configuration Manager Object ID. - @param [in] Token An optional token identifying the object. If - unused this must be CM_NULL_TOKEN. - @param [out] CmObject Pointer to the Configuration Manager Object - descriptor describing the requested Object. + @param [in] This Pointer to the Configuration Manager Protoc= ol. + @param [in] CmObjectId The Configuration Manager Object ID. + @param [in] Token An optional token identifying the object. If + unused this must be CM_NULL_TOKEN. + @param [in, out] CmObject Pointer to the Configuration Manager Object + descriptor describing the requested Object. =20 @retval EFI_SUCCESS Success. @retval EFI_INVALID_PARAMETER A parameter is invalid. @retval EFI_NOT_FOUND The required object information is not fou= nd. -*/ +**/ EFI_STATUS EFIAPI ArmVExpressPlatformGetObject ( @@ -522,15 +522,15 @@ ArmVExpressPlatformGetObject ( Configuration Manager Protocol for updating the Configuration Manager Objects. =20 - @param [in] This Pointer to the Configuration Manager Protocol. - @param [in] CmObjectId The Configuration Manager Object ID. - @param [in] Token An optional token identifying the object. If - unused this must be CM_NULL_TOKEN. - @param [out] CmObject Pointer to the Configuration Manager Object - descriptor describing the Object. + @param [in] This Pointer to the Configuration Manager Protoc= ol. + @param [in] CmObjectId The Configuration Manager Object ID. + @param [in] Token An optional token identifying the object. If + unused this must be CM_NULL_TOKEN. + @param [in] CmObject Pointer to the Configuration Manager Object + descriptor describing the Object. =20 @retval EFI_UNSUPPORTED This operation is not supported. -*/ +**/ EFI_STATUS EFIAPI ArmVExpressPlatformSetObject ( --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel From nobody Mon May 6 11:05:44 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1530118147399120.12161549890595; Wed, 27 Jun 2018 09:49:07 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id A1CE1202E5419; Wed, 27 Jun 2018 09:48:59 -0700 (PDT) Received: from cam-smtp0.cambridge.arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8808A202E53F8 for ; Wed, 27 Jun 2018 09:48:57 -0700 (PDT) Received: from E107187.Emea.Arm.com (E107187.Emea.Arm.com [10.1.206.129]) by cam-smtp0.cambridge.arm.com (8.13.8/8.13.8) with ESMTP id w5RGmrcS010379; Wed, 27 Jun 2018 17:48:55 +0100 X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.96.140; helo=cam-smtp0.cambridge.arm.com; envelope-from=sami.mujawar@arm.com; receiver=edk2-devel@lists.01.org From: Sami Mujawar To: edk2-devel@lists.01.org Date: Wed, 27 Jun 2018 17:48:45 +0100 Message-Id: <20180627164848.24124-4-sami.mujawar@arm.com> X-Mailer: git-send-email 2.11.0.windows.3 In-Reply-To: <20180627164848.24124-1-sami.mujawar@arm.com> References: <20180627164848.24124-1-sami.mujawar@arm.com> Subject: [edk2] [PATCH edk2-platforms v1 3/6][platforms/devel-dynamictables] Platform/ARM: FVP: Fix variable declaration X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nd@arm.com, Arvind Chauhan , Stephanie.Hughes-Fitt@arm.com MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Fixed the 'There should be no initialization of a variable as part of its declaration Variable Name' errors reported by the ecc tool. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Sami Mujawar Reviewed-by: Evan Lloyd Reviewed-by: Leif Lindholm Reviewed-by? --- Notes: v1: - Fix ecc tool reported issues [SAMI] Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/Conf= igurationManager.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationMan= agerDxe/ConfigurationManager.c b/Platform/ARM/VExpressPkg/ConfigurationMana= ger/ConfigurationManagerDxe/ConfigurationManager.c index a67a09cb6c197a14b376d4a8ef9a90e438efb2bb..35104612e691613f7bbc43511bb= 921ff111e1fe9 100644 --- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe= /ConfigurationManager.c +++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe= /ConfigurationManager.c @@ -303,9 +303,10 @@ GetStandardNameSpaceObject ( IN OUT CM_OBJ_DESCRIPTOR * CONST CmObject ) { - EFI_STATUS Status =3D EFI_SUCCESS; + EFI_STATUS Status; EFI_PLATFORM_REPOSITORY_INFO * PlatformRepo; =20 + Status =3D EFI_SUCCESS; if ((This =3D=3D NULL) || (CmObject =3D=3D NULL)) { ASSERT (This !=3D NULL); ASSERT (CmObject !=3D NULL); @@ -353,9 +354,10 @@ GetArmNameSpaceObject ( IN OUT CM_OBJ_DESCRIPTOR * CONST CmObject ) { - EFI_STATUS Status =3D EFI_SUCCESS; + EFI_STATUS Status; EFI_PLATFORM_REPOSITORY_INFO * PlatformRepo; =20 + Status =3D EFI_SUCCESS; if ((This =3D=3D NULL) || (CmObject =3D=3D NULL)) { ASSERT (This !=3D NULL); ASSERT (CmObject !=3D NULL); @@ -437,8 +439,9 @@ GetOemNameSpaceObject ( IN OUT CM_OBJ_DESCRIPTOR * CONST CmObject ) { - EFI_STATUS Status =3D EFI_SUCCESS; + EFI_STATUS Status; =20 + Status =3D EFI_SUCCESS; if ((This =3D=3D NULL) || (CmObject =3D=3D NULL)) { ASSERT (This !=3D NULL); ASSERT (CmObject !=3D NULL); --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel From nobody Mon May 6 11:05:44 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1530118141261866.2644793137367; Wed, 27 Jun 2018 09:49:01 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 3B0DB202E540A; Wed, 27 Jun 2018 09:48:59 -0700 (PDT) Received: from cam-smtp0.cambridge.arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5B08E202E535A for ; Wed, 27 Jun 2018 09:48:57 -0700 (PDT) Received: from E107187.Emea.Arm.com (E107187.Emea.Arm.com [10.1.206.129]) by cam-smtp0.cambridge.arm.com (8.13.8/8.13.8) with ESMTP id w5RGmrcT010379; Wed, 27 Jun 2018 17:48:55 +0100 X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.96.140; helo=cam-smtp0.cambridge.arm.com; envelope-from=sami.mujawar@arm.com; receiver=edk2-devel@lists.01.org From: Sami Mujawar To: edk2-devel@lists.01.org Date: Wed, 27 Jun 2018 17:48:46 +0100 Message-Id: <20180627164848.24124-5-sami.mujawar@arm.com> X-Mailer: git-send-email 2.11.0.windows.3 In-Reply-To: <20180627164848.24124-1-sami.mujawar@arm.com> References: <20180627164848.24124-1-sami.mujawar@arm.com> Subject: [edk2] [PATCH edk2-platforms v1 4/6][platforms/devel-dynamictables] Platform/ARM: Juno: Add module info to file header X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nd@arm.com, Arvind Chauhan , Stephanie.Hughes-Fitt@arm.com MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The ecc tool reports that the Header comment section must have Abstract information. Added a brief module description to the file header. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Sami Mujawar Reviewed-by: Evan Lloyd Reviewed-by: Leif Lindholm Reviewed-by? --- Notes: v1: - Fix ecc tool reported issues [SAMI] Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManager.dsc.inc = | 3 ++- Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/Configur= ationManagerDxe.inf | 1 + Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/PlatformASL= TablesLib.inf | 1 + 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManager= .dsc.inc b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManager.d= sc.inc index d811556603cbdd157cfcfe2c61976b469ea15e29..4a36ffcd46129b1d6207fa7ffe8= 3443404f93629 100644 --- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManager.dsc.inc +++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManager.dsc.inc @@ -1,6 +1,7 @@ ## @file +# dsc include file for Configuration Manager # -# Copyright (c) 2017, ARM Limited. All rights reserved. +# Copyright (c) 2017 - 2018, ARM Limited. All rights reserved. # # This program and the accompanying materials # are licensed and made available under the terms and conditions of the B= SD License diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManager= Dxe/ConfigurationManagerDxe.inf b/Platform/ARM/JunoPkg/ConfigurationManager= /ConfigurationManagerDxe/ConfigurationManagerDxe.inf index c1bd6de9a2fb9fbe592d91ee77c6107580a3fb5a..70c97e788aea7e5297eb152a738= 3b528994f1021 100644 --- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/Con= figurationManagerDxe.inf +++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/Con= figurationManagerDxe.inf @@ -1,4 +1,5 @@ ## @file +# Configuration Manager Dxe # # Copyright (c) 2017 - 2018, ARM Limited. All rights reserved. # diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib= /PlatformASLTablesLib.inf b/Platform/ARM/JunoPkg/ConfigurationManager/Platf= ormASLTablesLib/PlatformASLTablesLib.inf index 4b6e48d3efcd3ceb094c4b291eaa4c3060e93b92..3a706f2c27d4c28a17354e1d60a= 84af71d34a4a9 100644 --- a/Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/Platfo= rmASLTablesLib.inf +++ b/Platform/ARM/JunoPkg/ConfigurationManager/PlatformASLTablesLib/Platfo= rmASLTablesLib.inf @@ -1,4 +1,5 @@ ## @file +# Platform ASL Tables # # Copyright (c) 2017 - 2018, ARM Limited. All rights reserved. # --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel From nobody Mon May 6 11:05:44 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1530118159378198.25270130448303; Wed, 27 Jun 2018 09:49:19 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 3B142202E541F; Wed, 27 Jun 2018 09:49:00 -0700 (PDT) Received: from cam-smtp0.cambridge.arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AA8F021BADAB3 for ; Wed, 27 Jun 2018 09:48:57 -0700 (PDT) Received: from E107187.Emea.Arm.com (E107187.Emea.Arm.com [10.1.206.129]) by cam-smtp0.cambridge.arm.com (8.13.8/8.13.8) with ESMTP id w5RGmrcU010379; Wed, 27 Jun 2018 17:48:55 +0100 X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.96.140; helo=cam-smtp0.cambridge.arm.com; envelope-from=sami.mujawar@arm.com; receiver=edk2-devel@lists.01.org From: Sami Mujawar To: edk2-devel@lists.01.org Date: Wed, 27 Jun 2018 17:48:47 +0100 Message-Id: <20180627164848.24124-6-sami.mujawar@arm.com> X-Mailer: git-send-email 2.11.0.windows.3 In-Reply-To: <20180627164848.24124-1-sami.mujawar@arm.com> References: <20180627164848.24124-1-sami.mujawar@arm.com> Subject: [edk2] [PATCH edk2-platforms v1 5/6][platforms/devel-dynamictables] Platform/ARM: Juno: Fix function documentation X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nd@arm.com, Arvind Chauhan , Stephanie.Hughes-Fitt@arm.com MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Fixed function documentation issues reported by ecc tool. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Sami Mujawar Reviewed-by: Evan Lloyd Reviewed-by: Leif Lindholm Reviewed-by? --- Notes: v1: - Fix ecc tool reported issues [SAMI] Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/Configur= ationManager.c | 72 ++++++++++---------- 1 file changed, 36 insertions(+), 36 deletions(-) diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManager= Dxe/ConfigurationManager.c b/Platform/ARM/JunoPkg/ConfigurationManager/Conf= igurationManagerDxe/ConfigurationManager.c index 4c878f663ab247307a17582c07f303ddb11b7d41..c0086bddb82fb7108aa0d5dccff= b6b02c0cb73c4 100644 --- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/Con= figurationManager.c +++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/Con= figurationManager.c @@ -228,7 +228,7 @@ EFI_PLATFORM_REPOSITORY_INFO ArmJunoPlatformRepositoryI= nfo =3D { @param [in] This Pointer to the Configuration Manager Protocol. =20 @retval EFI_SUCCESS Success -*/ +**/ STATIC EFI_STATUS EFIAPI @@ -247,17 +247,17 @@ InitializePlatformRepository ( =20 /** Return a standard namespace object. =20 - @param [in] This Pointer to the Configuration Manager Protocol. - @param [in] CmObjectId The Configuration Manager Object ID. - @param [in] Token An optional token identifying the object. If - unused this must be CM_NULL_TOKEN. - @param [out] CmObject Pointer to the Configuration Manager Object - descriptor describing the requested Object. + @param [in] This Pointer to the Configuration Manager Protoc= ol. + @param [in] CmObjectId The Configuration Manager Object ID. + @param [in] Token An optional token identifying the object. If + unused this must be CM_NULL_TOKEN. + @param [in, out] CmObject Pointer to the Configuration Manager Object + descriptor describing the requested Object. =20 @retval EFI_SUCCESS Success. @retval EFI_INVALID_PARAMETER A parameter is invalid. @retval EFI_NOT_FOUND The required object information is not fou= nd. -*/ +**/ EFI_STATUS EFIAPI GetStandardNameSpaceObject ( @@ -319,17 +319,17 @@ GetStandardNameSpaceObject ( =20 /** Return an ARM namespace object. =20 - @param [in] This Pointer to the Configuration Manager Protocol. - @param [in] CmObjectId The Configuration Manager Object ID. - @param [in] Token An optional token identifying the object. If - unused this must be CM_NULL_TOKEN. - @param [out] CmObject Pointer to the Configuration Manager Object - descriptor describing the requested Object. + @param [in] This Pointer to the Configuration Manager Protoc= ol. + @param [in] CmObjectId The Configuration Manager Object ID. + @param [in] Token An optional token identifying the object. If + unused this must be CM_NULL_TOKEN. + @param [in, out] CmObject Pointer to the Configuration Manager Object + descriptor describing the requested Object. =20 @retval EFI_SUCCESS Success. @retval EFI_INVALID_PARAMETER A parameter is invalid. @retval EFI_NOT_FOUND The required object information is not fou= nd. -*/ +**/ EFI_STATUS EFIAPI GetArmNameSpaceObject ( @@ -399,17 +399,17 @@ GetArmNameSpaceObject ( =20 /** Return an OEM namespace object. =20 - @param [in] This Pointer to the Configuration Manager Protocol. - @param [in] CmObjectId The Configuration Manager Object ID. - @param [in] Token An optional token identifying the object. If - unused this must be CM_NULL_TOKEN. - @param [out] CmObject Pointer to the Configuration Manager Object - descriptor describing the requested Object. + @param [in] This Pointer to the Configuration Manager Protoc= ol. + @param [in] CmObjectId The Configuration Manager Object ID. + @param [in] Token An optional token identifying the object. If + unused this must be CM_NULL_TOKEN. + @param [in, out] CmObject Pointer to the Configuration Manager Object + descriptor describing the requested Object. =20 @retval EFI_SUCCESS Success. @retval EFI_INVALID_PARAMETER A parameter is invalid. @retval EFI_NOT_FOUND The required object information is not fou= nd. -*/ +**/ EFI_STATUS EFIAPI GetOemNameSpaceObject ( @@ -447,17 +447,17 @@ GetOemNameSpaceObject ( Configuration Manager Protocol for returning the Configuration Manager Objects. =20 - @param [in] This Pointer to the Configuration Manager Protocol. - @param [in] CmObjectId The Configuration Manager Object ID. - @param [in] Token An optional token identifying the object. If - unused this must be CM_NULL_TOKEN. - @param [out] CmObject Pointer to the Configuration Manager Object - descriptor describing the requested Object. + @param [in] This Pointer to the Configuration Manager Protoc= ol. + @param [in] CmObjectId The Configuration Manager Object ID. + @param [in] Token An optional token identifying the object. If + unused this must be CM_NULL_TOKEN. + @param [in, out] CmObject Pointer to the Configuration Manager Object + descriptor describing the requested Object. =20 @retval EFI_SUCCESS Success. @retval EFI_INVALID_PARAMETER A parameter is invalid. @retval EFI_NOT_FOUND The required object information is not fou= nd. -*/ +**/ EFI_STATUS EFIAPI ArmJunoPlatformGetObject ( @@ -504,15 +504,15 @@ ArmJunoPlatformGetObject ( Configuration Manager Protocol for updating the Configuration Manager Objects. =20 - @param [in] This Pointer to the Configuration Manager Protocol. - @param [in] CmObjectId The Configuration Manager Object ID. - @param [in] Token An optional token identifying the object. If - unused this must be CM_NULL_TOKEN. - @param [out] CmObject Pointer to the Configuration Manager Object - descriptor describing the Object. + @param [in] This Pointer to the Configuration Manager Protoc= ol. + @param [in] CmObjectId The Configuration Manager Object ID. + @param [in] Token An optional token identifying the object. If + unused this must be CM_NULL_TOKEN. + @param [in] CmObject Pointer to the Configuration Manager Object + descriptor describing the Object. =20 @retval EFI_UNSUPPORTED This operation is not supported. -*/ +**/ EFI_STATUS EFIAPI ArmJunoPlatformSetObject ( --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel From nobody Mon May 6 11:05:44 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1530118155369564.2715026799366; Wed, 27 Jun 2018 09:49:15 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 07F2721CB74A7; Wed, 27 Jun 2018 09:49:00 -0700 (PDT) Received: from cam-smtp0.cambridge.arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9F266202E53FE for ; Wed, 27 Jun 2018 09:48:57 -0700 (PDT) Received: from E107187.Emea.Arm.com (E107187.Emea.Arm.com [10.1.206.129]) by cam-smtp0.cambridge.arm.com (8.13.8/8.13.8) with ESMTP id w5RGmrcV010379; Wed, 27 Jun 2018 17:48:55 +0100 X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.96.140; helo=cam-smtp0.cambridge.arm.com; envelope-from=sami.mujawar@arm.com; receiver=edk2-devel@lists.01.org From: Sami Mujawar To: edk2-devel@lists.01.org Date: Wed, 27 Jun 2018 17:48:48 +0100 Message-Id: <20180627164848.24124-7-sami.mujawar@arm.com> X-Mailer: git-send-email 2.11.0.windows.3 In-Reply-To: <20180627164848.24124-1-sami.mujawar@arm.com> References: <20180627164848.24124-1-sami.mujawar@arm.com> Subject: [edk2] [PATCH edk2-platforms v1 6/6][platforms/devel-dynamictables] Platform/ARM: Juno: Fix variable declaration X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nd@arm.com, Arvind Chauhan , Stephanie.Hughes-Fitt@arm.com MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Fixed the 'There should be no initialization of a variable as part of its declaration Variable Name' errors reported by the ecc tool. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Sami Mujawar Reviewed-by: Evan Lloyd Reviewed-by: Leif Lindholm Reviewed-by? --- Notes: v1: - Fix ecc tool reported issues [SAMI] Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/Configur= ationManager.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManager= Dxe/ConfigurationManager.c b/Platform/ARM/JunoPkg/ConfigurationManager/Conf= igurationManagerDxe/ConfigurationManager.c index c0086bddb82fb7108aa0d5dccffb6b02c0cb73c4..db29d1351f4e2ae7195887b4c9a= 2833ef078f6f4 100644 --- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/Con= figurationManager.c +++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/Con= figurationManager.c @@ -267,9 +267,11 @@ GetStandardNameSpaceObject ( IN OUT CM_OBJ_DESCRIPTOR * CONST CmObject ) { - EFI_STATUS Status =3D EFI_SUCCESS; + EFI_STATUS Status; EFI_PLATFORM_REPOSITORY_INFO * PlatformRepo; + UINT32 TableCount; =20 + Status =3D EFI_SUCCESS; if ((This =3D=3D NULL) || (CmObject =3D=3D NULL)) { ASSERT (This !=3D NULL); ASSERT (CmObject !=3D NULL); @@ -284,8 +286,8 @@ GetStandardNameSpaceObject ( if (PlatformRepo->JunoRevision !=3D JUNO_REVISION_R0) { CmObject->Size =3D sizeof (PlatformRepo->CmAcpiTableList); } else { - UINT32 TableCount =3D sizeof (PlatformRepo->CmAcpiTableList) / - sizeof (PlatformRepo->CmAcpiTableList[0]); + TableCount =3D sizeof (PlatformRepo->CmAcpiTableList) / + sizeof (PlatformRepo->CmAcpiTableList[0]); /* The last 2 tables in the ACPI table list enable PCIe support. Reduce the CmObject size so that the PCIe specific ACPI tables are not installed on Juno R0 @@ -339,9 +341,10 @@ GetArmNameSpaceObject ( IN OUT CM_OBJ_DESCRIPTOR * CONST CmObject ) { - EFI_STATUS Status =3D EFI_SUCCESS; + EFI_STATUS Status; EFI_PLATFORM_REPOSITORY_INFO * PlatformRepo; =20 + Status =3D EFI_SUCCESS; if ((This =3D=3D NULL) || (CmObject =3D=3D NULL)) { ASSERT (This !=3D NULL); ASSERT (CmObject !=3D NULL); @@ -419,8 +422,9 @@ GetOemNameSpaceObject ( IN OUT CM_OBJ_DESCRIPTOR * CONST CmObject ) { - EFI_STATUS Status =3D EFI_SUCCESS; + EFI_STATUS Status; =20 + Status =3D EFI_SUCCESS; if ((This =3D=3D NULL) || (CmObject =3D=3D NULL)) { ASSERT (This !=3D NULL); ASSERT (CmObject !=3D NULL); --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel