[edk2] [patch] MdeModulePkg/CapsuleRuntimeDxe: Fix ECC issue

Dandan Bi posted 1 patch 5 years, 9 months ago
Failed in applying to current master (apply log)
MdeModulePkg/Universal/CapsuleRuntimeDxe/Arm/CapsuleReset.c | 2 +-
MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleService.h   | 5 +++++
2 files changed, 6 insertions(+), 1 deletion(-)
[edk2] [patch] MdeModulePkg/CapsuleRuntimeDxe: Fix ECC issue
Posted by Dandan Bi 5 years, 9 months ago
Add guard macro for new added header file.

Cc: Star Zeng <star.zeng@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
 MdeModulePkg/Universal/CapsuleRuntimeDxe/Arm/CapsuleReset.c | 2 +-
 MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleService.h   | 5 +++++
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/MdeModulePkg/Universal/CapsuleRuntimeDxe/Arm/CapsuleReset.c b/MdeModulePkg/Universal/CapsuleRuntimeDxe/Arm/CapsuleReset.c
index 32579ceefb5..d79d2fc6932 100644
--- a/MdeModulePkg/Universal/CapsuleRuntimeDxe/Arm/CapsuleReset.c
+++ b/MdeModulePkg/Universal/CapsuleRuntimeDxe/Arm/CapsuleReset.c
@@ -1,6 +1,6 @@
- /** @file
+/** @file
   ARM implementation of architecture specific routines related to
   PersistAcrossReset capsules
 
   Copyright (c) 2018, Linaro, Ltd. All rights reserved.<BR>
 
diff --git a/MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleService.h b/MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleService.h
index 7a5df742f1e..787c70c1957 100644
--- a/MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleService.h
+++ b/MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleService.h
@@ -15,10 +15,13 @@
   THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
   WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 
 **/
 
+#ifndef _CAPSULE_SERVICE_H_
+#define _CAPSULE_SERVICE_H_
+
 #include <Uefi.h>
 
 #include <Protocol/Capsule.h>
 #include <Guid/CapsuleVendor.h>
 #include <Guid/FmpCapsule.h>
@@ -67,5 +70,7 @@ IsPersistAcrossResetCapsuleSupported (
 **/
 VOID
 CapsuleCacheWriteBack (
   IN  EFI_PHYSICAL_ADDRESS    ScatterGatherList
   );
+
+#endif
-- 
2.14.3.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [patch] MdeModulePkg/CapsuleRuntimeDxe: Fix ECC issue
Posted by Zeng, Star 5 years, 9 months ago
Reviewed-by: Star Zeng <star.zeng@intel.com>

-----Original Message-----
From: Bi, Dandan 
Sent: Monday, June 25, 2018 9:08 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star <star.zeng@intel.com>
Subject: [patch] MdeModulePkg/CapsuleRuntimeDxe: Fix ECC issue

Add guard macro for new added header file.

Cc: Star Zeng <star.zeng@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
 MdeModulePkg/Universal/CapsuleRuntimeDxe/Arm/CapsuleReset.c | 2 +-
 MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleService.h   | 5 +++++
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/MdeModulePkg/Universal/CapsuleRuntimeDxe/Arm/CapsuleReset.c b/MdeModulePkg/Universal/CapsuleRuntimeDxe/Arm/CapsuleReset.c
index 32579ceefb5..d79d2fc6932 100644
--- a/MdeModulePkg/Universal/CapsuleRuntimeDxe/Arm/CapsuleReset.c
+++ b/MdeModulePkg/Universal/CapsuleRuntimeDxe/Arm/CapsuleReset.c
@@ -1,6 +1,6 @@
- /** @file
+/** @file
   ARM implementation of architecture specific routines related to
   PersistAcrossReset capsules
 
   Copyright (c) 2018, Linaro, Ltd. All rights reserved.<BR>
 
diff --git a/MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleService.h b/MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleService.h
index 7a5df742f1e..787c70c1957 100644
--- a/MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleService.h
+++ b/MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleService.h
@@ -15,10 +15,13 @@
   THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
   WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 
 **/
 
+#ifndef _CAPSULE_SERVICE_H_
+#define _CAPSULE_SERVICE_H_
+
 #include <Uefi.h>
 
 #include <Protocol/Capsule.h>
 #include <Guid/CapsuleVendor.h>
 #include <Guid/FmpCapsule.h>
@@ -67,5 +70,7 @@ IsPersistAcrossResetCapsuleSupported (  **/  VOID  CapsuleCacheWriteBack (
   IN  EFI_PHYSICAL_ADDRESS    ScatterGatherList
   );
+
+#endif
--
2.14.3.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel