[edk2] [patch] SignedCapsulePkg/SystemFirmwareUpdateDxe: Fix ECC issues

Dandan Bi posted 1 patch 5 years, 9 months ago
Failed in applying to current master (apply log)
.../Universal/SystemFirmwareUpdate/SystemFirmwareUpdateDxe.c         | 5 +++++
1 file changed, 5 insertions(+)
[edk2] [patch] SignedCapsulePkg/SystemFirmwareUpdateDxe: Fix ECC issues
Posted by Dandan Bi 5 years, 9 months ago
Make function comments align with functions.

Cc: Star Zeng <star.zeng@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
 .../Universal/SystemFirmwareUpdate/SystemFirmwareUpdateDxe.c         | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdateDxe.c b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdateDxe.c
index 8e66aedf627..a1ce5b486f7 100644
--- a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdateDxe.c
+++ b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdateDxe.c
@@ -57,10 +57,13 @@ ParseUpdateDataFile (
   @param[in]  SystemFirmwareImage     Points to the System Firmware image.
   @param[in]  SystemFirmwareImageSize The length of the System Firmware image in bytes.
   @param[in]  ConfigData              Points to the component configuration structure.
   @param[out] LastAttemptVersion      The last attempt version, which will be recorded in ESRT and FMP EFI_FIRMWARE_IMAGE_DESCRIPTOR.
   @param[out] LastAttemptStatus       The last attempt status, which will be recorded in ESRT and FMP EFI_FIRMWARE_IMAGE_DESCRIPTOR.
+  @param[in]  Progress                A function used by the driver to report the progress of the firmware update.
+  @param[in]  StartPercentage         The start completion percentage value that may be used to report progress during the flash write operation.
+  @param[in]  EndPercentage           The end completion percentage value that may be used to report progress during the flash write operation.
 
   @retval EFI_SUCCESS             The System Firmware image is updated.
   @retval EFI_WRITE_PROTECTED     The flash device is read only.
 **/
 EFI_STATUS
@@ -115,10 +118,11 @@ PerformUpdate (
   @param[in]  SystemFirmwareImageSize The length of the System Firmware image in bytes.
   @param[in]  ConfigImage             Points to the config file image.
   @param[in]  ConfigImageSize         The length of the config file image in bytes.
   @param[out] LastAttemptVersion      The last attempt version, which will be recorded in ESRT and FMP EFI_FIRMWARE_IMAGE_DESCRIPTOR.
   @param[out] LastAttemptStatus       The last attempt status, which will be recorded in ESRT and FMP EFI_FIRMWARE_IMAGE_DESCRIPTOR.
+  @param[in]  Progress                A function used by the driver to report the progress of the firmware update.
 
   @retval EFI_SUCCESS             The System Firmware image is updated.
   @retval EFI_WRITE_PROTECTED     The flash device is read only.
 **/
 EFI_STATUS
@@ -243,10 +247,11 @@ UpdateImage (
 
   @param[in]  Image              The EDKII system FMP capsule image.
   @param[in]  ImageSize          The size of the EDKII system FMP capsule image in bytes.
   @param[out] LastAttemptVersion The last attempt version, which will be recorded in ESRT and FMP EFI_FIRMWARE_IMAGE_DESCRIPTOR.
   @param[out] LastAttemptStatus  The last attempt status, which will be recorded in ESRT and FMP EFI_FIRMWARE_IMAGE_DESCRIPTOR.
+  @param[in]  Progress           A function used by the driver to report the progress of the firmware update.
 
   @retval EFI_SUCCESS             EDKII system FMP capsule passes authentication and the System Firmware image is updated.
   @retval EFI_SECURITY_VIOLATION  EDKII system FMP capsule fails authentication and the System Firmware image is not updated.
   @retval EFI_WRITE_PROTECTED     The flash device is read only.
 **/
-- 
2.14.3.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [patch] SignedCapsulePkg/SystemFirmwareUpdateDxe: Fix ECC issues
Posted by Zeng, Star 5 years, 9 months ago
Reviewed-by: Star Zeng <star.zeng@intel.com>

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Dandan Bi
Sent: Tuesday, June 19, 2018 3:39 PM
To: edk2-devel@lists.01.org
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: [edk2] [patch] SignedCapsulePkg/SystemFirmwareUpdateDxe: Fix ECC issues

Make function comments align with functions.

Cc: Star Zeng <star.zeng@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
 .../Universal/SystemFirmwareUpdate/SystemFirmwareUpdateDxe.c         | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdateDxe.c b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdateDxe.c
index 8e66aedf627..a1ce5b486f7 100644
--- a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdateDxe.c
+++ b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdateDxe.c
@@ -57,10 +57,13 @@ ParseUpdateDataFile (
   @param[in]  SystemFirmwareImage     Points to the System Firmware image.
   @param[in]  SystemFirmwareImageSize The length of the System Firmware image in bytes.
   @param[in]  ConfigData              Points to the component configuration structure.
   @param[out] LastAttemptVersion      The last attempt version, which will be recorded in ESRT and FMP EFI_FIRMWARE_IMAGE_DESCRIPTOR.
   @param[out] LastAttemptStatus       The last attempt status, which will be recorded in ESRT and FMP EFI_FIRMWARE_IMAGE_DESCRIPTOR.
+  @param[in]  Progress                A function used by the driver to report the progress of the firmware update.
+  @param[in]  StartPercentage         The start completion percentage value that may be used to report progress during the flash write operation.
+  @param[in]  EndPercentage           The end completion percentage value that may be used to report progress during the flash write operation.
 
   @retval EFI_SUCCESS             The System Firmware image is updated.
   @retval EFI_WRITE_PROTECTED     The flash device is read only.
 **/
 EFI_STATUS
@@ -115,10 +118,11 @@ PerformUpdate (
   @param[in]  SystemFirmwareImageSize The length of the System Firmware image in bytes.
   @param[in]  ConfigImage             Points to the config file image.
   @param[in]  ConfigImageSize         The length of the config file image in bytes.
   @param[out] LastAttemptVersion      The last attempt version, which will be recorded in ESRT and FMP EFI_FIRMWARE_IMAGE_DESCRIPTOR.
   @param[out] LastAttemptStatus       The last attempt status, which will be recorded in ESRT and FMP EFI_FIRMWARE_IMAGE_DESCRIPTOR.
+  @param[in]  Progress                A function used by the driver to report the progress of the firmware update.
 
   @retval EFI_SUCCESS             The System Firmware image is updated.
   @retval EFI_WRITE_PROTECTED     The flash device is read only.
 **/
 EFI_STATUS
@@ -243,10 +247,11 @@ UpdateImage (
 
   @param[in]  Image              The EDKII system FMP capsule image.
   @param[in]  ImageSize          The size of the EDKII system FMP capsule image in bytes.
   @param[out] LastAttemptVersion The last attempt version, which will be recorded in ESRT and FMP EFI_FIRMWARE_IMAGE_DESCRIPTOR.
   @param[out] LastAttemptStatus  The last attempt status, which will be recorded in ESRT and FMP EFI_FIRMWARE_IMAGE_DESCRIPTOR.
+  @param[in]  Progress           A function used by the driver to report the progress of the firmware update.
 
   @retval EFI_SUCCESS             EDKII system FMP capsule passes authentication and the System Firmware image is updated.
   @retval EFI_SECURITY_VIOLATION  EDKII system FMP capsule fails authentication and the System Firmware image is not updated.
   @retval EFI_WRITE_PROTECTED     The flash device is read only.
 **/
-- 
2.14.3.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel