From nobody Thu May 2 03:49:31 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1511540441320209.27464200333452; Fri, 24 Nov 2017 08:20:41 -0800 (PST) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 3F2CB220F3C46; Fri, 24 Nov 2017 08:16:21 -0800 (PST) Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B6BB6220F3C40 for ; Fri, 24 Nov 2017 08:16:18 -0800 (PST) Received: by mail-wm0-x241.google.com with SMTP id v186so23575540wma.2 for ; Fri, 24 Nov 2017 08:20:37 -0800 (PST) Received: from e108454-lin.cambridge.arm.com ([2001:41d0:1:6c23::1]) by smtp.gmail.com with ESMTPSA id k30sm38803840wrf.63.2017.11.24.08.20.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Nov 2017 08:20:35 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::241; helo=mail-wm0-x241.google.com; envelope-from=julien.grall@linaro.org; receiver=edk2-devel@lists.01.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=C7XI33g3MwrgAHJ0EsONmW08cWz4i9g9hQH+kFHrLnk=; b=dFpGt32on4kqsCoWszBCzkE/+wye097UcoKrrPq/tVPL/zyVc2MoInfqMRsXLPWp/b ObCnZKgnbTNElP2YI2iN9l6eCuSTaXF5uT4RYp3+ZiGummZc0BJvr8LFGbZWUg4uKR0s mHxIszIpNCu4jU9jFP4LyURKrwlnPLisZBlf8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=C7XI33g3MwrgAHJ0EsONmW08cWz4i9g9hQH+kFHrLnk=; b=FWl7NynUsIOLXjyqRM+3tqUwX/36heQFUNwH6Vp1YdgV6jZJp58NbwHJqzHi36mpjg 1ooKCGPkTBOgBMl1HkTdVLtqv20BuVZZy+nIgZDIap/1zrZrXytjOevz8X6d7znDtAQS QKstlYqruLSJXTme47iylabZw6yntO0GDfqC9oex6FPsasOmAr8dvSsYFWNf5qhVfS1y fMbjnDKN9Ld1HVqkD7uBZmSzp65f86NAvTwg+5GxGoIEp5jPlt88hvPX29kUzdfVxw1b q9ZGIfXLJHaraUwb6D9+ptFQaXsQWks8EWepLPxn1yh7Tb4JmDFex9E2Kjx2+dDdGEHk K++A== X-Gm-Message-State: AJaThX6zAuOQbi9TYHZDyWHcuB889FfYsKxQXwRd9vWKrChvHU7ajWM7 2hvUq0QKrtXDduTLTITlysZL2w== X-Google-Smtp-Source: AGs4zMYCRQ6+OY3YqMyXXCHBChanXYNcLV+93heutyA7rsXOM/8kFgkGYeZW7qc32Ck5ox1QBjRRNg== X-Received: by 10.28.157.7 with SMTP id g7mr9540080wme.99.1511540436029; Fri, 24 Nov 2017 08:20:36 -0800 (PST) From: Julien Grall To: star.zeng@intel.com, eric.dong@intel.com, pankaj.bansal@nxp.com, lersek@redhat.com, leif.lindholm@linaro.org Date: Fri, 24 Nov 2017 16:20:28 +0000 Message-Id: <20171124162030.31156-2-julien.grall@linaro.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171124162030.31156-1-julien.grall@linaro.org> References: <20171124162030.31156-1-julien.grall@linaro.org> Subject: [edk2] [PATCH v2 1/3] MdeModulePkg/SerialDxe: Describe correctly EFI_DEVICE_ERROR for SetAttributes X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: edk2-devel@lists.01.org MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Per the UEFIv2.7 spec, EFI_DEVICE_ERROR is returned when the serial device is not functioning correctly. Update the description to avoid confusion. Contributed-under: Tianocore Contribution Agreement 1.1 Signed-off-by: Julien Grall Reviewed-by: Star Zeng with some minor comments in th= e separated patches. reviewed-by? --- MdeModulePkg/Universal/SerialDxe/SerialIo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/SerialDxe/SerialIo.c b/MdeModulePkg/Uni= versal/SerialDxe/SerialIo.c index 964d0329f4..5946a6e2f3 100644 --- a/MdeModulePkg/Universal/SerialDxe/SerialIo.c +++ b/MdeModulePkg/Universal/SerialDxe/SerialIo.c @@ -265,7 +265,7 @@ SerialReset ( stop bits. =20 @retval EFI_SUCCESS The device was reset. - @retval EFI_DEVICE_ERROR The serial device could not be reset. + @retval EFI_DEVICE_ERROR The serial device is not functioning correctly. =20 **/ EFI_STATUS --=20 2.11.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel From nobody Thu May 2 03:49:31 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1511540443661617.4045867643115; Fri, 24 Nov 2017 08:20:43 -0800 (PST) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 78473220F3C4A; Fri, 24 Nov 2017 08:16:21 -0800 (PST) Received: from mail-wr0-x241.google.com (mail-wr0-x241.google.com [IPv6:2a00:1450:400c:c0c::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E7032220F3C43 for ; Fri, 24 Nov 2017 08:16:19 -0800 (PST) Received: by mail-wr0-x241.google.com with SMTP id u40so20787262wrf.10 for ; Fri, 24 Nov 2017 08:20:38 -0800 (PST) Received: from e108454-lin.cambridge.arm.com ([2001:41d0:1:6c23::1]) by smtp.gmail.com with ESMTPSA id k30sm38803840wrf.63.2017.11.24.08.20.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Nov 2017 08:20:36 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::241; helo=mail-wr0-x241.google.com; envelope-from=julien.grall@linaro.org; receiver=edk2-devel@lists.01.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=mMuGFrfwfga4dxcOTjsK8Qf5KAouUEBFIbpC8e+wrKA=; b=F1nzBkvKkCrWmx6JUJV8mAUylIMZG8dRyQSZkh2g810ZPofZpQVInBvsI//9eS842R Ah7dcBC3JKfNkHQ9bOrgP405etKzsfVwjrH+wM00OYx0uf90Tjy8LUQpf0Ur+v8nKrgL srgj5mS+0Cny3xTa8fkW58/tE+8Z2xf/fBwhI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=mMuGFrfwfga4dxcOTjsK8Qf5KAouUEBFIbpC8e+wrKA=; b=hzjsKk4Q0Mi0cFbJ8I3WLmrLl+04FDyJugL4uWap2oEr0m/xdmeBjxWWCPGdZNesnP 5tKZu/bUx758cwpMbFmohadNY1QGhxgobCRVCCbX5yR4c4UzO7YZZ6GGNnxI0/olTt6f pbRHxJx1gVL3hphzAVrBStz3PKjplZ2dr6Uv+IW+CtZeJIclp/iICaYcgWONl80XIbxr bMpjB9C9zEKvE1yjSMgX5FtppaVt9taTpxkitBea7x8bs+vzBN0epjUI+WjW/uxj4EgW 9gv1y16Un+awmD+sANpO89R+x3YO5SHeblcdKZrVTKLrFabdPsvrKhmWVmxnt8D9mEZ0 WOBw== X-Gm-Message-State: AJaThX6nyudVFP+jDhLzPCloRofFgdYBV7eXr+ZW9tjRn/vr+oAKLnkb bi/6nZlm2lLlcVNIq2aCuA/IKA== X-Google-Smtp-Source: AGs4zMaWzqdIK8POuV0c2j/MtWyKfSr7qOx19nqyOJJBrIyb2UE6iWPA/ic++3hfYMpXEbAbd4dq4g== X-Received: by 10.223.181.132 with SMTP id c4mr1142490wre.42.1511540436925; Fri, 24 Nov 2017 08:20:36 -0800 (PST) From: Julien Grall To: star.zeng@intel.com, eric.dong@intel.com, pankaj.bansal@nxp.com, lersek@redhat.com, leif.lindholm@linaro.org Date: Fri, 24 Nov 2017 16:20:29 +0000 Message-Id: <20171124162030.31156-3-julien.grall@linaro.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171124162030.31156-1-julien.grall@linaro.org> References: <20171124162030.31156-1-julien.grall@linaro.org> Subject: [edk2] [PATCH v2 2/3] MdeModulePkg/SerialDxe: Fix return valued in SerialSetAttributes X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: edk2-devel@lists.01.org MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" SerialSetAttributes is meant to match the behavior of the function EFI_SERIAL_IO_PROTOCOL.SetAttributes() in the UEFI spec (v2.7). This means the function can only return: - EFI_SUCCESS - EFI_INVALID_PARAMETER - EFI_DEVICE_ERROR However the function SerialPortSetAttributes may also validly return EFI_UNSUPPORTED. For instance this is the case of the Xen Console driver. EFI_UNSUPPORTED could be also interpreted as "One or more of the attributes has an unsupported value". So return EFI_INVALID_PARAMETER in that case. Lastly, to prevent another return slipping in the future, all the errors but EFI_INVALID_PARAMETERR and EFI_UNSUPPORTED will return EFI_DEVICE_ERROR. Contributed-under: Tianocore Contribution Agreement 1.1 Signed-off-by: Julien Grall Reviewed-by: Star Zeng with some minor comments in th= e separated patches. reviewed-by? --- MdeModulePkg/Universal/SerialDxe/SerialIo.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/MdeModulePkg/Universal/SerialDxe/SerialIo.c b/MdeModulePkg/Uni= versal/SerialDxe/SerialIo.c index 5946a6e2f3..08b95a4a33 100644 --- a/MdeModulePkg/Universal/SerialDxe/SerialIo.c +++ b/MdeModulePkg/Universal/SerialDxe/SerialIo.c @@ -264,8 +264,9 @@ SerialReset ( value of DefaultStopBits will use the device's = default number of stop bits. =20 - @retval EFI_SUCCESS The device was reset. - @retval EFI_DEVICE_ERROR The serial device is not functioning correctly. + @retval EFI_SUCCESS The device was reset. + @retval EFI_INVALID_PARAMETER One or more attributes has an unsupported = value. + @retval EFI_DEVICE_ERROR The serial device is not functioning corre= ctly. =20 **/ EFI_STATUS @@ -323,8 +324,10 @@ SerialSetAttributes ( DataBits =3D OriginalDataBits; StopBits =3D OriginalStopBits; Status =3D EFI_SUCCESS; + } else if (Status =3D=3D EFI_INVALID_PARAMETER || Status =3D=3D EFI_UN= SUPPORTED) { + return EFI_INVALID_PARAMETER; } else { - return Status; + return EFI_DEVICE_ERROR; } } =20 --=20 2.11.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel From nobody Thu May 2 03:49:31 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1511540446600365.1862053379491; Fri, 24 Nov 2017 08:20:46 -0800 (PST) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id B73E1220F3C4D; Fri, 24 Nov 2017 08:16:21 -0800 (PST) Received: from mail-wr0-x242.google.com (mail-wr0-x242.google.com [IPv6:2a00:1450:400c:c0c::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6D693220F3C43 for ; Fri, 24 Nov 2017 08:16:20 -0800 (PST) Received: by mail-wr0-x242.google.com with SMTP id s41so15381438wrc.7 for ; Fri, 24 Nov 2017 08:20:39 -0800 (PST) Received: from e108454-lin.cambridge.arm.com ([2001:41d0:1:6c23::1]) by smtp.gmail.com with ESMTPSA id k30sm38803840wrf.63.2017.11.24.08.20.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Nov 2017 08:20:37 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::242; helo=mail-wr0-x242.google.com; envelope-from=julien.grall@linaro.org; receiver=edk2-devel@lists.01.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=12vqC89W4GPyhGrp1c7xCGSKpv+UI711veQLbgWGXgg=; b=LhKn8unMDt/PnPmi/1vl1trbtpijS+gMpAHPiWTHmEuOB7sXHpr8OYT9asnlpvayoR IFsNTaEIggNx3rYfVQwYXj7qCLuFLer1Owb/001+qBEqB0eQR9jxBB3X050dVlCQ75Oi +R2L1B7WbVvcPXNslqb/Ln+ybeGMYFwxrHh24= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=12vqC89W4GPyhGrp1c7xCGSKpv+UI711veQLbgWGXgg=; b=Q6r/AGp5HIIK8AKfvh48wjQI1p/vmTLgI9iPg0DtQ3DUaxHXFOVG7pDwwFE1do19wY Opuyff5hcNk08ZtM84lSa5lwIE4JSVOQ+8Ru3j61+ZsW/aanwSWMv5BlFMJjML1oJ/A4 Y8iYfQnytN5GdGn38Vs899wj+2TSrXAsuxzAXb59/XQefc06X3Atwsz0JhpxMN/vDeOi MHjOI1ebVAB5piYWeMsQzWAfoGXkCddkdfwRhD3s4tzTddnNZFNjq1BdM6XvMYNcHo8s 48Gzne39BDxnhwYbNg77fYBsLFBgGllzOVcN+lVnkvChc1hWwRGE75kxx2ZBrvHil+Gx wEqQ== X-Gm-Message-State: AJaThX7QboituaH30R43g5N6XL6hNpqu0PIqHXB4T2/2zdcCar2aSwcb ZJgUv1VpwfMQAs3qU3dmOeyzgA== X-Google-Smtp-Source: AGs4zMZUQMQDD72r7+a080tjJPto1cIss62+3OZvnXygj2LUxwlVPMK5nj/WglEP/HA1mxIRfttJkw== X-Received: by 10.223.195.203 with SMTP id d11mr27663173wrg.39.1511540437907; Fri, 24 Nov 2017 08:20:37 -0800 (PST) From: Julien Grall To: star.zeng@intel.com, eric.dong@intel.com, pankaj.bansal@nxp.com, lersek@redhat.com, leif.lindholm@linaro.org Date: Fri, 24 Nov 2017 16:20:30 +0000 Message-Id: <20171124162030.31156-4-julien.grall@linaro.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171124162030.31156-1-julien.grall@linaro.org> References: <20171124162030.31156-1-julien.grall@linaro.org> Subject: [edk2] [PATCH v2 3/3] MdeModulePkg/SerialDxe: Do not fail reset when SetAttributes is not supported X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: edk2-devel@lists.01.org MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" After commit 91cc526b15 "MdeModulePkg/SerialDxe: Fix not able to change serial attributes", serial is initialized using the reset method that will call SetAttributes. However, SetAttributes may return EFI_INVALID_PARAMETER when a driver does not support some parameters. This will be propated by the reset function and lead to UEFI failing to get the console setup. For instance, this is the case when using the Xen console driver. Fix it by instropecting the result and return EFI_SUCCESS when the SetAttributes report an invalid parameter (i.e EFI_INVALID_PARAMETER). Contributed-under: Tianocore Contribution Agreement 1.1 Signed-off-by: Julien Grall Reviewed-by: Star Zeng with some minor comments in th= e separated patches. reviewed-by? --- MdeModulePkg/Universal/SerialDxe/SerialIo.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/MdeModulePkg/Universal/SerialDxe/SerialIo.c b/MdeModulePkg/Uni= versal/SerialDxe/SerialIo.c index 08b95a4a33..53d2785fed 100644 --- a/MdeModulePkg/Universal/SerialDxe/SerialIo.c +++ b/MdeModulePkg/Universal/SerialDxe/SerialIo.c @@ -239,6 +239,15 @@ SerialReset ( (EFI_STOP_BITS_TYPE) This->Mode->StopBits ); =20 + // + // The serial device may not support some of the attributes. To prevent + // later failure, always return EFI_SUCCESS when SetAttributes is return= ing + // EFI_INVALID_PARAMETER. + // + if (Status =3D=3D EFI_INVALID_PARAMETER) { + return EFI_SUCCESS; + } + return Status; } =20 --=20 2.11.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel