[edk2] [Patch V4 0/2] Add Max LUN status/value checks

Michael D Kinney posted 2 patches 6 years, 4 months ago
Failed in applying to current master (apply log)
MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c            | 16 +++++++++++++++-
.../Bus/Usb/UsbMassStorageDxe/UsbMassBot.c         | 22 ++++++++++++++++++----
2 files changed, 33 insertions(+), 5 deletions(-)
[edk2] [Patch V4 0/2] Add Max LUN status/value checks
Posted by Michael D Kinney 6 years, 4 months ago
https://bugzilla.tianocore.org/show_bug.cgi?id=767

Changes in V4
* Fix return status from UsbGetMaxLun().

Changes in V3
* Only check number of bytes transfered if Direction is not UsbNoData.

Add error check to USB I/O Protocol UsbControlTransfer() for the
number of bytes actually transfered.  If less than requested, then
return EFI_DEVICE_ERROR.

Check Get Max LUN status/value in USB Mass Storage Driver to handle
cases where USB device does not support Get Max LUN command or
returned an invalud Max LUN value.

Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>

Michael D Kinney (2):
  MdeModulePkg/UsbBusDxe: Add UsbControlTransfer() error check
  MdeModulePkg/UsbMassStorageDxe: Check Get Max LUN status/value

 MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c            | 16 +++++++++++++++-
 .../Bus/Usb/UsbMassStorageDxe/UsbMassBot.c         | 22 ++++++++++++++++++----
 2 files changed, 33 insertions(+), 5 deletions(-)

-- 
2.14.2.windows.3

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch V4 0/2] Add Max LUN status/value checks
Posted by Zeng, Star 6 years, 4 months ago
Reviewed-by: Star Zeng <star.zeng@intel.com>

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Michael D Kinney
Sent: Saturday, November 18, 2017 2:19 AM
To: edk2-devel@lists.01.org
Cc: Dong, Eric <eric.dong@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: [edk2] [Patch V4 0/2] Add Max LUN status/value checks

https://bugzilla.tianocore.org/show_bug.cgi?id=767

Changes in V4
* Fix return status from UsbGetMaxLun().

Changes in V3
* Only check number of bytes transfered if Direction is not UsbNoData.

Add error check to USB I/O Protocol UsbControlTransfer() for the number of bytes actually transfered.  If less than requested, then return EFI_DEVICE_ERROR.

Check Get Max LUN status/value in USB Mass Storage Driver to handle cases where USB device does not support Get Max LUN command or returned an invalud Max LUN value.

Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>

Michael D Kinney (2):
  MdeModulePkg/UsbBusDxe: Add UsbControlTransfer() error check
  MdeModulePkg/UsbMassStorageDxe: Check Get Max LUN status/value

 MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c            | 16 +++++++++++++++-
 .../Bus/Usb/UsbMassStorageDxe/UsbMassBot.c         | 22 ++++++++++++++++++----
 2 files changed, 33 insertions(+), 5 deletions(-)

--
2.14.2.windows.3

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel