From nobody Wed May 1 12:07:56 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1505357038442941.0885297867895; Wed, 13 Sep 2017 19:43:58 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 705E721DF808A; Wed, 13 Sep 2017 19:40:58 -0700 (PDT) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9602E21E87993 for ; Wed, 13 Sep 2017 19:40:56 -0700 (PDT) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Sep 2017 19:43:54 -0700 Received: from cchiu4-mobl1.gar.corp.intel.com ([10.5.240.32]) by orsmga005.jf.intel.com with ESMTP; 13 Sep 2017 19:43:53 -0700 X-Original-To: edk2-devel@lists.01.org X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,390,1500966000"; d="scan'208";a="148970061" From: "Chasel, Chiu" To: edk2-devel@lists.01.org Date: Thu, 14 Sep 2017 10:43:30 +0800 Message-Id: <20170914024330.8032-1-chasel.chiu@intel.com> X-Mailer: git-send-email 2.13.3.windows.1 Subject: [edk2] [PATCH] IntelFsp2Pkg-Tools: GenCfgOpt.py shouldn't include specific UPD name X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jiewen Yao MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" PcdSerialIoUartDebugEnable UPD is platform specific and should not be included in generic GenCfgOpt.py script. Remove this and platform DSC should control the default value instead. Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chasel Chiu Reviewed-by: Jiewen.yao@Intel.com Reviewed-by: Jiewen.yao@Intel.com --- IntelFsp2Pkg/Tools/GenCfgOpt.py | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/IntelFsp2Pkg/Tools/GenCfgOpt.py b/IntelFsp2Pkg/Tools/GenCfgOpt= .py index 6dc1b10b34..c9b7bc5373 100644 --- a/IntelFsp2Pkg/Tools/GenCfgOpt.py +++ b/IntelFsp2Pkg/Tools/GenCfgOpt.py @@ -289,7 +289,6 @@ class CGenCfgOpt: def __init__(self): self.Debug =3D False self.Error =3D '' - self.ReleaseMode =3D True =20 self._GlobalDataDef =3D """ GlobalDataDef @@ -318,13 +317,6 @@ EndList self._FvDir =3D '' self._MapVer =3D 0 =20 - def ParseBuildMode (self, OutputStr): - if "RELEASE_" in OutputStr: - self.ReleaseMode =3D True - if "DEBUG_" in OutputStr: - self.ReleaseMode =3D False - return - def ParseMacros (self, MacroDefStr): # ['-DABC=3D1', '-D', 'CFG_DEBUG=3D1', '-D', 'CFG_OUTDIR=3DBuild'] self._MacroDict =3D {} @@ -815,9 +807,6 @@ EndList TxtFd.write("%s.UnusedUpdSpace%d|%s0x%04X|0x%04X|{0}\n= " % (Item['space'], SpaceIdx, Default, NextOffset - StartAddr, Offset - Nex= tOffset)) SpaceIdx =3D SpaceIdx + 1 NextOffset =3D Offset + Item['length'] - if Item['cname'] =3D=3D 'PcdSerialIoUartDebugEnable': - if self.ReleaseMode =3D=3D False: - Item['value'] =3D 0x01 TxtFd.write("%s.%s|%s0x%04X|%s|%s\n" % (Item['space'],Item= ['cname'],Default,Item['offset'] - StartAddr,Item['length'],Item['value'])) TxtFd.close() return 0 @@ -1437,7 +1426,6 @@ def Main(): print "ERROR: Macro parsing failed !" return 3 =20 - GenCfgOpt.ParseBuildMode(sys.argv[3]) FvDir =3D sys.argv[3] if not os.path.exists(FvDir): os.makedirs(FvDir) --=20 2.13.3.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel