From nobody Sat Nov 2 08:38:25 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Authentication-Results: mx.zoho.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org; Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1492158951592779.7068628203239; Fri, 14 Apr 2017 01:35:51 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 969622194EB5C; Fri, 14 Apr 2017 01:35:49 -0700 (PDT) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7025021A04811 for ; Fri, 14 Apr 2017 01:35:48 -0700 (PDT) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP; 14 Apr 2017 01:35:48 -0700 Received: from shwde6388.ccr.corp.intel.com ([10.239.9.17]) by fmsmga005.fm.intel.com with ESMTP; 14 Apr 2017 01:35:46 -0700 X-Original-To: edk2-devel@lists.01.org X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,197,1488873600"; d="scan'208";a="88934347" From: Long Qin To: ting.ye@intel.com, edk2-devel@lists.01.org Date: Fri, 14 Apr 2017 16:35:25 +0800 Message-Id: <20170414083525.1372-1-qin.long@intel.com> X-Mailer: git-send-email 2.12.2.windows.1 Subject: [edk2] [Patch] CryptoPkg: Correct some minor issues in function comments X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Qin Long MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Correct some minor comment issues in BaseCryptLib.h and CryptPkcs7Verify.c, including: - missed "out" in parameter property for ARC4 interfaces; - Wrong Comment tail in Pkcs7GetAttachedContent function Cc: Ting Ye Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qin Long Signed-off-by: Long Qin Reviewed-by: Ye Ting =20 --- CryptoPkg/Include/Library/BaseCryptLib.h | 18 +++++++++-------= -- CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7Verify.c | 2 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/CryptoPkg/Include/Library/BaseCryptLib.h b/CryptoPkg/Include/L= ibrary/BaseCryptLib.h index 9f0f202668..9c5ffcd9cf 100644 --- a/CryptoPkg/Include/Library/BaseCryptLib.h +++ b/CryptoPkg/Include/Library/BaseCryptLib.h @@ -1790,10 +1790,10 @@ Arc4Init ( If Output is NULL, then return FALSE. If this interface is not supported, then return FALSE. =20 - @param[in] Arc4Context Pointer to the ARC4 context. - @param[in] Input Pointer to the buffer containing the data to b= e encrypted. - @param[in] InputSize Size of the Input buffer in bytes. - @param[out] Output Pointer to a buffer that receives the ARC4 enc= ryption output. + @param[in, out] Arc4Context Pointer to the ARC4 context. + @param[in] Input Pointer to the buffer containing the data = to be encrypted. + @param[in] InputSize Size of the Input buffer in bytes. + @param[out] Output Pointer to a buffer that receives the ARC4= encryption output. =20 @retval TRUE ARC4 encryption succeeded. @retval FALSE ARC4 encryption failed. @@ -1822,10 +1822,10 @@ Arc4Encrypt ( If Output is NULL, then return FALSE. If this interface is not supported, then return FALSE. =20 - @param[in] Arc4Context Pointer to the ARC4 context. - @param[in] Input Pointer to the buffer containing the data to b= e decrypted. - @param[in] InputSize Size of the Input buffer in bytes. - @param[out] Output Pointer to a buffer that receives the ARC4 dec= ryption output. + @param[in, out] Arc4Context Pointer to the ARC4 context. + @param[in] Input Pointer to the buffer containing the data = to be decrypted. + @param[in] InputSize Size of the Input buffer in bytes. + @param[out] Output Pointer to a buffer that receives the ARC4= decryption output. =20 @retval TRUE ARC4 decryption succeeded. @retval FALSE ARC4 decryption failed. @@ -2511,7 +2511,7 @@ Pkcs7Verify ( @retval TRUE The P7Data was correctly formatted for process= ing. @retval FALSE The P7Data was not correctly formatted for pro= cessing. =20 -*/ +**/ BOOLEAN EFIAPI Pkcs7GetAttachedContent ( diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7Verify.c b/CryptoP= kg/Library/BaseCryptLib/Pk/CryptPkcs7Verify.c index bf24e92127..45d5df5e11 100644 --- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7Verify.c +++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7Verify.c @@ -925,7 +925,7 @@ _Exit: @retval TRUE The P7Data was correctly formatted for process= ing. @retval FALSE The P7Data was not correctly formatted for pro= cessing. =20 -*/ +**/ BOOLEAN EFIAPI Pkcs7GetAttachedContent ( --=20 2.12.2.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel