From nobody Sat Nov 2 12:19:11 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Authentication-Results: mx.zoho.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org; Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 14906912862971015.4255457805973; Tue, 28 Mar 2017 01:54:46 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 68403200840CC; Tue, 28 Mar 2017 01:54:43 -0700 (PDT) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 24F71200840C6 for ; Tue, 28 Mar 2017 01:54:42 -0700 (PDT) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP; 28 Mar 2017 01:54:42 -0700 Received: from jfan12-desk.ccr.corp.intel.com ([10.239.158.57]) by FMSMGA003.fm.intel.com with ESMTP; 28 Mar 2017 01:54:40 -0700 X-Original-To: edk2-devel@ml01.01.org X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,236,1486454400"; d="scan'208";a="839216420" From: Jeff Fan To: edk2-devel@ml01.01.org Date: Tue, 28 Mar 2017 16:54:33 +0800 Message-Id: <20170328085433.24332-4-jeff.fan@intel.com> X-Mailer: git-send-email 2.9.3.windows.2 In-Reply-To: <20170328085433.24332-1-jeff.fan@intel.com> References: <20170328085433.24332-1-jeff.fan@intel.com> Subject: [edk2] [PATCH 3/3] UefiCpuPkg/PiSmmCpuDxeSmm: Update saved SMM ranges check in SmmProfile X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Kinney , Feng Tian , Jiewen Yao MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" SmmProfile feature required to protect all SMM ranges by structure mProtectionMemRangeTemplate. This update is to add additonal save SMM ranges into mProtectionMemRangeTemplate besides the range specified by mCpuHotPlugData.SmrrBase/mCpuHotPlugData.SmrrSiz. Cc: Jiewen Yao Cc: Michael Kinney Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan --- UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c | 42 +++++++++++++++++++++++++++++-= ---- 1 file changed, 36 insertions(+), 6 deletions(-) diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c b/UefiCpuPkg/PiSmmCpuDx= eSmm/SmmProfile.c index 7125aec..2713b19 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c @@ -83,6 +83,12 @@ MEMORY_PROTECTION_RANGE mProtectionMemRangeTemplate[] = =3D { {{0x00000000, 0x00000000},TRUE,TRUE}, =20 // + // SMRAM ranges not covered by mCpuHotPlugData.SmrrBase/mCpuHotPlugData.= SmrrSiz (to be fixed in runtime). + // It is always present and instruction fetches are allowed. + // {{0x00000000, 0x00000000},TRUE,FALSE}, + // + + // // Future extended range could be added here. // =20 @@ -360,7 +366,7 @@ InitProtectedMemRange ( { UINTN Index; UINTN NumberOfDescriptors; - UINTN NumberOfMmioDescriptors; + UINTN NumberOfAddedDescriptors; UINTN NumberOfProtectRange; UINTN NumberOfSpliteRange; EFI_GCD_MEMORY_SPACE_DESCRIPTOR *MemorySpaceMap; @@ -373,7 +379,7 @@ InitProtectedMemRange ( UINT64 Low4KBPageSize; =20 NumberOfDescriptors =3D 0; - NumberOfMmioDescriptors =3D 0; + NumberOfAddedDescriptors =3D mSmmCpuSmramRangeCount; NumberOfSpliteRange =3D 0; MemorySpaceMap =3D NULL; =20 @@ -386,12 +392,12 @@ InitProtectedMemRange ( ); for (Index =3D 0; Index < NumberOfDescriptors; Index++) { if (MemorySpaceMap[Index].GcdMemoryType =3D=3D EfiGcdMemoryTypeMemoryM= appedIo) { - NumberOfMmioDescriptors++; + NumberOfAddedDescriptors++; } } =20 - if (NumberOfMmioDescriptors !=3D 0) { - TotalSize =3D NumberOfMmioDescriptors * sizeof (MEMORY_PROTECTION_RANG= E) + sizeof (mProtectionMemRangeTemplate); + if (NumberOfAddedDescriptors !=3D 0) { + TotalSize =3D NumberOfAddedDescriptors * sizeof (MEMORY_PROTECTION_RAN= GE) + sizeof (mProtectionMemRangeTemplate); mProtectionMemRange =3D (MEMORY_PROTECTION_RANGE *) AllocateZeroPool (= TotalSize); ASSERT (mProtectionMemRange !=3D NULL); mProtectionMemRangeCount =3D TotalSize / sizeof (MEMORY_PROTECTION_RAN= GE); @@ -409,9 +415,27 @@ InitProtectedMemRange ( ASSERT (mSplitMemRange !=3D NULL); =20 // + // Create SMM ranges which are set to present and execution-enable. + // + NumberOfProtectRange =3D sizeof (mProtectionMemRangeTemplate) / sizeof= (MEMORY_PROTECTION_RANGE); + for (Index =3D 0; Index < mSmmCpuSmramRangeCount; Index++) { + if (mSmmCpuSmramRanges[Index].CpuStart >=3D mProtectionMemRange[0].R= ange.Base && + mSmmCpuSmramRanges[Index].CpuStart + mSmmCpuSmramRanges[Index].P= hysicalSize < mProtectionMemRange[0].Range.Top) { + // + // If the address have been already covered by mCpuHotPlugData.Smr= rBase/mCpuHotPlugData.SmrrSiz + // + break; + } + mProtectionMemRange[NumberOfProtectRange].Range.Base =3D mSmmCpuSmra= mRanges[Index].CpuStart; + mProtectionMemRange[NumberOfProtectRange].Range.Top =3D mSmmCpuSmra= mRanges[Index].CpuStart + mSmmCpuSmramRanges[Index].PhysicalSize; + mProtectionMemRange[NumberOfProtectRange].Present =3D TRUE; + mProtectionMemRange[NumberOfProtectRange].Nx =3D FALSE; + NumberOfProtectRange++; + } + + // // Create MMIO ranges which are set to present and execution-disable. // - NumberOfProtectRange =3D sizeof (mProtectionMemRangeTemplate) / siz= eof (MEMORY_PROTECTION_RANGE); for (Index =3D 0; Index < NumberOfDescriptors; Index++) { if (MemorySpaceMap[Index].GcdMemoryType !=3D EfiGcdMemoryTypeMemoryM= appedIo) { continue; @@ -422,6 +446,12 @@ InitProtectedMemRange ( mProtectionMemRange[NumberOfProtectRange].Nx =3D TRUE; NumberOfProtectRange++; } + + // + // Check and updated actual protected memory ranges count + // + ASSERT (NumberOfProtectRange <=3D mProtectionMemRangeCount); + mProtectionMemRangeCount =3D NumberOfProtectRange; } =20 // --=20 2.9.3.windows.2 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel